Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 21:11:24 +0000 (21:11 +0000)]
some refactoring
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-182
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 18:48:53 +0000 (18:48 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-10
oopsie, another stupid bug
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-181
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 18:23:11 +0000 (18:23 +0000)]
was too strict
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-180
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 18:12:45 +0000 (18:12 +0000)]
PDF + VarStream
* enhance PDF with photos
* VarStream :
this is a real kludge, it allows to access global variables like file.
every global var is accessible with 'var://varname' url.
really cool for the previous since I don't want to use temporary files.
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-179
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 15:24:19 +0000 (15:24 +0000)]
cosmetic
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-178
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 15:14:34 +0000 (15:14 +0000)]
notice the php-pfpf dependency
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-177
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 15:12:11 +0000 (15:12 +0000)]
clog
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-176
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 15:07:46 +0000 (15:07 +0000)]
new pdf
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-175
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 10:47:28 +0000 (10:47 +0000)]
updates
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-174
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 10:46:13 +0000 (10:46 +0000)]
updates
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-173
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 10:40:13 +0000 (10:40 +0000)]
renew cookie a little
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-172
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 10:02:56 +0000 (10:02 +0000)]
simplification
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-171
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 09:50:20 +0000 (09:50 +0000)]
wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-170
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 09:38:41 +0000 (09:38 +0000)]
bye bye caching. and other dead things
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-169
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 09:22:16 +0000 (09:22 +0000)]
slashes
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-168
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 09:14:17 +0000 (09:14 +0000)]
evts + epouses
* epouses validation ok
* evts validation ok
* evts code simplifications
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-167
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 08:43:31 +0000 (08:43 +0000)]
lists + photos OK
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-166
Pierre Habouzit (MadCoder [Wed, 29 Dec 2004 08:25:37 +0000 (08:25 +0000)]
magic_quotes, validations
* magic_quotes_gpc is now always _OFF_ (even if on in the php config, we revert the changes)
* new validation scheme, more robust, more complete, more powerfull, with comments support (to please OG) :
- only alias are in the new format.
- other validations are following.
* some corrections wrt {iterate}
* XOrgDB tweaks
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-165
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 17:42:29 +0000 (17:42 +0000)]
plugins are now *really* ok
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-164
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 17:38:37 +0000 (17:38 +0000)]
hooks are ok too
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-163
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 17:35:42 +0000 (17:35 +0000)]
plugins are now ok too
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-162
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 17:31:13 +0000 (17:31 +0000)]
move include/* to new DB API -- except for the profil part
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-161
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 16:15:01 +0000 (16:15 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-9
stupid bug
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-160
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 15:27:10 +0000 (15:27 +0000)]
new DB for a few includes. enjoy the silence
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-159
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 14:12:45 +0000 (14:12 +0000)]
dead code
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-158
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 14:08:18 +0000 (14:08 +0000)]
mescontacts.php is now clean from raw $globals->db calls
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-157
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 14:01:19 +0000 (14:01 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-8
Leca, Eric bug
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-156
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 13:53:19 +0000 (13:53 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-6
bugs
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-7
bugs
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-155
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 12:50:49 +0000 (12:50 +0000)]
perfs + new database access
* improve perfs wrt html escaping :
1. I do NOT understand php refs at all : call by ref seems to be slower than call by value !?
2. Based on (1), escape_html do not pass args by refs, but by value.
-> 25% of pure speed gain on mescontacts.php
* create {iterate ...} compiler function :
- works like {foreach} but you give a XOrgIterator for 'from'
- very very very nice for database lazy copying (we don't need mysql_assign anymore).
- mescontacts.php as a proof of concept.
* database access class :
- SQL abstractors sux, they are too complex
- drupal has nice things, I've inspired myself. The desired things are :
. drop magic_quotes_gpc
. maybe have one day some features wrt table names (some ACLs ?)
-> for that, our tiny engine is enough.
-> if it's sexy enough, I plan to make it enter diogenes.
- create SQL Iterators. nice, clears the mysql_datas.
-> make them lazy would be great though (memory ...)
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-154
Yann Chevalier [Tue, 28 Dec 2004 08:19:37 +0000 (08:19 +0000)]
table nationalites disappeared
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-153
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 07:59:40 +0000 (07:59 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-4
fix deco bug (XdX v2)
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-152
Pierre Habouzit (MadCoder [Tue, 28 Dec 2004 07:48:48 +0000 (07:48 +0000)]
backport
Patches applied:
* opensource@polytechnique.org--2005/platal--release--0.9.3--base-0
tag of opensource@polytechnique.org--2005/platal--mainline--0.9--patch-150
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-1
fix advanced search bug (XdX on support)
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-2
fix commit script
* opensource@polytechnique.org--2005/platal--release--0.9.3--patch-3
really ... fix commit script ... damnit
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-151
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 20:45:14 +0000 (20:45 +0000)]
typo
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-150
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 17:19:18 +0000 (17:19 +0000)]
omg ...
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-149
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 16:24:45 +0000 (16:24 +0000)]
closes #247
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-148
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 16:02:11 +0000 (16:02 +0000)]
clog
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-147
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 15:38:38 +0000 (15:38 +0000)]
oopsie
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-146
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 15:28:02 +0000 (15:28 +0000)]
more and more
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-145
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 15:01:31 +0000 (15:01 +0000)]
fucking overload
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-144
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 13:51:33 +0000 (13:51 +0000)]
oops
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-143
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 13:39:16 +0000 (13:39 +0000)]
oops
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-142
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 13:08:24 +0000 (13:08 +0000)]
date
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-141
Pierre Habouzit (MadCoder [Mon, 27 Dec 2004 12:55:43 +0000 (12:55 +0000)]
some stupidities, whole site scan for next release
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-140
Pierre Habouzit (MadCoder [Sun, 26 Dec 2004 22:53:37 +0000 (22:53 +0000)]
oops
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-139
Pierre Habouzit (MadCoder [Sun, 26 Dec 2004 14:20:36 +0000 (14:20 +0000)]
wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-138
Pierre Habouzit (MadCoder [Sun, 26 Dec 2004 14:13:09 +0000 (14:13 +0000)]
refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-137
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 20:31:38 +0000 (20:31 +0000)]
wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-136
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 20:28:29 +0000 (20:28 +0000)]
refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-135
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 20:16:12 +0000 (20:16 +0000)]
wiblle
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-134
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 20:11:00 +0000 (20:11 +0000)]
some more refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-133
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 17:49:15 +0000 (17:49 +0000)]
AUTHORS update
previous orderring was a nonsense + xmlrpc simplifications
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-132
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 16:03:11 +0000 (16:03 +0000)]
refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-131
Pierre Habouzit (MadCoder [Sat, 25 Dec 2004 11:55:20 +0000 (11:55 +0000)]
give right to ML moderators to change the moderation level of their list
that and some various bugfixes
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-130
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 19:50:43 +0000 (19:50 +0000)]
modules files update
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-129
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 19:25:13 +0000 (19:25 +0000)]
clog wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-128
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 19:23:09 +0000 (19:23 +0000)]
make config be built from a hook
no more dirty glob-include in include/conf.d !!!
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-127
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 18:58:47 +0000 (18:58 +0000)]
menu construction is now a pure hook
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-126
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 17:55:04 +0000 (17:55 +0000)]
work on hooks
* make globals->hook be an instance of XOrgHook
* make the menu be constructed by hooks:
- banan is a proof of concept
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-125
Pierre Habouzit (MadCoder [Thu, 23 Dec 2004 17:14:51 +0000 (17:14 +0000)]
make hooks a lot more simple
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-124
Pierre Habouzit (MadCoder [Tue, 21 Dec 2004 15:08:50 +0000 (15:08 +0000)]
bad path
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-123
Pierre Habouzit (MadCoder [Tue, 21 Dec 2004 14:42:05 +0000 (14:42 +0000)]
chmod
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-122
Raphael Marichez [Tue, 21 Dec 2004 14:38:43 +0000 (14:38 +0000)]
more precision in text of rewrite
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-121
Pierre Habouzit (MadCoder [Tue, 21 Dec 2004 14:37:19 +0000 (14:37 +0000)]
warning
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-120
Pierre Habouzit (MadCoder [Tue, 21 Dec 2004 14:22:58 +0000 (14:22 +0000)]
wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-119
Pierre Habouzit (MadCoder [Tue, 21 Dec 2004 14:13:24 +0000 (14:13 +0000)]
bounces + mail delivery
add the sendmail delivery in plat/al
work on the bounce proxy.
should be done (IMHO)
TODO : the cron that uses emails_broken to send the broken leg messages.
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-118
Pierre Habouzit (MadCoder [Mon, 20 Dec 2004 22:31:37 +0000 (22:31 +0000)]
some progress on the smtp bounce proxy
we don't want to make distinction between permanent or temporary
errors, because we should add a "unknown" level, and that will be too
complicated for really to little gain.
so we have basicaly :
- ignore (drop the mails)
- notice (forward the "bounce" as is - default)
- error (do the broken leg + forge a new bounce)
the errors levels are regexp-driven (read from a mysql db)
the only thing left is the treatment of the ERROR level (others are
fine, and the web interface to edit the regexps too)
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-117
Pierre Habouzit (MadCoder [Mon, 20 Dec 2004 19:02:37 +0000 (19:02 +0000)]
if they are not .sql files, it won't be magically used ...
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-116
Raphael Marichez [Mon, 20 Dec 2004 00:25:42 +0000 (00:25 +0000)]
'nationalite' field type on 'en_cours' : is an char(2), not integer
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-115
Raphael Marichez [Mon, 20 Dec 2004 00:24:07 +0000 (00:24 +0000)]
coherence
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-114
Raphael Marichez [Sun, 19 Dec 2004 19:41:53 +0000 (19:41 +0000)]
debug inscription/* and homonyms
- few sql syntax error
- alias "prenom.nom.NN" wasn't added in "aliases" in case of an homonym : usage of mailorg.
- in en_cours, uid is not an integer !
- prefer future bestalias rather than forlife in the processus of pre-registering
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-113
Pierre Habouzit (MadCoder [Sun, 19 Dec 2004 11:44:56 +0000 (11:44 +0000)]
refactor some ins code
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-112
Raphael Marichez [Sun, 19 Dec 2004 04:52:41 +0000 (04:52 +0000)]
syntax
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-111
Raphael Marichez [Sun, 19 Dec 2004 04:46:16 +0000 (04:46 +0000)]
fixing date_ins on envoidirect and drop obsolete fields
- few syntax bugfixes
- registering dates on marketing/envoidirect.php didn't work
- remove usage of envoidirect.nom,.prenom,.promo since it's in auth_user_md5 now
- test of registering as a new user : OK
- maybe todo : fix non-execution of "DELETE" in envoidirect.php (non critical)
- Happy holidays, Merry Christmas & Happy New Year !
- bn :)
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-110
Raphael Marichez [Sun, 19 Dec 2004 02:21:03 +0000 (02:21 +0000)]
avoids error "non SGML character"
avoids error "non SGML character" when title of an event contains an '
(e.g. "Recherche de Familles d\92accueil pour étudiants (...)")
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-109
Raphael Marichez [Sun, 19 Dec 2004 01:43:30 +0000 (01:43 +0000)]
wibble / typo
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-108
Raphael Marichez [Fri, 17 Dec 2004 21:23:44 +0000 (21:23 +0000)]
marketing : litte bugfix, and bestalias rather than forlife
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-107
Pierre Habouzit (MadCoder [Fri, 17 Dec 2004 16:20:42 +0000 (16:20 +0000)]
draft for a SMTP Bounce Proxy
quite advanced skeleton for an SMTP Bounce processing Proxy
search for < raise NotImplementedError > to find places that remains to be implemented.
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-106
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 19:58:57 +0000 (19:58 +0000)]
banana
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-105
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 19:13:36 +0000 (19:13 +0000)]
emails refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-104
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 19:04:27 +0000 (19:04 +0000)]
docs refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-103
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 19:00:01 +0000 (19:00 +0000)]
listes refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-102
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 18:25:54 +0000 (18:25 +0000)]
carnet refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-101
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 16:41:47 +0000 (16:41 +0000)]
refactor + better plots
* stats :
- better range definition for graphs.
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-100
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 16:23:33 +0000 (16:23 +0000)]
htdocs/admin/ refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-99
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 15:25:43 +0000 (15:25 +0000)]
plugins ok
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-98
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 15:22:36 +0000 (15:22 +0000)]
oopsy
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-97
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 15:18:16 +0000 (15:18 +0000)]
last refactoring in include/
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-96
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 15:10:07 +0000 (15:10 +0000)]
3 tons of code refactoring
note for anaxagore : there is coding rules. and they say we indent php with 4 spaces.
update Env::getMixed to return a ref and to return null if not set.
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-95
Pierre Habouzit (MadCoder [Wed, 15 Dec 2004 13:37:19 +0000 (13:37 +0000)]
create env access classes
there is now Env::, Session::, Get::, Post::, Cookie:: classes.
the duplication of code is awful, but is a result of the deficient PHP4 OO design.
it would be a lot better in php5 where 'self' is defined as the current class.
moreover, I used thoses classes in 3 pages for a proof of concept. code become much much clearer !
So i'll go through the entire site and remove direct accesses to POST/GET/REQUESTS/SESSION/COOKIE
note that PHP is not able to parse Session::get('log')->log(foo)
so for thoses exceptions, you have to do instead :
if (Session::has('log')) {
$_SESSION->log(foo);
}
which IMHO remains more readable than
if (isset($_SESSION['log'])) {
$_SESSION->log(foo);
}
purists would even use :
if ($logger = Session::getMixed('log')) {
$logger->log(foo);
}
or some other form that does not use $_SESSION explicitely
PS: maybe I should create a :
WIBBLE::callIfExists('log', Array('func', 'arg1', 'arg2', ...))
but I find that horrible to read. that's why I did'nt implemented it
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-94
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 20:04:33 +0000 (20:04 +0000)]
wibble
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-93
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 18:39:18 +0000 (18:39 +0000)]
refactor code
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-92
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 17:54:40 +0000 (17:54 +0000)]
the promised refactor. obvious, isn't it ?
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-91
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 17:44:03 +0000 (17:44 +0000)]
refactor fiche, to reuse code in other places (like vcard...)
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-90
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 17:14:57 +0000 (17:14 +0000)]
refactor + validate.pl
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-89
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 16:39:46 +0000 (16:39 +0000)]
refactor
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-88
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 16:32:55 +0000 (16:32 +0000)]
damnit
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-87
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 16:30:38 +0000 (16:30 +0000)]
refactor some code in lists + associated tests
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-86
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 15:29:01 +0000 (15:29 +0000)]
backport
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-85
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 11:51:43 +0000 (11:51 +0000)]
improve tests
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-84
Pierre Habouzit (MadCoder [Mon, 13 Dec 2004 10:58:35 +0000 (10:58 +0000)]
tests are important !
git-archimport-id: opensource@polytechnique.org--2005/platal--mainline--0.9--patch-83