Florent Bruneau [Mon, 31 Jan 2011 19:29:26 +0000 (20:29 +0100)]
Merge fail (bis).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 31 Jan 2011 19:27:44 +0000 (20:27 +0100)]
Fix syntax error.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 31 Jan 2011 19:26:21 +0000 (20:26 +0100)]
Merge fail (bis).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 31 Jan 2011 19:24:29 +0000 (20:24 +0100)]
Merge fail.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 31 Jan 2011 19:21:13 +0000 (20:21 +0100)]
Merge remote branch 'origin/xorg/maint' into xorg/master
Conflicts:
ChangeLog
Makefile
classes/userfilter/conditions.inc.php
core
htdocs/javascript/do_challenge_response.js
htdocs/javascript/password.js
htdocs/javascript/wiki.js
htdocs/javascript/xorg.js
include/massmailer.inc.php
modules/admin.php
modules/api.php
modules/axletter/axletter.inc.php
templates/admin/user.tpl
templates/axletter/admin.tpl
templates/axletter/edit.tpl
templates/axletter/index.tpl
templates/axletter/show.tpl
templates/emails/antispam.tpl
templates/emails/index.tpl
templates/events/form.tpl
templates/gadgets/ig-skin.tpl
templates/lists/index.tpl
templates/profile/fiche_referent.tpl
templates/search/index.tpl
templates/skin/common.bandeau.head.tpl
templates/skin/common.title.header.tpl
templates/survey/show_textarea.tpl
templates/survey/success.tpl
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
João Pedro Athayde Marcondes de André (JP) [Mon, 31 Jan 2011 17:36:09 +0000 (18:36 +0100)]
Rename file for dropping old tables so that we can do remove them once we have updated postfix everywhere
Raphaël Barrois [Mon, 31 Jan 2011 13:16:09 +0000 (14:16 +0100)]
Update all remaining references to old style axletter (reminder, register, user deletion)
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sun, 30 Jan 2011 23:40:12 +0000 (00:40 +0100)]
Insert release date into ChangeLog, fix NL upgrade script.
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Florent Bruneau [Sun, 30 Jan 2011 16:19:19 +0000 (17:19 +0100)]
Can select the type of section.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 30 Jan 2011 15:54:16 +0000 (16:54 +0100)]
Save answers.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 30 Jan 2011 14:45:16 +0000 (15:45 +0100)]
Improves usability.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 30 Jan 2011 14:15:39 +0000 (15:15 +0100)]
Support multiline text answers.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 30 Jan 2011 11:03:54 +0000 (12:03 +0100)]
Improvements and fixes for the surveys.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 19:47:00 +0000 (20:47 +0100)]
Update ChangeLog
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 22:04:42 +0000 (23:04 +0100)]
Fix the newsletter.send.php script
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Thu, 27 Jan 2011 23:47:01 +0000 (00:47 +0100)]
Enable links to EP letter in the menu.
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 23:33:24 +0000 (00:33 +0100)]
Update admin pages in order to list all NLs
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 23:37:49 +0000 (00:37 +0100)]
Enable link to NL pages in X.net groups. (Closes #774)
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Mon, 24 Jan 2011 00:23:54 +0000 (01:23 +0100)]
Update/merge Newsletter-related code. (Closes #1226, #858, #1047)
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 23:30:25 +0000 (00:30 +0100)]
Create the StoredUserFilterBuilder class.
It is used to wrap a UserFilterBuilder, keeping the environment for
filling it as well.
This allows to store the UFC generated by a UserFilterBuilder and the
values of the form which led to that UFC, so that the UFC can be later
edited with the same form.
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 23:29:51 +0000 (00:29 +0100)]
Add UFC_HasEmailRedirect / UFC_NLSubscribed
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Mon, 24 Jan 2011 14:43:39 +0000 (15:43 +0100)]
Fix UFC_Promo export
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Raphaël Barrois [Sat, 29 Jan 2011 19:52:25 +0000 (20:52 +0100)]
Use correct version of core.
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Florent Bruneau [Tue, 4 Jan 2011 20:51:37 +0000 (21:51 +0100)]
Happy New Year!
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Wed, 29 Dec 2010 01:07:27 +0000 (02:07 +0100)]
Adds search on subadministrativearea (Closes #1312).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sun, 19 Dec 2010 21:09:50 +0000 (22:09 +0100)]
Update jQuery, add jQuery Tmpl plugin in deps.
Use:
* jQuery 1.4.4
* jQuery UI 1.8.7
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Raphaël Barrois [Mon, 8 Nov 2010 17:19:55 +0000 (18:19 +0100)]
Add link to account types from account creation page.
Signed-off-by: Raphaël Barrois <raphael.barrois@polytechnique.org>
Florent Bruneau [Sun, 7 Nov 2010 16:36:46 +0000 (17:36 +0100)]
Javascript cleanup again.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 7 Nov 2010 15:48:17 +0000 (16:48 +0100)]
Improves jQuery extension in xorg.js.
This provides the following Ajax-based API:
$.xget(url, data, onSuccess, onError, type);
$.xgetJSON(url, data, onSuccess, onError);
$.xgetScript(url, onSuccess, onError);
$.xpost(url, data, onSuccess, onError, type);
These functions support does the same as the jQuery's default ajax
function (without 'x' prefix) but distinguish the case of http success and
the case of http error (500, 40x). By default onSuccess is null, while
onError display an alert.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 6 Nov 2010 22:44:51 +0000 (23:44 +0100)]
Remove ajax.js.
A large part of ajax.js has been integrated as an extension of jQuery
($([selector]).updateHtml(), ...).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 6 Nov 2010 20:27:29 +0000 (21:27 +0100)]
Move header javascript to xorg.js.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 6 Nov 2010 07:52:46 +0000 (08:52 +0100)]
Implements export() and fromExport() for UF and some UFCs.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 6 Nov 2010 07:52:46 +0000 (08:52 +0100)]
Implements export() and fromExport() on UFOs.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 5 Nov 2010 22:23:37 +0000 (23:23 +0100)]
Split userfilter.php
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 5 Nov 2010 22:14:14 +0000 (23:14 +0100)]
Update following core@
7da01959a.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 5 Nov 2010 21:08:37 +0000 (22:08 +0100)]
Minimum hacking to have a working site.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 30 Oct 2010 14:11:45 +0000 (16:11 +0200)]
Upgrade jquery for next release.
jQuery from 1.4.2 to 1.4.3
jQuery UI: from 1.6 to 1.8.5 (minified)
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Tue, 26 Oct 2010 20:14:59 +0000 (22:14 +0200)]
Set memory_limit to 64M and disable debug (and backtraces) in CLI scripts.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 17 Oct 2010 20:01:57 +0000 (22:01 +0200)]
Update core.
Also update the documentation of the parameters in platal.ini.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Thu, 27 Jan 2011 11:31:56 +0000 (12:31 +0100)]
Allows AX secretaries to see profiles on AX website.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Mon, 24 Jan 2011 21:10:24 +0000 (22:10 +0100)]
Improves answer reloading.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 24 Jan 2011 20:38:43 +0000 (21:38 +0100)]
Kill is_IE.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 24 Jan 2011 20:10:09 +0000 (21:10 +0100)]
Fix broken correctUserName.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 24 Jan 2011 16:19:11 +0000 (17:19 +0100)]
Minified version of jquery.tmpl is buggy, don't use it.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Mon, 24 Jan 2011 13:05:56 +0000 (14:05 +0100)]
Explains which addresses will be displayed in the directory (Closes #1379).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Mon, 24 Jan 2011 09:23:27 +0000 (10:23 +0100)]
Suggests user to delete obsolete addresses or jobs when she has more than one.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sun, 23 Jan 2011 22:07:29 +0000 (23:07 +0100)]
Can save multiple choice questions.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 23 Jan 2011 20:48:28 +0000 (21:48 +0100)]
Fixes survey js.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 23 Jan 2011 19:58:57 +0000 (20:58 +0100)]
Cleanup JS (based on JSLint advices).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 23 Jan 2011 19:58:55 +0000 (20:58 +0100)]
Update core
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 23 Jan 2011 15:11:45 +0000 (16:11 +0100)]
Much cleaner coding style.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Sun, 23 Jan 2011 14:37:33 +0000 (15:37 +0100)]
Shortens message when we refuse an entreprise.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sun, 23 Jan 2011 14:03:50 +0000 (15:03 +0100)]
No more references to platal_baseurl (url $.plURL() instead).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Sat, 22 Jan 2011 18:30:10 +0000 (19:30 +0100)]
Only cleans existing entreprise.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sat, 22 Jan 2011 15:55:12 +0000 (16:55 +0100)]
Merge more javascript files.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 22 Jan 2011 15:13:28 +0000 (16:13 +0100)]
Don't produce poisons when logged.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 22 Jan 2011 14:50:54 +0000 (15:50 +0100)]
Update core
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 21 Jan 2011 21:13:47 +0000 (22:13 +0100)]
Don't serve static files through PHP.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 21 Jan 2011 20:36:08 +0000 (21:36 +0100)]
Update core
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Fri, 21 Jan 2011 19:36:28 +0000 (20:36 +0100)]
Merge remote branch 'origin/xorg/1.0.2/master' into xorg/master
Florent Bruneau [Fri, 21 Jan 2011 19:28:00 +0000 (20:28 +0100)]
Allow compression of javascript, css, html and xml by apache.
Do not compress images: this is is a bit useless and it is not properly
supported by all browsers.
Note: This commit may require a bit of testing on all supported browsers.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Thu, 20 Jan 2011 21:18:34 +0000 (22:18 +0100)]
Merge css files.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Thu, 20 Jan 2011 20:50:12 +0000 (21:50 +0100)]
Update core
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Wed, 19 Jan 2011 09:53:52 +0000 (10:53 +0100)]
Fix download URL for openid.
Note: PHP-OpenId 2.1.3 is not available anymore. We need to test openid
authentication using the new version of openid.
Note2: Packaging from github suxx: it contains both a version number (in
the URL) and a commit-id (in the package content). This is just
unmaintainable and will break again and again in the future.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Tue, 18 Jan 2011 20:48:11 +0000 (21:48 +0100)]
Can add answers to a multiple-choices question.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Mon, 17 Jan 2011 20:41:49 +0000 (21:41 +0100)]
Bind JS to reloaded questions.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Mon, 17 Jan 2011 18:54:15 +0000 (19:54 +0100)]
Identation for new mail scheme update script.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Mon, 10 Jan 2011 23:08:47 +0000 (00:08 +0100)]
Indent, adds keys, fixes new email tables.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sun, 16 Jan 2011 16:45:48 +0000 (17:45 +0100)]
Merge branch 'xorg/1.0.2/master' into xorg/master
Florent Bruneau [Sun, 16 Jan 2011 16:45:30 +0000 (17:45 +0100)]
Merge branch 'xorg/maint' into xorg/1.0.2/master
Florent Bruneau [Sun, 16 Jan 2011 15:58:52 +0000 (16:58 +0100)]
Ensure autocommit is always activated.
This should have two major consequences:
* the rpc should have a view of the db consistent with the view of the
website
* this should reduce the overall memory footprint of the mysql database
since there is no "in progress transaction" and thus no need to keep old
data in the db.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 16 Jan 2011 15:27:15 +0000 (16:27 +0100)]
I need tracing to debug that one.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Tue, 11 Jan 2011 22:06:05 +0000 (23:06 +0100)]
Start working on multiple choice questions.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Tue, 11 Jan 2011 20:35:04 +0000 (21:35 +0100)]
Improves index page.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
João Pedro Athayde Marcondes de André (JP) [Tue, 11 Jan 2011 15:56:31 +0000 (16:56 +0100)]
Add flag inactive that is different from disabled. On the previous DB inactive corresponds to the '' option that is when the user has unmarked the redirection, while disabled is when the administrators have disabled the redirection/mail.
JP [Tue, 11 Jan 2011 11:29:59 +0000 (12:29 +0100)]
Oops. I had inversed alias/redirection here...
Florent Bruneau [Mon, 10 Jan 2011 21:09:14 +0000 (22:09 +0100)]
Small typo that caused headaches...
Because of this typo, edition of an existing survey was not possible.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Mon, 10 Jan 2011 14:31:30 +0000 (15:31 +0100)]
Updates ChangeLog.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Mon, 10 Jan 2011 20:07:47 +0000 (21:07 +0100)]
Fixes contact pdf export with pictures (Closes #1139).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Mon, 10 Jan 2011 20:07:10 +0000 (21:07 +0100)]
Updates Core.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Mon, 10 Jan 2011 09:46:00 +0000 (10:46 +0100)]
Adapts default picture to main education - picture by Kithyane (Closes #1270).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Sun, 9 Jan 2011 15:33:35 +0000 (16:33 +0100)]
Also merges masters and doctorates info; XXX: to be removed if we don't get the M/D list before the merge.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Sun, 9 Jan 2011 13:53:22 +0000 (14:53 +0100)]
Fixes csv downloading with IE8 (Closes #1325)
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sun, 9 Jan 2011 21:55:43 +0000 (22:55 +0100)]
Can save a new survey \o/
Still some bugs, but, hey, you can propose a survey and vote.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 9 Jan 2011 19:51:05 +0000 (20:51 +0100)]
Add labels.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 9 Jan 2011 18:54:50 +0000 (19:54 +0100)]
Lot of improvements of the survey edition form.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 9 Jan 2011 16:00:31 +0000 (17:00 +0100)]
Bases of survey edition interface.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sun, 9 Jan 2011 12:26:32 +0000 (13:26 +0100)]
Datepicker translation, minor theming improvements.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Sun, 9 Jan 2011 01:21:46 +0000 (02:21 +0100)]
Uses Post dedicated trim function when possible.
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Sun, 9 Jan 2011 01:16:33 +0000 (02:16 +0100)]
Allows email edition before mailing list validation (Closes #1371).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Sat, 8 Jan 2011 22:19:55 +0000 (23:19 +0100)]
Add survey edition form (lost a lot of time theming datepicker).
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 8 Jan 2011 20:21:48 +0000 (21:21 +0100)]
Cleanup gitignore.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 8 Jan 2011 20:06:46 +0000 (21:06 +0100)]
Cleanup javascript again.
* include core.js
* fix line encoding of sha1.js/secure_hash.js and merge the files
* update code to use $.dynPost() instead of dynpost and dynpostkv
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 8 Jan 2011 19:01:50 +0000 (20:01 +0100)]
Small improvements.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 8 Jan 2011 15:18:11 +0000 (16:18 +0100)]
Rewrite form generation.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Florent Bruneau [Sat, 8 Jan 2011 11:46:12 +0000 (12:46 +0100)]
Merge close_on_esc.js into xorg.js.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
Stéphane Jacob [Fri, 7 Jan 2011 23:26:45 +0000 (00:26 +0100)]
Removes duplicated city and postal code in vcard addresses (Closes #1322).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Fri, 7 Jan 2011 23:06:01 +0000 (00:06 +0100)]
Displays email aliases in vcards when public (Closes #1323).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Stéphane Jacob [Fri, 7 Jan 2011 20:18:23 +0000 (21:18 +0100)]
Fixes display of payments on xnet (Closes #1290).
Signed-off-by: Stéphane Jacob <sj@m4x.org>
Florent Bruneau [Fri, 7 Jan 2011 20:14:06 +0000 (21:14 +0100)]
Simplify js.
Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>