From: Florent Bruneau <florent.bruneau@polytechnique.org>
Date: Fri, 13 Feb 2009 21:38:33 +0000 (+0100)
Subject: No more auth_user in stats.
X-Git-Tag: xorg/1.0.0~332^2~369
X-Git-Url: http://git.polytechnique.org/?a=commitdiff_plain;h=f476ca600ff3a354d2a3c93a1a7014e532d463f4;p=platal.git

No more auth_user in stats.

Signed-off-by: Florent Bruneau <florent.bruneau@polytechnique.org>
---

diff --git a/modules/stats.php b/modules/stats.php
index 7fba02a..2304aaa 100644
--- a/modules/stats.php
+++ b/modules/stats.php
@@ -64,13 +64,14 @@ class StatsModule extends PLModule
         define('DUREEJOUR', 24 * 3600);
 
         //recupere le nombre d'inscriptions par jour sur la plage concernée
-        // FIXME: don't count dead peaple
         $res = XDB::iterRow('SELECT  IF(registration_date > DATE_SUB(NOW(), INTERVAL {?} DAY),
                                         TO_DAYS(registration_date) - TO_DAYS(NOW()),
                                         -{?}) AS jour,
                                      COUNT(uid) AS nb
-                               FROM  accounts
-                              WHERE  state = \'active\'
+                               FROM  accounts AS a
+                          LEFT JOIN  account_profiles AS ap ON(ap.uid = a.uid AND FIND_IN_SET(\'owner\', ap.flags))
+                          LEFT JOIN  profiles AS p ON (ap.pid = p.pid)
+                              WHERE  state = \'active\' AND p.deathdate IS NULL
                            GROUP BY  jour', (int)$jours, 1 + (int)$jours);
 
         //genere des donnees compatibles avec GNUPLOT
@@ -129,12 +130,12 @@ EOF2;
             $depart = 1930;
 
             //recupere le nombre d'inscriptions par jour sur la plage concernée
-            // XXX: Manage dead peaple...
             $res = XDB::iterRow("SELECT  pe.entry_year AS promo, SUM(state = 'active') / COUNT(*) * 100
                                    FROM  accounts AS a
                              INNER JOIN  account_profiles AS ap ON (ap.uid = a.uid AND FIND_IN_SET('owner', ap.perms))
+                             INNER JOIN  profiles AS p ON (p.pid = ap.pid)
                              INNER JOIN  profile_education AS pe ON (pe.uid = ap.pid AND FIND_IN_SET('primary', pe.flags))
-                                  WHERE  pe.entry_year >= {?}
+                                  WHERE  pe.entry_year >= {?} AND p.deathdate IS NULL
                                GROUP BY  promo", $depart);
 
             //genere des donnees compatibles avec GNUPLOT
@@ -179,7 +180,6 @@ EOF2;
             $jours = 365;
             define('DUREEJOUR', 24 * 3600);
 
-            // XXX: And promo again \o/
             $res = XDB::query("SELECT  MIN(TO_DAYS(a.registration_date) - TO_DAYS(NOW()))
                                  FROM  accounts AS a
                            INNER JOIN  account_profiles AS ap ON (ap.uid = a.uid AND FIND_IN_SET('owner', ap.perms))
@@ -313,17 +313,17 @@ EOF2;
             $time = ' AND e.stamp > DATE_SUB(CURDATE(), INTERVAL 1 ' . strtoupper($period) . ')';
             break;
         }
-        // XXX: Need to be port to profile stuff
-        $rows = XDB::iterator("SELECT  IF(u.nom_usage != '', u.nom_usage, u.nom) AS nom,
-                                       u.prenom, u.promo, e.data AS forlife, COUNT(*) AS count
-                                 FROM  logger.events AS e
-                           INNER JOIN  logger.actions AS act ON (e.action = act.id)
-                           INNER JOIN  aliases AS a ON (a.alias = e.data)
-                           INNER JOIN  auth_user_md5 AS u ON (u.user_id = a.id)
-                                WHERE  act.text = 'view_profile' $time
-                             GROUP BY  e.data
-                             ORDER BY  count DESC
-                                LIMIT  10");
+        $rows = XDB::fetchAllAssoc("SELECT  p.pid AS profile, COUNT(*) AS count
+                                      FROM  logger.events AS e
+                                INNER JOIN  logger.actions AS act ON (e.action = act.id)
+                                INNER JOIN  profiles AS p ON (p.hrpid = e.data)
+                                     WHERE  act.text = 'view_profile' $time
+                                  GROUP BY  e.data
+                                  ORDER BY  count DESC
+                                     LIMIT  10");
+        foreach ($rows as $key=>$row) {
+            $rows[$key]['profile'] = Profile::get($rows[$key]['profile']);
+        }
         $page->assign('profiles', $rows);
         $page->assign('period', $period);
     }
diff --git a/templates/stats/profile.tpl b/templates/stats/profile.tpl
index 339f0e4..4f030c2 100644
--- a/templates/stats/profile.tpl
+++ b/templates/stats/profile.tpl
@@ -54,12 +54,12 @@
     <th>Nom</th>
     {if hasPerms('admin')}<th>Consultations</th>{/if}
   </tr>
-  {iterate from=$profiles item=profile}
+  {foreach from=$profiles item=profile}
   <tr class="{cycle values="pair,impair"}">
-    <td><a href="profile/{$profile.forlife}" class="popup">{$profile.prenom} {$profile.nom} (X{$profile.promo})</a></td>
+    <td>{profile user=$profile.profile promo=true}</td>
     {if hasPerms('admin')}<td class="right">{$profile.count}</td>{/if}
   </tr>
-  {/iterate}
+  {/foreach}
 </table>
 
 {* vim:set et sw=2 sts=2 sws=2 enc=utf-8: *}