From: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
Date: Sun, 3 Nov 2013 17:00:07 +0000 (+0100)
Subject: Fix Javascript exception by adding invisible elements
X-Git-Tag: xorg/1.1.10~12^2~3
X-Git-Url: http://git.polytechnique.org/?a=commitdiff_plain;h=f25e85b800385a3a2a18966791a80788205841f4;p=platal.git

Fix Javascript exception by adding invisible elements

_selectAll('to_contacts') and _selectAll('cc_contacts') were raising:
"TypeError: Cannot read property 'length' of null"
Add missing <select> elements until the code is rewritten to take care of this
situation.

Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
---

diff --git a/templates/emails/send.tpl b/templates/emails/send.tpl
index 0a321b6..ab40ffd 100644
--- a/templates/emails/send.tpl
+++ b/templates/emails/send.tpl
@@ -288,6 +288,19 @@
     </tr>
     {/if}
   </table>
+  {if $contacts|@count eq 0}
+    {* Current Javascript code needs some elements to exist. *}
+    {* TODO: rewrite the code to accept non-existent elements without raising exceptions *}
+    <select id="to_contacts" name="to_contacts[]" multiple="multiple" style="display: none;">
+      <option value="">&nbsp;</option>
+    </select>
+    <select id="cc_contacts" name="cc_contacts[]" multiple="multiple" style="display: none;">
+      <option value="">&nbsp;</option>
+    </select>
+    <select id="contacts" name="all_contacts[]" multiple="multiple" style="display: none;">
+      <option value="">&nbsp;</option>
+    </select>
+  {/if}
   <fieldset>
     <legend>Sujet&nbsp;:&nbsp;<input type='text' name='sujet' size='60' value="{$smarty.request.sujet}" /></legend>
     <div class="center">