From: Stéphane Jacob Date: Sat, 5 Nov 2011 17:13:34 +0000 (+0100) Subject: Fixes security issue in User::getLogin introduced in 7de5cd885589022b78b29d7881ec9922... X-Git-Tag: xorg/1.1.4~26 X-Git-Url: http://git.polytechnique.org/?a=commitdiff_plain;h=bfc34dc5b61be15b1d3eea7adf651bf9390bc6ad;p=platal.git Fixes security issue in User::getLogin introduced in 7de5cd885589022b78b29d7881ec9922408339d6. Signed-off-by: Stéphane Jacob --- diff --git a/classes/user.php b/classes/user.php index a0b28ea..7723c3f 100644 --- a/classes/user.php +++ b/classes/user.php @@ -83,10 +83,10 @@ class User extends PlUser } // Checks whether $login is a valid hruid or not. - $res = XDB::query("SELECT uid + $res = XDB::query('SELECT uid FROM accounts - WHERE hruid LIKE CONCAT('%', {?}, '%')", $login); - if ($res->numRows()) { + WHERE hruid' . XDB::formatWildcards(XDB::WILDCARD_CONTAINS, $login)); + if ($res->numRows() == 1) { return $res->fetchOneCell(); }