From: Stéphane Jacob <sj@m4x.org>
Date: Sun, 18 Jul 2010 12:59:08 +0000 (+0200)
Subject: Edits TODOs and XXXs.
X-Git-Tag: xorg/1.0.1~319
X-Git-Url: http://git.polytechnique.org/?a=commitdiff_plain;h=7a12b2ca5eae8fbbdf0b32e43a2d8c2c6bd705ab;p=platal.git

Edits TODOs and XXXs.

Signed-off-by: Stéphane Jacob <sj@m4x.org>
---

diff --git a/classes/xorgsession.php b/classes/xorgsession.php
index 7789318..4224920 100644
--- a/classes/xorgsession.php
+++ b/classes/xorgsession.php
@@ -86,7 +86,7 @@ class XorgSession extends PlSession
                           $login);
         if (list($uid, $password) = $res->fetchOneRow()) {
             $expected_response = sha1("$uname:$password:" . S::v('challenge'));
-            /* XXX: Deprecates len(password) > 10 conversion */
+            /* Deprecates len(password) > 10 conversion. */
             if ($response != $expected_response) {
                 if (!S::logged()) {
                     Platal::page()->trigError('Mot de passe ou nom d\'utilisateur invalide');
diff --git a/include/profilefields.inc.php b/include/profilefields.inc.php
index c170278..16b8e1e 100644
--- a/include/profilefields.inc.php
+++ b/include/profilefields.inc.php
@@ -46,7 +46,8 @@ abstract class ProfileField
      * @param $pids An array of pids
      * @param $visibility The level of visibility fetched fields must have
      * @return a PlIterator yielding data suitable for a "new ProfileBlah($data)"
-     * XXX MUST be reimplemented for each kind of ProfileField
+     *
+     * MUST be reimplemented for each kind of ProfileField.
      */
     public static function fetchData(array $pids, ProfileVisibility $visibility)
     {
@@ -935,7 +936,6 @@ class CompanyList
             self::$companies[$row['id']] = $cp;
         }
 
-        // TODO: determine whether there can be phones attached to a hq's address
         // Add phones to hq
         if (count($newcompanies)) {
             $it = XDB::iterator('SELECT  search_tel AS search, display_tel AS display, comment, link_id, tel_type AS type, link_type, tel_id AS id
diff --git a/modules/auth/auth.inc.php b/modules/auth/auth.inc.php
index f41b600..383745a 100644
--- a/modules/auth/auth.inc.php
+++ b/modules/auth/auth.inc.php
@@ -34,7 +34,7 @@ function gpex_make($chlg, $privkey, $datafields, $charset)
 
     $user =& S::user();
     if ($user->hasProfile()) {
-        // XXX: Transition table for auth.
+        /* Transition table for authentification. */
         $personnal_data = $user->profile()->data();
         $personnal_data['matricule'] = $personnal_data['xorg_id'];
         $personnal_data['matricule_ax'] = $personnal_data['ax_id'];
diff --git a/modules/axletter.php b/modules/axletter.php
index b47f1c5..d08b0bc 100644
--- a/modules/axletter.php
+++ b/modules/axletter.php
@@ -179,7 +179,7 @@ class AXLetterModule extends PLModule
                     }
                     $page->trigSuccess("Les adresses soumises correspondent à un total de " . count(array_unique($ids)) . " camarades.");
                 }
-                // XXX : no break here, since Vérifier is a subcase of Aperçu.
+                // No break here, since Vérifier is a subcase of Aperçu.
               case 'Aperçu':
                 $this->load('axletter.inc.php');
                 $al = new AXLetter(array($id, $short_name, $subject, $title, $body, $signature,
diff --git a/modules/profile.php b/modules/profile.php
index 473db30..8f60003 100644
--- a/modules/profile.php
+++ b/modules/profile.php
@@ -76,7 +76,9 @@ class ProfileModule extends PLModule
         );
     }
 
-    /* XXX COMPAT */
+    /* Function needed for compatibility reasons.
+     * TODO: removes calls to fiche.php?user=blah.machin.2083 and then removes this.
+     */
     function handler_fiche(&$page)
     {
         return $this->handler_profile($page, Env::v('user'));