From: Stéphane Jacob <sj@m4x.org>
Date: Mon, 13 Aug 2012 12:27:14 +0000 (+0200)
Subject: Adds TODOs to fix homonym robot.
X-Git-Tag: xorg/1.1.9~30
X-Git-Url: http://git.polytechnique.org/?a=commitdiff_plain;h=288aca61a0e72fef9874d017992bbdcabfbae67b;p=platal.git

Adds TODOs to fix homonym robot.

Signed-off-by: Stéphane Jacob <sj@m4x.org>
---

diff --git a/modules/admin/homonyms.inc.php b/modules/admin/homonyms.inc.php
index 8b76fcd..91933c0 100644
--- a/modules/admin/homonyms.inc.php
+++ b/modules/admin/homonyms.inc.php
@@ -94,6 +94,7 @@ function fix_homonym(PlUser $user, $email)
                  $email);
 
     $hrmid = User::makeHomonymHrmid($email);
+    // TODO: insert twice into source_other if different domains
     XDB::execute('INSERT INTO  email_source_other (hrmid, email, domain, type, expire)
                        SELECT  {?}, {?}, id, \'homonym\', NOW()
                          FROM  email_virtual_domains
diff --git a/modules/register/register.inc.php b/modules/register/register.inc.php
index ca1c823..daacf51 100644
--- a/modules/register/register.inc.php
+++ b/modules/register/register.inc.php
@@ -200,6 +200,7 @@ function createAliases($subState)
             XDB::execute('INSERT IGNORE INTO  homonyms_list (hrmid, uid)
                                       VALUES  ({?}, {?})',
                          $hrmid, $subState->i('uid'));
+            // TODO: insert into source_other if new domain
         }
 
         $subState->set('forlife', $forlife);