Prevents password hashs from being broadcasted by email (Closes #965).
authorVincent Zanotti <vincent.zanotti@m4x.org>
Sat, 4 Apr 2009 10:13:49 +0000 (12:13 +0200)
committerVincent Zanotti <vincent.zanotti@m4x.org>
Sat, 4 Apr 2009 10:13:49 +0000 (12:13 +0200)
Signed-off-by: Vincent Zanotti <vincent.zanotti@m4x.org>
modules/admin.php

index 40df9da..9c84011 100644 (file)
@@ -572,6 +572,12 @@ class AdminModule extends PLModule
                         user_reindex($user->id());
                         $new_fields = XDB::query($watch_query, $user->id())->fetchOneAssoc();
 
+                        // Redacts the password in the notification, to avoiding transmitting
+                        // sensitive information by email.
+                        $new_fields['password'] = ($old_fields['password'] != $new_fields['password'] ? 'new' : 'old');
+                        $old_fields['password'] = 'old';
+
+                        // Emails the admins to notify the profile update.
                         $mailer = new PlMailer("admin/useredit.mail.tpl");
                         $mailer->assign("admin", S::user()->login());
                         $mailer->assign("user", $user->login());