In the form to add a new "external account", the type "Personnel de
l'AX" is selected by default, which may lead to incorrect account hruid
when an admin forgets to change this type. To prevent this issue, a new
empty type is added in the HTML form.
$sex = Post::s('sex');
$email = Post::t('email');
$type = Post::s('type');
$sex = Post::s('sex');
$email = Post::t('email');
$type = Post::s('type');
- $login = PlUser::makeHrid($firstname, $lastname, $type);
- if (!isvalid_email($email)) {
+ if (!$type) {
+ $page->trigError("Empty account type");
+ } elseif (!isvalid_email($email)) {
$page->trigError("Invalid email address: $email");
$page->trigError("Invalid email address: $email");
- } else if (strlen(Post::s('pwhash')) != 40) {
+ } elseif (strlen(Post::s('pwhash')) != 40) {
$page->trigError("Invalid password hash");
} else {
$page->trigError("Invalid password hash");
} else {
+ $login = PlUser::makeHrid($firstname, $lastname, $type);
$full_name = $firstname . ' ' . $lastname;
$directory_name = $lastname . ' ' . $firstname;
XDB::execute("INSERT INTO accounts (hruid, type, state, password,
$full_name = $firstname . ' ' . $lastname;
$directory_name = $lastname . ' ' . $firstname;
XDB::execute("INSERT INTO accounts (hruid, type, state, password,
<td class="titre">Type de compte</td>
<td>
<select name="type">
<td class="titre">Type de compte</td>
<td>
<select name="type">
+ <option value="" disabled selected>-</option>
<option value="ax">Personnel de l'AX</option>
<option value="fx">Personnel de la FX</option>
<option value="school">Personnel de l'Ecole</option>
<option value="ax">Personnel de l'AX</option>
<option value="fx">Personnel de la FX</option>
<option value="school">Personnel de l'Ecole</option>