X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=philter%2Fphilter%2Fphilter.js;h=30b573b4bf761e0f7a8bc4fa6d6be7f5468471ea;hb=3c5f3144e1412aa53951111a1b345f00965dfb17;hp=806062dd6b1bc24b190507601b04dcb2416e0891;hpb=4956445bb7da02adee93a10bcc6d038d1f676cb2;p=old-projects.git

diff --git a/philter/philter/philter.js b/philter/philter/philter.js
index 806062d..30b573b 100644
--- a/philter/philter/philter.js
+++ b/philter/philter/philter.js
@@ -29,10 +29,10 @@ function getElement(obj) {
     return false;
 }
 
-function del_onclick(button) {
-    if(window.confirm("Voulez vous réellement supprimer cette adresse mail ?")) {
-        getElement('emailsDel').value = button.name.slice(1);
-        button.form.submit();
+function del_onclick(val) {
+    if(window.confirm(del_q_i18n)) {
+        getElement('emailsDel').value = val;
+        document.forms['emails'].submit();
     }
 }
 
@@ -60,7 +60,7 @@ function order_up() {
 
 function order_dn() {
     form = document.forms['order'];
-    select = getElement['orderSelect'];
+    select = getElement('orderSelect');
 
     if(select.selectedIndex>0 && select.selectedIndex<select.length-1) {
         i = select.selectedIndex;
@@ -102,14 +102,19 @@ var current_rule;
 var actions_i = 0;
 var matches_i = 0;
 
+var del_i18n = 'Del';
+var del_q_i18n = 'Del';
+
 /********** RULE.ACTION FORM FUNCTIONS **********/
 
-function createActionSelect(data,base) {
+function createActionSelect(div,data) {
     var i,j;
     var select = document.createElement("select");
     var sel = 0;
-    select.name = base+'[0]';
+    select.name = div.name+'[0]';
 
+    // OG: must insert select node before creating options because of IE5 bug
+    div.appendChild(select);
     for(i=0, j=0; i<actions_list.length; i++) {
         if(data==i) sel = j;
         if(actions_list[i]) select.options[j++] = new Option(actions_list[i],i,false,(data==i));
@@ -129,14 +134,13 @@ function createActionRow(Node,data) {
 
     var del = document.createElement("input");
     del.setAttribute("type", "submit");
-    del.setAttribute("value", "Del");
+    del.setAttribute("value", del_i18n);
     del.onclick = function () { del.parentNode.parentNode.removeChild(del.parentNode); };
     div.appendChild(del);
 
     div.appendChild(document.createTextNode(" "));
 
-    var select = createActionSelect(data[0],div.name);
-    div.appendChild(select);
+    var select = createActionSelect(div,data[0]);
 
     actions_func[select.options[select.selectedIndex].value](div,data);
 }
@@ -147,12 +151,14 @@ function newAction() {
 
 /********** RULE.MATCH FORM FUNCTIONS **********/
 
-function createMatchSelect(data,base) {
+function createMatchSelect(div,data) {
     var i,j;
     var select = document.createElement("select");
     var sel = 0;
-    select.name = base+'[0]';
+    select.name = div.name+'[0]';
 
+    // OG: must insert select node before creating options because of IE5 bug
+    div.appendChild(select);
     for(i=0, j=0; i<matches_list.length; i++) {
         if(data==i) sel = j;
         if(matches_list[i]) select.options[j++] = new Option(matches_list[i],i,false,(data==i));
@@ -172,14 +178,13 @@ function createMatchRow(Node,data) {
 
     var del = document.createElement("input");
     del.setAttribute("type", "submit");
-    del.setAttribute("value", "Del");
+    del.setAttribute("value", del_i18n);
     del.onclick = function () { del.parentNode.parentNode.removeChild(del.parentNode); };
     div.appendChild(del);
 
     div.appendChild(document.createTextNode(" "));
 
-    var select = createMatchSelect(data[0],div.name);
-    div.appendChild(select);
+    var select = createMatchSelect(div,data[0]);
 
     matches_func[select.options[select.selectedIndex].value](div,data);
 }