X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=modules%2Fsurvey%2Fsurvey.inc.php;h=6d8a41028df2e7b01ad5f166f299fafba8e764e9;hb=1bf36cd12647c3d2eb8f9ec2a1f0eaad0b5f7e81;hp=168a2261b4ec691dfda696d93f66f3516c0efbc5;hpb=cd129064288dd23aa99e22adefe3c1900cf912d7;p=platal.git diff --git a/modules/survey/survey.inc.php b/modules/survey/survey.inc.php index 168a226..6d8a410 100644 --- a/modules/survey/survey.inc.php +++ b/modules/survey/survey.inc.php @@ -1,6 +1,6 @@ "sondage ouvert à tout le monde, anonyme", + private static $longModes = array(self::MODE_ALL => "sondage ouvert à tout le monde, anonyme", self::MODE_XANON => "sondage restreint aux polytechniciens, anonyme", self::MODE_XIDENT => "sondage restreint aux polytechniciens, non anonyme"); private static $shortModes = array(self::MODE_ALL => "tout le monde, anonyme", @@ -37,11 +37,13 @@ class Survey return ($long)? self::$longModes : self::$shortModes; } - private static $types = array('text' => 'texte court', - 'textarea' => 'texte long', - 'num' => 'numérique', - 'radio' => 'radio', - 'checkbox' => 'checkbox'); + private static $types = array('text' => 'Texte court', + 'textarea' => 'Texte long', + 'num' => 'Numérique', + 'radio' => 'Choix multiples (une réponse)', + 'checkbox' => 'Choix multiples (plusieurs réponses)', + 'radiotable' => 'Questions multiples à choix multiples (une réponse)', + 'checkboxtable' => 'Questions multiples à choix mutliples (plusieurs réponses)'); public static function getTypes() { @@ -76,15 +78,12 @@ class Survey { $this->title = $args['title']; $this->description = $args['description']; - if (preg_match('#^\d{2}/\d{2}/\d{4}$#', $args['end'])) { - $this->end = preg_replace('#^(\d{2})/(\d{2})/(\d{4})$#', '\3-\2-\1', $args['end']); - } else { - $this->end = (preg_match('#^\d{4}-\d{2}-\d{2}$#', $args['end']))? $args['end'] : '#'; - } + $this->end = $args['end']; $this->mode = (isset($args['mode']))? $args['mode'] : self::MODE_ALL; if ($this->mode == self::MODE_ALL) { $args['promos'] = ''; } + $args['promos'] = str_replace(' ', '', $args['promos']); $this->promos = ($args['promos'] == '' || preg_match('#^(\d{4}-?|(\d{4})?-\d{4})(,(\d{4}-?|(\d{4})?-\d{4}))*$#', $args['promos']))? $args['promos'] : '#'; } // }}} @@ -100,7 +99,7 @@ class Survey if ($this->promos == '') { return true; } - $promos = explode('|', $this->promos); + $promos = explode(',', $this->promos); foreach ($promos as $p) { if ((preg_match('#^\d{4}$#', $p) && $p == $promo) || (preg_match('#^\d{4}-$#', $p) && intval(substr($p, 0, 4)) <= $promo) || @@ -162,10 +161,7 @@ class Survey $q = $this->questions[$k]->toArray(); $q['id'] = $k; if ($this->isEnded()) { // if the survey is ended, then adds here the results of this question - $sql = $this->questions[$k]->buildResultRequest(); - if ($sql != '') { - $q['result'] = XDB::iterator($sql, $this->id, $k); - } + $q['result'] = $this->questions[$k]->getResultArray($this->id, $k); } $qArr[$k] = $q; } @@ -186,54 +182,58 @@ class Survey $csv_output = ''; $csv = fopen('var://csv_output', 'w'); $line = ($this->isMode(self::MODE_XIDENT))? array('id', 'Nom', 'Prenom', 'Promo') : array('id'); + $qids = array(); for ($qid = 0; $qid < $nbq; $qid++) { - $line[] = $this->questions[$qid]->getCSVColumn(); // the fist line contains the questions + $qids[$qid] = count($line); // stores the first id of a question (in case of questions with subquestions) + array_splice($line, count($line), 0, $this->questions[$qid]->getCSVColumns()); // the first line contains the questions } + $nbf = count($line); $users = array(); if ($this->isMode(self::MODE_XIDENT)) { // if the mode is non anonymous - $sql = 'SELECT v.id AS vid, a.nom, a.prenom, a.promo - FROM survey_votes AS v - INNER JOIN auth_user_md5 AS a - ON a.user_id=v.user_id - WHERE v.survey_id={?} - ORDER BY vid ASC;'; - $res = XDB::iterator($sql, $this->id); // retrieves all users data - for ($u = $res->next(); $u != null; $u = $res->next()) { - $users[$u['vid']] = array('nom' => $u['nom'], 'prenom' => $u['prenom'], 'promo' => $u['promo']); - } + $users = User::getBulkUsersWithUIDs(XDB::fetchAllAssoc('vid', 'SELECT v.id AS vid, v.uid + FROM survey_votes AS v + WHERE v.survey_id = {?} + ORDER BY vid ASC', + $this->id)); } - $sql = 'SELECT v.id AS vid, a.question_id AS qid, a.answer + $sql = 'SELECT v.id AS vid, a.question_id AS qid, a.answer AS answer FROM survey_votes AS v LEFT JOIN survey_answers AS a ON a.vote_id=v.id WHERE v.survey_id={?} - ORDER BY vid ASC, qid ASC;'; + ORDER BY vid ASC, qid ASC, answer ASC;'; $res = XDB::iterator($sql, $this->id); // retrieves all answers from database - $cur = $res->next(); $vid = -1; $vid_ = 0; - $first = ($this->isMode(self::MODE_XIDENT))? 4 : 1; - while ($cur != null) { + while (($cur = $res->next()) != null) { if ($vid != $cur['vid']) { // if the vote id changes, then starts a new line fputcsv($csv, $line, $sep, $enc); // stores the former line into $csv_output $vid = $cur['vid']; - $line = array_fill(0, $first + $nbq, ''); // creates an array full of empty string + $line = array_fill(0, $nbf, ''); // creates an array full of empty string $line[0] = $vid_; // the first field is a 'clean' vote id (not the one stored in database) if ($this->isMode(self::MODE_XIDENT)) { // if the mode is non anonymous - if (array_key_exists($vid, $users) && is_array($users[$vid])) { // and if the user data can be found - $line[1] = $users[$vid]['nom']; // adds the user data (in the first fields of the line) - $line[2] = $users[$vid]['prenom']; - $line[3] = $users[$vid]['promo']; + if (array_key_exists($vid, $users)) { // and if the user data can be found + $line[1] = $users[$vid]->lastName(); // adds the user data (in the first fields of the line) + $line[2] = $users[$vid]->firstName();; + $line[3] = $users[$vid]->promo(); } } $vid_++; } - $fid = $first + $cur['qid']; // computes the field id - if ($line[$fid] != '') { // if this field already contains something - $line[$fid] .= $asep; // then adds a separator before adding the new answer + $ans = $this->questions[$cur['qid']]->formatAnswer($cur['answer']); // formats the current answer + if (!is_null($ans)) { + if (is_array($ans)) { + $fid = $qids[$cur['qid']] + $ans['id']; // computes the field id + $a = $ans['answer']; + } else { + $fid = $qids[$cur['qid']]; + $a = $ans; + } + if ($line[$fid] != '') { // if this field already contains something + $line[$fid] .= $asep; // then adds a separator before adding the new answer + } + $line[$fid] .= $a; // adds the current answer to the correct field } - $line[$fid] .= $cur['answer']; // adds the current answer to the correct field - $cur = $res->next(); // gets next answer } fputcsv($csv, $line, $sep, $enc); // stores the last line into $csv_output return $csv_output; @@ -254,8 +254,10 @@ class Survey return new SurveyRadio($args); case 'checkbox': return new SurveyCheckbox($args); - case 'personal': - return new SurveyPersonal($args); + case 'radiotable': + return new SurveyRadioTable($args); + case 'checkboxtable': + return new SurveyCheckboxTable($args); default: return null; } @@ -303,22 +305,17 @@ class Survey // {{{ function checkSyntax() : checks syntax of the questions (currently the root only) before storing the survey in database private static $errorMessages = array( - "dateformat" => "la date de fin de sondage est mal formattée : elle doit respecter la syntaxe dd/mm/aaaa", - "datepassed" => "la date de fin de sondage est déjà dépassée : vous devez préciser une date future", - "promoformat" => "les restrictions à certaines promotions sont mal formattées" + "datepassed" => "la date de fin de sondage est déjà dépassée : vous devez préciser une date future", + "promoformat" => "les restrictions à certaines promotions sont mal formattées" ); public function checkSyntax() { $rArr = array(); - if (!preg_match('#^\d{4}-\d{2}-\d{2}$#', $this->end)) { - $rArr[] = array('question' => 'root', 'error' => self::$errorMessages["dateformat"]); - } else { - // checks that the end date given is not already passed - // (unless the survey has already been validated : an admin can have a validated survey expired) - if (!$this->valid && $this->isEnded()) { - $rArr[] = array('question' => 'root', 'error' => self::$errorMessages["datepassed"]); - } + // checks that the end date given is not already passed + // (unless the survey has already been validated : an admin can have a validated survey expired) + if (!$this->valid && $this->isEnded()) { + $rArr[] = array('question' => 'root', 'error' => self::$errorMessages["datepassed"]); } if ($this->promos != '' && !preg_match('#^(\d{4}-?|(\d{4})?-\d{4})(,(\d{4}-?|(\d{4})?-\d{4}))*$#', $this->promos)) { $rArr[] = array('question' => 'root', 'error' => self::$errorMessages["promoformat"]); @@ -332,24 +329,21 @@ class Survey public static function retrieveList($type, $tpl = true) { switch ($type) { - case 'w': - case 'waiting' : - $where = 'valid=0'; - break; case 'c': case 'current': - $where = 'valid=1 AND end > NOW()'; + $where = 'end > NOW()'; break; case 'o': case 'old': - $where = 'valid=1 AND end <= NOW()'; + $where = 'end <= NOW()'; break; default: return null; } $sql = 'SELECT id, title, end, mode - FROM survey_surveys - WHERE '.$where.';'; + FROM surveys + WHERE '.$where.' + ORDER BY end DESC;'; if ($tpl) { return XDB::iterator($sql); } else { @@ -361,15 +355,15 @@ class Survey // {{{ static function retrieveSurvey() : gets a survey in database (and unserialize the survey object structure) public static function retrieveSurvey($sid) { - $sql = 'SELECT questions, title, description, end, mode, promos, valid - FROM survey_surveys + $sql = 'SELECT questions, title, description, end, mode, promos + FROM surveys WHERE id={?}'; $res = XDB::query($sql, $sid); $data = $res->fetchOneAssoc(); if (is_null($data) || !is_array($data)) { return null; } - $survey = new Survey($data, $sid, (boolean) $data['valid'], unserialize($data['questions'])); + $survey = new Survey($data, $sid, true, unserialize($data['questions'])); return $survey; } // }}} @@ -377,63 +371,70 @@ class Survey // {{{ static function retrieveSurveyInfo() : gets information about a survey (title, description, end date, restrictions) but does not unserialize the survey object structure public static function retrieveSurveyInfo($sid) { - $sql = 'SELECT title, description, end, mode, promos, valid - FROM survey_surveys + $sql = 'SELECT title, description, end, mode, promos + FROM surveys WHERE id={?}'; $res = XDB::query($sql, $sid); return $res->fetchOneAssoc(); } // }}} + // {{{ static function retrieveSurveyReq() : gets a survey request to validate + public static function retrieveSurveyReq($id) + { + require_once 'validations.inc.php'; + $surveyreq = Validate::get_request_by_id($id); + if ($surveyreq == null) { + return null; + } + $data = array('title' => $surveyreq->title, + 'description' => $surveyreq->description, + 'end' => $surveyreq->end, + 'mode' => $surveyreq->mode, + 'promos' => $surveyreq->promos); + $survey = new Survey($data, $id, false, $surveyreq->questions); + return $survey; + } + // }}} + // {{{ function proposeSurvey() : stores a proposition of survey in database (before validation) public function proposeSurvey() { - $sql = 'INSERT INTO survey_surveys - SET questions={?}, - title={?}, - description={?}, - author_id={?}, - end={?}, - mode={?}, - promos={?}, - valid=0;'; - return XDB::execute($sql, serialize($this->questions), $this->title, $this->description, S::v('uid'), $this->end, $this->mode, $this->promos); + require_once 'validations.inc.php'; + $surveyreq = new SurveyReq($this->title, $this->description, $this->end, $this->mode, $this->promos, $this->questions, S::user()); + return $surveyreq->submit(); } // }}} // {{{ function updateSurvey() : updates a survey in database (before validation) public function updateSurvey() { - if ($this->id == -1) { - return false; + if ($this->valid) { + $sql = 'UPDATE surveys + SET questions={?}, + title={?}, + description={?}, + end={?}, + mode={?}, + promos={?} + WHERE id={?};'; + return XDB::execute($sql, serialize($this->questions), $this->title, $this->description, $this->end, $this->mode, $this->promos, $this->id); + } else { + require_once 'validations.inc.php'; + $surveyreq = Validate::get_request_by_id($this->id); + if ($surveyreq == null) { + return false; + } + return $surveyreq->updateReq($this->title, $this->description, $this->end, $this->mode, $this->promos, $this->questions); } - $sql = 'UPDATE survey_surveys - SET questions={?}, - title={?}, - description={?}, - end={?}, - mode={?}, - promos={?} - WHERE id={?};'; - return XDB::execute($sql, serialize($this->questions), $this->title, $this->description, $this->end, $this->mode, $this->promos, $this->id); - } - // }}} - - // {{{ static function validateSurvey() : validates a survey - public static function validateSurvey($sid) - { - $sql = 'UPDATE survey_surveys - SET valid=1 - WHERE id={?};'; - return XDB::execute($sql, $sid); } // }}} // {{{ functions vote() and hasVoted() : handles vote to a survey public function vote($uid, $args) { - XDB::execute('INSERT INTO survey_votes - SET survey_id={?}, user_id={?};', $this->id, $uid); // notes the user as having voted + XDB::execute('INSERT INTO survey_votes + SET survey_id = {?}, uid = {?};', $this->id, $uid); // notes the user as having voted $vid = XDB::insertId(); for ($i = 0; $i < count($this->questions); $i++) { $ans = $this->questions[$i]->checkAnswer($args[$i]); @@ -450,9 +451,9 @@ class Survey public function hasVoted($uid) { - $res = XDB::query('SELECT id - FROM survey_votes - WHERE survey_id={?} AND user_id={?};', $this->id, $uid); // checks whether the user has already voted + $res = XDB::query('SELECT id + FROM survey_votes + WHERE survey_id = {?} AND uid = {?};', $this->id, $uid); // checks whether the user has already voted return ($res->numRows() != 0); } // }}} @@ -461,7 +462,7 @@ class Survey public static function deleteSurvey($sid) { $sql = 'DELETE s.*, v.*, a.* - FROM survey_surveys AS s + FROM surveys AS s LEFT JOIN survey_votes AS v ON v.survey_id=s.id LEFT JOIN survey_answers AS a @@ -522,7 +523,7 @@ abstract class SurveyQuestion } // }}} - // {{{ function checkAnswer : returns a correctly formatted answer (or nothing empty string if error) + // {{{ function checkAnswer : returns a correct answer (or a null value if error) public function checkAnswer($ans) { return null; @@ -530,12 +531,14 @@ abstract class SurveyQuestion // }}} // {{{ functions regarding the results of a survey - public function buildResultRequest() + abstract public function getResultArray($sid, $qid); + + public function formatAnswer($ans) { - return ''; + return $ans; } - public function getCSVColumn() + public function getCSVColumns() { return $this->question; } @@ -543,7 +546,7 @@ abstract class SurveyQuestion } // }}} -// {{{ abstract class SurveySimple and its derived classes : "opended" questions +// {{{ abstract class SurveySimple and its derived classes : "open" questions // {{{ abstract class SurveySimple extends SurveyQuestion abstract class SurveySimple extends SurveyQuestion { @@ -552,7 +555,7 @@ abstract class SurveySimple extends SurveyQuestion return array($ans); } - public function buildResultRequest() + public function getResultArray($sid, $qid) { $sql = 'SELECT answer FROM survey_answers @@ -560,7 +563,8 @@ abstract class SurveySimple extends SurveyQuestion AND question_id={?} ORDER BY RAND() LIMIT 5;'; - return $sql; + $res = XDB::query($sql, $sid, $qid); + return $res->fetchAllAssoc(); } } // }}} @@ -610,39 +614,39 @@ abstract class SurveyList extends SurveyQuestion public function update($args) { parent::update($args); - $this->choices = explode('|', $args['options']); + $this->choices = array(); + foreach ($args['choices'] as $val) { + if (trim($val) || trim($val) == '0') { + $this->choices[] = $val; + } + } } public function toArray() { $rArr = parent::toArray(); $rArr['choices'] = $this->choices; - $rArr['options'] = implode('|', $this->choices); return $rArr; } - public function buildResultRequest() + public function getResultArray($sid, $qid) { $sql = 'SELECT answer, COUNT(id) AS count FROM survey_answers WHERE vote_id IN (SELECT id FROM survey_votes WHERE survey_id={?}) AND question_id={?} GROUP BY answer ASC'; - return $sql; + $res = XDB::query($sql, $sid, $qid); + return $res->fetchAllAssoc(); } - public function getCSVColumn() + public function formatAnswer($ans) { - $r = parent::getCSVColumn(); - if (empty($this->choices)) { - return $r; - } - $r .= ' [0 => '.$this->choices[0]; - for ($k = 1; $k < count($this->choices); $k++) { - $r .= ', '.$k.' => '.$this->choices[$k]; + if (array_key_exists($ans, $this->choices)) { + return $this->choices[$ans]; + } else { + return null; } - $r .= ']'; - return $r; } } // }}} @@ -652,7 +656,8 @@ class SurveyRadio extends SurveyList { public function checkAnswer($ans) { - return (array_key_exists($ans, $this->choices))? array($ans) : null; + $a = intval($ans); + return (array_key_exists($a, $this->choices))? array($a) : null; } protected function getQuestionType() @@ -685,5 +690,128 @@ class SurveyCheckbox extends SurveyList // }}} // }}} -// vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8: +// {{{ abstract class SurveyTable and its derived classes : table question, each column represents a choice, each line represents a question +// {{{ abstract class SurveyTable extends SurveyList +abstract class SurveyTable extends SurveyList +{ + protected $subquestions; + + public function update($args) + { + parent::update($args); + $this->subquestions = array(); + foreach ($args['subquestions'] as $val) { + if (trim($val) || trim($val) == '0') { + $this->subquestions[] = $val; + } + } + } + + public function toArray() + { + $rArr = parent::toArray(); + $rArr['subquestions'] = $this->subquestions; + return $rArr; + } + + public function getResultArray($sid, $qid) + { + $sql = 'SELECT answer, COUNT(id) AS count + FROM survey_answers + WHERE vote_id IN (SELECT id FROM survey_votes WHERE survey_id={?}) + AND question_id={?} + GROUP BY answer ASC'; + $res = XDB::iterator($sql, $sid, $qid); + $result = array(); + for ($i = 0; $i < count($this->subquestions); $i++) { + $result[$i] = array_fill(0, count($this->choices), 0); + } + while ($r = $res->next()) { + list($i, $j) = explode(':', $r['answer']); + $result[$i][$j] = $r['count']; + } + return $result; + } + + public function formatAnswer($ans) + { + list($q, $c) = explode(':', $ans); + if (array_key_exists($q, $this->subquestions) && array_key_exists($c, $this->choices)) { + return array('id' => $q, 'answer' => $this->choices[$c]); + } else { + return null; + } + } + + public function getCSVColumns() + { + $q = parent::getCSVColumns(); + if (empty($this->subquestions)) { + return $q; + } + $a = array(); + for ($k = 0; $k < count($this->subquestions); $k++) { + $a[$k] = $q.' : '.$this->subquestions[$k]; + } + return $a; + } +} +// }}} + +// {{{ class SurveyRadioTable extends SurveyTable : SurveyTable with radio type choices +class SurveyRadioTable extends SurveyTable +{ + public function checkAnswer($ans) + { + $rep = array(); + foreach ($ans as $k => $a) { + if (!array_key_exists($k, $this->subquestions)) { + continue; + } + $a = intval($a); + if (array_key_exists($a, $this->choices)) { + $rep[] = $k . ':' . $a; + } + } + return (count($rep) == 0)? null : $rep; + } + + protected function getQuestionType() + { + return "radiotable"; + } + +} +// }}} + +// {{{ class SurveyCheckboxTable extends SurveyTable : SurveyTable with checkbox type choices +class SurveyCheckboxTable extends SurveyTable +{ + public function checkAnswer($ans) + { + $rep = array(); + foreach ($ans as $k => $aa) { + if (!array_key_exists($k, $this->subquestions)) { + continue; + } + foreach ($aa as $a) { + $a = intval($a); + if (array_key_exists($a, $this->choices)) { + $rep[] = $k . ':' . $a; + } + } + } + return (count($rep) == 0)? null : $rep; + } + + protected function getQuestionType() + { + return "checkboxtable"; + } + +} +// }}} +// }}} + +// vim:set et sw=4 sts=4 ts=4 foldmethod=marker enc=utf-8: ?>