X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=modules%2Fprofile%2Fpage.inc.php;h=2bc4c523a049b86ec691fba62724a5df0a2bd0b1;hb=3a2985f931bdbbae9d1c689263a1dc15d9b3b7dc;hp=3117b29ec2a5f2c661cdc9f59c26226bdf1d4909;hpb=eb54852e7f50cccff37ee5a6d94f5c7ebeb8fc18;p=platal.git diff --git a/modules/profile/page.inc.php b/modules/profile/page.inc.php index 3117b29..2bc4c52 100644 --- a/modules/profile/page.inc.php +++ b/modules/profile/page.inc.php @@ -1,6 +1,6 @@ values[$field]) ? $page->values[$field] : S::v($field); @@ -70,7 +70,7 @@ class ProfileSettingWeb extends ProfileNoSave class ProfileSettingEmail extends ProfileNoSave { - public function value(ProfilePage &$page, $field, $value, &$success) + public function value(ProfilePage $page, $field, $value, &$success) { if (is_null($value)) { return isset($page->values[$field]) ? $page->values[$field] : S::v($field); @@ -86,7 +86,7 @@ class ProfileSettingEmail extends ProfileNoSave class ProfileSettingNumber extends ProfileNoSave { - public function value(ProfilePage &$page, $field, $value, &$success) + public function value(ProfilePage $page, $field, $value, &$success) { if (is_null($value)) { return isset($page->values[$field]) ? $page->values[$field] : S::v($field); @@ -102,7 +102,7 @@ class ProfileSettingNumber extends ProfileNoSave class ProfileSettingPhones implements ProfileSetting { - public function value(ProfilePage &$page, $field, $value, &$success) + public function value(ProfilePage $page, $field, $value, &$success) { $success = true; $phones = array(); @@ -118,25 +118,30 @@ class ProfileSettingPhones implements ProfileSetting $phones[] = $phone->toFormArray(); } return $phones; + } else { + $phones = Phone::formatFormArray($value, $success); + if (!$success) { + Platal::page()->trigError('Numéro de téléphone invalide'); + } + return $phones; } - - return Phone::formatFormArray($value, $success); } - public function save(ProfilePage &$page, $field, $value) + public function save(ProfilePage $page, $field, $value) { - Phone::deletePhones($page->pid(), Phone::LINK_PROFILE); + Phone::deletePhones($page->pid(), Phone::LINK_PROFILE, null, S::user()->isMe($page->owner) || S::admin()); Phone::savePhones($value, $page->pid(), Phone::LINK_PROFILE); } - public function getText($value) { + public function getText($value) + { return Phone::formArrayToString($value); } } class ProfileSettingPub extends ProfileNoSave { - public function value(ProfilePage &$page, $field, $value, &$success) + public function value(ProfilePage $page, $field, $value, &$success) { $success = true; if (is_null($value)) { @@ -151,13 +156,14 @@ class ProfileSettingPub extends ProfileNoSave } public function getText($value) { - return $value; + static $pubs = array('public' => 'publique', 'ax' => 'annuaire AX', 'private' => 'privé'); + return $pubs[$value]; } } class ProfileSettingBool extends ProfileNoSave { - public function value(ProfilePage &$page, $field, $value, &$success) + public function value(ProfilePage $page, $field, $value, &$success) { $success = true; if (is_null($value)) { @@ -169,16 +175,27 @@ class ProfileSettingBool extends ProfileNoSave class ProfileSettingDate extends ProfileNoSave { - public function value(ProfilePage &$page, $field, $value, &$success) + private $allowEmpty; + + public function __construct($allowEmpty = false) + { + $this->allowEmpty = $allowEmpty; + } + + public function value(ProfilePage $page, $field, $value, &$success) { $success = true; if (is_null($value)) { $value = preg_replace('/(\d{4})-(\d{2})-(\d{2})/', '\3/\2/\1', @$page->values[$field]); } else { + $value = trim($value); + if (empty($value) && $this->allowEmpty) { + return null; + } $success = preg_match('@(\d{2})/(\d{2})/(\d{4})@', $value, $matches); if (!$success) { Platal::page()->trigError("Les dates doivent être au format jj/mm/aaaa"); - } else { + } else { $day = (int)$matches[1]; $month = (int)$matches[2]; $year = (int)$matches[3]; @@ -190,6 +207,11 @@ class ProfileSettingDate extends ProfileNoSave } return $value; } + + public static function toSQLDate($value) + { + return preg_replace('@(\d{2})/(\d{2})/(\d{4})@', '\3-\2-\1', $value); + } } abstract class ProfilePage implements PlWizardPage @@ -206,7 +228,7 @@ abstract class ProfilePage implements PlWizardPage public $profile = null; public $owner = null; - public function __construct(PlWizard &$wiz) + public function __construct(PlWizard $wiz) { $this->wizard =& $wiz; $this->profile = $this->wizard->getUserData('profile'); @@ -241,7 +263,7 @@ abstract class ProfilePage implements PlWizardPage { } - protected function saveData() + public function saveData() { require_once 'notifs.inc.php'; $changedFields = array(); @@ -249,13 +271,13 @@ abstract class ProfilePage implements PlWizardPage if ($this->changed[$field]) { if (!is_null($setting)) { $changedFields[$field] = array( - str_replace("\n", " - ", $setting->getText($this->orig[$field])), - str_replace("\n", " - ", $setting->getText($this->values[$field])), + preg_replace('/(\r\n|\n|\r)/', ' - ', $setting->getText($this->orig[$field])), + preg_replace('/(\r\n|\n|\r)/', ' - ', $setting->getText($this->values[$field])), ); } else { $changedFields[$field] = array( - str_replace("\n", " - ", $this->orig[$field]), - str_replace("\n", " - ", $this->values[$field]), + preg_replace('/(\r\n|\n|\r)/', ' - ', $this->orig[$field]), + preg_replace('/(\r\n|\n|\r)/', ' - ', $this->values[$field]), ); } if (!is_null($setting)) { @@ -275,19 +297,26 @@ abstract class ProfilePage implements PlWizardPage global $platal; S::logger()->log('profil', $platal->pl_self(2)); - /** If the update was made by a third party and the profile corresponds - * to a registered user, stores both former and new text. - * This will be daily sent to the user. + /** Stores all profile modifications for active users in order to: + * -daily notify the user in case of third party edition, + * -display the modification to the secretaries for verification in + * case of an edition made by the user. */ $owner = $this->profile->owner(); $user = S::user(); - if ($owner->isActive() && $owner->id() != $user->id()) { + if ($owner->isActive()) { foreach ($changedFields as $field => $values) { - XDB::execute('REPLACE INTO profile_modifications (pid, uid, field, oldText, newText) - VALUES ({?}, {?}, {?}, {?}, {?})', - $this->pid(), $user->id(), $field, $values[0], $values[1]); + if (in_array($field, Profile::$descriptions)) { + XDB::execute('INSERT INTO profile_modifications (pid, uid, field, oldText, newText, type, timestamp) + VALUES ({?}, {?}, {?}, {?}, {?}, {?}, NOW()) + ON DUPLICATE KEY UPDATE uid = VALUES(uid), oldText = IF(VALUES(type) != type, VALUES(oldText), oldText), + newText = VALUES(newText), type = VALUES(type), timestamp = NOW()', + $this->pid(), $user->id(), Profile::$descriptions[$field], $values[0], $values[1], + ($owner->id() == $user->id()) ? 'self' : 'third_party'); + } } } + return true; } protected function checkChanges() @@ -327,11 +356,11 @@ abstract class ProfilePage implements PlWizardPage return $this->profile->hrpid(); } - protected function _prepare(PlPage &$page, $id) + protected function _prepare(PlPage $page, $id) { } - public function prepare(PlPage &$page, $id) + public function prepare(PlPage $page, $id) { if (count($this->values) == 0) { $this->fetchData(); @@ -363,19 +392,41 @@ abstract class ProfilePage implements PlWizardPage } if ($global_success) { if ($this->checkChanges()) { - $this->saveData(); + /* Save changes atomically to avoid inconsistent state + * in case of error. + */ + if (!XDB::runTransaction(array($this, 'saveData'))) { + $global_success = false; + return PlWizard::CURRENT_PAGE; + } $this->markChange(); } + // XXX: removes this code once all merge related issues have been fixed. + static $issues = array(0 => array('name', 'promo', 'phone', 'education'), 1 => array('address'), 2 => array('job')); + if (isset($issues[Post::i('valid_page')])) { + foreach ($issues[Post::i('valid_page')] as $issue) { + XDB::execute("UPDATE profile_merge_issues + SET issues = REPLACE(issues, {?}, '') + WHERE pid = {?}", + $issue, $this->pid()); + } + } return Post::has('next_page') ? PlWizard::NEXT_PAGE : PlWizard::CURRENT_PAGE; } - Platal::page()->trigError("Certains champs n'ont pas pu être validés, merci de corriger les informations " - . "de ton profil et de revalider ta demande."); + $text = "Certains champs n'ont pas pu être validés, merci de corriger les informations " + . (S::user()->isMe($this->owner) ? "de ton profil et de revalider ta demande." + : "du profil et de revalider ta demande."); + Platal::page()->trigError($text); return PlWizard::CURRENT_PAGE; } public function success() { - return 'Ton profil a bien été mis à jour.'; + if (S::user()->isMe($this->owner)) { + return 'Ton profil a bien été mis à jour.'; + } else { + return 'Le profil a bien été mis à jour.'; + } } }