X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=modules%2Femail.php;h=b78cfe7ff52b232e9ee8f68168c447fd98dd9c10;hb=9c15cc9f0baece0f0f16779b75a5c48e1b74079a;hp=764851576e5159f71ea3a80b2593242611e6098b;hpb=d93bc6bebeca9ef0cbcbeb6db396e73278d52b7c;p=platal.git diff --git a/modules/email.php b/modules/email.php index 7648515..b78cfe7 100644 --- a/modules/email.php +++ b/modules/email.php @@ -1,6 +1,6 @@ $this->make_hook('emails', AUTH_COOKIE, 'mail'), - 'emails/alias' => $this->make_hook('alias', AUTH_MDP, 'mail'), - 'emails/antispam' => $this->make_hook('antispam', AUTH_MDP, 'mail'), - 'emails/broken' => $this->make_hook('broken', AUTH_COOKIE), - 'emails/redirect' => $this->make_hook('redirect', AUTH_MDP, 'mail'), - 'emails/send' => $this->make_hook('send', AUTH_MDP, 'mail'), - 'emails/antispam/submit' => $this->make_hook('submit', AUTH_COOKIE), + 'emails/alias' => $this->make_hook('alias', AUTH_PASSWD, 'mail'), + 'emails/antispam' => $this->make_hook('antispam', AUTH_PASSWD, 'mail'), + 'emails/broken' => $this->make_hook('broken', AUTH_COOKIE, 'user'), + 'emails/redirect' => $this->make_hook('redirect', AUTH_PASSWD, 'mail'), + 'emails/send' => $this->make_hook('send', AUTH_PASSWD, 'mail'), + 'emails/antispam/submit' => $this->make_hook('submit', AUTH_COOKIE, 'user'), 'emails/test' => $this->make_hook('test', AUTH_COOKIE, 'mail', NO_AUTH), 'emails/rewrite/in' => $this->make_hook('rewrite_in', AUTH_PUBLIC), @@ -38,10 +38,10 @@ class EmailModule extends PLModule 'emails/imap/in' => $this->make_hook('imap_in', AUTH_PUBLIC), - 'admin/emails/duplicated' => $this->make_hook('duplicated', AUTH_MDP, 'admin'), - 'admin/emails/watch' => $this->make_hook('duplicated', AUTH_MDP, 'admin'), - 'admin/emails/lost' => $this->make_hook('lost', AUTH_MDP, 'admin'), - 'admin/emails/broken' => $this->make_hook('broken_addr', AUTH_MDP, 'admin'), + 'admin/emails/duplicated' => $this->make_hook('duplicated', AUTH_PASSWD, 'admin'), + 'admin/emails/watch' => $this->make_hook('duplicated', AUTH_PASSWD, 'admin'), + 'admin/emails/lost' => $this->make_hook('lost', AUTH_PASSWD, 'admin'), + 'admin/emails/broken' => $this->make_hook('broken_addr', AUTH_PASSWD, 'admin,edit_directory'), ); } @@ -67,9 +67,12 @@ class EmailModule extends PLModule WHERE uid = {?}", $user->id()); // Then gives the bestalias flag to the given email. list($email, $domain) = explode('@', $email); - XDB::execute("UPDATE email_source_account + XDB::execute("UPDATE email_source_account AS s + INNER JOIN email_virtual_domains AS m ON (m.id = s.domain) + INNER JOIN email_virtual_domains AS d ON (d.aliasing = m.id) SET flags = CONCAT_WS(',', IF(flags = '', NULL, flags), 'bestalias') - WHERE uid = {?} AND email = {?}", $user->id(), $email); + WHERE s.uid = {?} AND s.email = {?} AND d.name = {?}", + $user->id(), $email, $domain); XDB::execute('UPDATE accounts AS a INNER JOIN email_virtual_domains AS d ON (d.name = {?}) INNER JOIN email_virtual_domains AS m ON (d.aliasing = m.id) @@ -95,9 +98,23 @@ class EmailModule extends PLModule INNER JOIN email_virtual_domains AS m ON (s.domain = m.id) INNER JOIN email_virtual_domains AS d ON (d.aliasing = m.id) WHERE s.uid = {?} - ORDER BY !alias, s.email", + ORDER BY !alias, s.email, d.name", $user->id()); - $page->assign('aliases', $aliases); + $aliases_forlife = array(); + $aliases_hundred = array(); + $aliases_other = array(); + while ($a = $aliases->next()) { + if ($a['forlife']) { + $aliases_forlife[] = $a; + } elseif ($a['hundred_year']) { + $aliases_hundred[] = $a; + } else { + $aliases_other[] = $a; + } + } + $page->assign('aliases_forlife', $aliases_forlife); + $page->assign('aliases_hundred', $aliases_hundred); + $page->assign('aliases_other', $aliases_other); $alias = XDB::fetchOneCell('SELECT COUNT(email) FROM email_source_account @@ -149,7 +166,7 @@ class EmailModule extends PLModule INNER JOIN email_virtual_domains AS d ON (s.domain = d.id) WHERE s.uid = {?} AND s.type = \'alias_aux\'', $user->id()); - $visibility = $user->hasProfile() && ($user->profile(true)->alias_pub == 'public'); + $visibility = $user->hasProfile() && $user->profile()->isVisible($user->profile()->alias_pub); $page->assign('current', $alias); $page->assign('user', $user); $page->assign('mail_public', $visibility); @@ -160,20 +177,21 @@ class EmailModule extends PLModule // Retrieves user request. $new_alias = Env::v('alias'); $reason = Env::v('reason'); - $public = (Env::v('public', 'off') == 'on') ? 'public' : 'private'; + $public = (Env::v('public', 'off') == 'on') ? 'private' : 'hidden'; $page->assign('r_alias', $new_alias); $page->assign('r_reason', $reason); - if ($public == 'public') { + if ($public == 'private') { $page->assign('r_public', true); } // Checks special charaters in alias. - if (!preg_match("/^[a-zA-Z0-9\-.]{3,20}$/", $new_alias)) { + if (!preg_match("/^[a-zA-Z0-9\-.]{2,19}[a-zA-Z0-9\-]$/", $new_alias)) { $page->trigError("L'adresse demandée n'est pas valide." . " Vérifie qu'elle comporte entre 3 et 20 caractères" . " et qu'elle ne contient que des lettres non accentuées," - . " des chiffres ou les caractères - et ."); + . " des chiffres ou les caractères '-' et '.'. De plus, elle ne" + . " peut pas se terminer par un point."); return; } else { // Checks if the alias has already been given. @@ -460,7 +478,7 @@ class EmailModule extends PLModule foreach ($files as $name=>&$upload) { $mymail->addUploadAttachment($upload, $name); } - if (Env::v('nowiki')) { + if (Env::v('wiki') == 'text') { $mymail->setTxtBody(wordwrap($txt, 78, "\n")); } else { $mymail->setWikiBody($txt); @@ -495,6 +513,14 @@ class EmailModule extends PLModule $page->assign('contacts', $contacts); $page->assign('maxsize', ini_get('upload_max_filesize') . 'o'); $page->assign('user', S::user()); + $preferences = XDB::fetchOneAssoc('SELECT from_email, from_format + FROM accounts + WHERE uid = {?}', + S::user()->id()); + if ($preferences['from_email'] == '') { + $preferences['from_email'] = '"' . S::user()->fullName() . '" <' . S::user()->bestEmail() . '>'; + } + $page->assign('preferences', $preferences); } function handler_test($page, $hruid = null) @@ -649,6 +675,9 @@ class EmailModule extends PLModule if ($uid) { $dest = User::getWithUID($uid); + $active = XDB::fetchOneCell('SELECT flags + FROM email_redirect_account + WHERE redirect = {?} AND uid = {?}', $email, $uid) == 'active'; $mail = new PlMailer('emails/broken-web.mail.tpl'); $mail->assign('email', $email); @@ -776,7 +805,8 @@ class EmailModule extends PLModule AND er.type != \'imap\' AND er.type != \'homonym\') LEFT JOIN account_profiles AS ap ON (ap.uid = a.uid AND FIND_IN_SET(\'owner\', ap.perms)) LEFT JOIN profile_display AS pd ON (ap.pid = pd.pid) - WHERE a.state = \'active\' AND er.redirect IS NULL AND FIND_IN_SET(\'mail\', at.perms) + LEFT JOIN profiles AS p ON (ap.pid = p.pid) + WHERE a.state = \'active\' AND er.redirect IS NULL AND FIND_IN_SET(\'mail\', at.perms) AND p.deathdate IS NULL GROUP BY a.uid ORDER BY pd.promo, a.hruid')); } @@ -832,30 +862,41 @@ class EmailModule extends PLModule $broken_user_list = array(); $broken_user_email_count = array(); + $broken_user_profiles = array(); $broken_list = explode("\n", $list); sort($broken_list); foreach ($broken_list as $email) { + $email = trim($email); + $userobj = null; if ($user = mark_broken_email($email, true)) { - if ($user['nb_mails'] > 0 && $user['notify']) { - $mail = new PlMailer('emails/broken.mail.tpl'); - $dest = User::getSilentWithUID($user['uid']); - $mail->setTo($dest); - $mail->assign('user', $user); - $mail->assign('email', $email); - $mail->send(); - } else { - $profile = Profile::get($user['alias']); - WatchProfileUpdate::register($profile, 'broken'); - } + $userobj = User::getSilentWithUID($user['uid']); + } + if (is_null($userobj)) { + continue; + } + $profile = $userobj->profile(); + if (is_null($profile)) { + continue; + } + if ($user['nb_mails'] > 0 && $user['notify']) { + $mail = new PlMailer('emails/broken.mail.tpl'); + $mail->setTo($userobj); + $mail->assign('user', $user); + $mail->assign('email', $email); + $mail->send(); + } else { + WatchProfileUpdate::register($profile, 'broken'); + } - if (!isset($broken_user_list[$user['uid']])) { - $broken_user_list[$user['uid']] = array($email); - } else { - $broken_user_list[$user['uid']][] = $email; - } - $broken_user_email_count[$user['uid']] = $user['nb_mails']; + $pid = $profile->id(); + if (!isset($broken_user_list[$pid])) { + $broken_user_list[$pid] = array($email); + } else { + $broken_user_list[$pid][] = $email; } + $broken_user_email_count[$pid] = $user['nb_mails']; + $broken_user_profiles[$pid] = $profile; } XDB::execute('UPDATE email_redirect_account @@ -867,17 +908,25 @@ class EmailModule extends PLModule WHERE flags = \'active\' AND broken_level = 1 AND DATE_ADD(last, INTERVAL 1 YEAR) < CURDATE()'); + // Sort $broken_user_list with (promo, sortname, pid) + $sortable_array = array(); + foreach ($broken_user_list as $pid => $mails) { + $profile = $broken_user_profiles[$pid]; + $sortable_array[$pid] = array($profile->promo(), $profile->sortName(), $pid); + } + asort($sortable_array); + // Output the list of users with recently broken addresses, // along with the count of valid redirections. - pl_cached_content_headers('text/x-csv', 1); + pl_cached_content_headers('text/x-csv', null, 1, 'broken.csv'); $csv = fopen('php://output', 'w'); fputcsv($csv, array('nom', 'promo', 'bounces', 'nbmails', 'url', 'corps', 'job', 'networking'), ';'); $corpsList = DirEnum::getOptions(DirEnum::CURRENTCORPS); - foreach ($broken_user_list as $uid => $mails) { - $profile = Profile::get($uid); - $corps = $profile->getCorps(); - $current_corps = ($corps && $corps->current) ? $corpsList[$corps->current] : ''; + foreach (array_keys($sortable_array) as $pid) { + $mails = $broken_user_list[$pid]; + $profile = $broken_user_profiles[$pid]; + $current_corps = $profile->getCorpsName(); $jobs = $profile->getJobs(); $companies = array(); foreach ($jobs as $job) { @@ -889,7 +938,7 @@ class EmailModule extends PLModule $networking_list[] = $networking['address']; } fputcsv($csv, array($profile->fullName(), $profile->promo(), - join(',', $mails), $broken_user_email_count[$uid], + join(',', $mails), $broken_user_email_count[$pid], 'https://www.polytechnique.org/marketing/broken/' . $profile->hrid(), $current_corps, implode(',', $companies), implode(',', $networking_list)), ';'); } @@ -900,5 +949,5 @@ class EmailModule extends PLModule } } -// vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8: +// vim:set et sw=4 sts=4 sws=4 foldmethod=marker fenc=utf-8: ?>