X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=modules%2Fauth.php;h=2c39af942aff8e6a8be525744439e79164d20953;hb=5e1513f67936a6c6866113d260746711af4ea2ee;hp=1601c582fc0a1bc911704d7f24c517ee04dd438d;hpb=86aa4b4cccd01fa073f3d46bc7890bc0debb270c;p=platal.git diff --git a/modules/auth.php b/modules/auth.php index 1601c58..2c39af9 100644 --- a/modules/auth.php +++ b/modules/auth.php @@ -1,6 +1,6 @@ $this->make_hook('chall', AUTH_PUBLIC), - 'groupex/export-econfiance.php' - => $this->make_hook('econf', AUTH_PUBLIC, 'user', NO_HTTPS), - - 'webservices/manageurs.php' - => $this->make_hook('manageurs', AUTH_PUBLIC, 'user', NO_HTTPS), - - 'auth-redirect.php' => $this->make_hook('redirect', AUTH_COOKIE), - 'auth-groupex.php' => $this->make_hook('groupex_old', AUTH_COOKIE), - 'auth-groupex' => $this->make_hook('groupex', AUTH_COOKIE), - 'admin/auth-groupes-x' => $this->make_hook('admin_authgroupesx', AUTH_MDP, 'admin'), + 'groupex/donne-chall.php' => $this->make_hook('chall', AUTH_PUBLIC), + 'groupex/export-econfiance.php' => $this->make_hook('econf', AUTH_PUBLIC, 'user', NO_HTTPS), + + 'webservices/manageurs.php' => $this->make_hook('manageurs', AUTH_PUBLIC, 'user', NO_HTTPS), + + 'auth-redirect.php' => $this->make_hook('redirect', AUTH_COOKIE), + 'auth-groupex.php' => $this->make_hook('groupex_old', AUTH_COOKIE), + 'auth-groupex' => $this->make_hook('groupex', AUTH_COOKIE), + 'admin/auth-groupes-x' => $this->make_hook('admin_authgroupesx', AUTH_MDP, 'admin'), ); } @@ -52,46 +49,28 @@ class AuthModule extends PLModule $cle = $globals->core->econfiance; - if (S::v('chall') && $_GET['PASS'] == md5(S::v('chall').$cle)) { - - $res = XDB::query("SELECT password FROM auth_user_md5 WHERE user_id=10154"); - $pass = $res->fetchOneCell(); + $res = "\n\n\n\n"; - $list = new MMList(10154, $pass, "x-econfiance.polytechnique.org"); + if (S::v('chall') && $_GET['PASS'] == md5(S::v('chall').$cle)) { + $list = new MMList(User::getWithUID(10154), "x-econfiance.polytechnique.org"); $members = $list->get_members('membres'); if (is_array($members)) { $membres = Array(); foreach($members[1] as $member) { - if (preg_match('/^([^.]*.[^.]*.(\d\d\d\d))@polytechnique.org$/', - $member[1], $matches)) - { - $membres[] = "a.alias='{$matches[1]}'"; + $user = User::getSilent($member[1]); + if ($user && $user->hasProfile()) { + $profile = $user->profile(); + $res .= "\n"; + $res .= "\t" . $profile->lastName() . "\n"; + $res .= "\t" . $profile->firstName() . "\n"; + $res .= "\t" . $user->forlifeEmail() . "\n"; + $res .= "\n\n"; } } } - - $where = join(' OR ',$membres); - - $all = XDB::iterRow( - "SELECT u.prenom,u.nom,a.alias - FROM auth_user_md5 AS u - INNER JOIN aliases AS a ON ( u.user_id = a.id AND a.type!='homonyme' ) - WHERE $where - ORDER BY nom"); - - $res = "\n\n\n\n"; - - while (list ($prenom1,$nom1,$email1) = $all->next()) { - $res .= "\n"; - $res .= "\t$nom1\n"; - $res .= "\t$prenom1\n"; - $res .= "\t$email1\n"; - $res .= "\n\n"; - } - $res .= "\n\n"; - header('Content-Type: text/xml; charset="UTF-8"'); + pl_content_headers("text/xml"); echo $res; } exit; @@ -112,7 +91,7 @@ class AuthModule extends PLModule $request = @$GLOBALS['HTTP_RAW_POST_DATA']; $response = xmlrpc_server_call_method($server, $request, null); - header('Content-Type: text/xml'); + pl_content_headers("text/xml"); print $response; xmlrpc_server_destroy($server); } @@ -143,41 +122,46 @@ class AuthModule extends PLModule $gpex_url .= "&PHPSESSID=" . $_GET["session"]; } - /* a-t-on besoin d'ajouter le http:// ? */ + // Normalize the return URL. if (!preg_match("/^(http|https):\/\/.*/",$gpex_url)) { $gpex_url = "http://$gpex_url"; } $gpex_challenge = $_GET["challenge"]; - // mise à jour de l'heure et de la machine de dernier login sauf quand on est en suid + // Update the last login information (unless the user is in SUID). $uid = S::i('uid'); if (!S::suid()) { global $platal; - S::logger($uid)->log('connexion_auth_ext', $platal->path); + S::logger($uid)->log('connexion_auth_ext', $platal->path.' '.urldecode($_GET['url'])); } - /* on parcourt les entrees de groupes_auth */ - $res = XDB::iterRow('SELECT privkey, name, datafields, returnurls FROM groupesx_auth'); - + // Iterate over the auth token to find which one did sign the request. + $res = XDB::iterRow('SELECT privkey, name, datafields, returnurls FROM group_auth'); while (list($privkey,$name,$datafields,$returnurls) = $res->next()) { if (md5($gpex_challenge.$privkey) == $gpex_pass) { $returnurls = trim($returnurls); + // We check that the return url matches a per-key regexp to prevent + // replay attacks (more exactly to force replay attacks to redirect + // the user to the real GroupeX website, which defeats the attack). if (empty($returnurls) || @preg_match($returnurls, $gpex_url)) { $returl = $gpex_url . gpex_make_params($gpex_challenge, $privkey, $datafields, $charset); http_redirect($returl); + } else if (S::admin()) { + $page->kill("La requête d'authentification a échouée (url de retour invalide)."); } } } - /* si on n'a pas trouvé, on renvoit sur x.org */ - http_redirect('https://www.polytechnique.org/'); + // Otherwise (if no valid request was found, or if the return URL is not + // acceptable), the user is redirected back to our homepage. + pl_redirect('/'); } function handler_admin_authgroupesx(&$page, $action = 'list', $id = null) { $page->setTitle('Administration - Auth groupes X'); $page->assign('title', 'Gestion de l\'authentification centralisée'); - $table_editor = new PLTableEditor('admin/auth-groupes-x','groupesx_auth','id'); + $table_editor = new PLTableEditor('admin/auth-groupes-x','group_auth','id'); $table_editor->describe('name','nom',true); $table_editor->describe('privkey','clé privée',false); $table_editor->describe('datafields','champs renvoyés',true);