X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=bin%2Fcron%2Fcheckdb.php;h=cbd7350aba44cae7f881c68846ac5c7216dac5fe;hb=b53b9de75a3240e36c52b42cd8334664040dc776;hp=fa9ae8d6a18d6815bd49261a25a62c5dc520aa51;hpb=b209d2bb3880141c51e4a5637b57635ee00e1d1a;p=platal.git

diff --git a/bin/cron/checkdb.php b/bin/cron/checkdb.php
index fa9ae8d..cbd7350 100755
--- a/bin/cron/checkdb.php
+++ b/bin/cron/checkdb.php
@@ -1,7 +1,7 @@
 #!/usr/bin/php5 -q
 <?php
 /***************************************************************************
- *  Copyright (C) 2003-2010 Polytechnique.org                              *
+ *  Copyright (C) 2003-2013 Polytechnique.org                              *
  *  http://opensource.polytechnique.org/                                   *
  *                                                                         *
  *  This program is free software; you can redistribute it and/or modify   *
@@ -61,7 +61,8 @@ function checkCount($sql, $comment = '')
     }
 }
 
-function info($sql, $comment = '', $onlyCounts = false) {
+function info($sql, $comment = '', $onlyCounts = false)
+{
     global $opt_verbose;
     if ($opt_verbose) {
         if ($onlyCounts) {
@@ -72,6 +73,20 @@ function info($sql, $comment = '', $onlyCounts = false) {
     }
 }
 
+function infoCountEmpty($table, $field, $nonEmpty = false)
+{
+    $sql = "SELECT COUNT(*) FROM $table";
+    if ($nonEmpty) {
+        $sql .= " WHERE $field IS NOT NULL OR $field != ''";
+        $negation = ' non';
+    } else {
+        $sql .= " WHERE $field IS NULL OR $field = ''";
+        $negation = '';
+    }
+    $comment = "Nombre de champs '$field'$negation vides dans la table '$table'.";
+    info($sql, $comment, true);
+}
+
 /* Parses options. */
 $opts = Console_GetOpt::getopt($argv, 'v');
 $opt_verbose = false;
@@ -90,50 +105,147 @@ if (PEAR::isError($opts)) {
 }
 
 /* Checks rewriting on deleted aliases. */
-check("SELECT  a.alias, e.email, e.rewrite AS broken
-         FROM  aliases AS a
-   INNER JOIN  emails  AS e ON (a.uid = e.uid AND rewrite != '')
-    LEFT JOIN  aliases AS b ON (b.uid = a.uid AND rewrite LIKE CONCAT(b.alias, '@%') AND b.type != 'homonyme')
-        WHERE  a.type = 'a_vie' AND b.type IS NULL",
+check("SELECT  s1.email, r.redirect, r.rewrite AS broken
+         FROM  email_redirect_account AS r
+   INNER JOIN  email_source_account   AS s1 ON (r.uid = s1.uid AND s1.type = 'forlife')
+    LEFT JOIN  email_source_account   AS s2 ON (r.uid = s2.uid AND r.rewrite LIKE CONCAT(s2.email, '@%'))
+        WHERE  r.rewrite != '' AND s2.uid IS NULL",
       "Personnes qui ont des rewrite sur un alias perdu.");
 
 /* Lists unsound emails that remain unprocessed by the administrators. */
-check("SELECT  a1.alias, a2.alias, e1.email, e2.flags
-         FROM  emails      AS e1
-   INNER JOIN  emails      AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND
-                                     (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags)))
-   INNER JOIN  email_watch AS w  ON (w.email = e1.email AND w.state = 'pending')
-   INNER JOIN  aliases     AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie')
-   INNER JOIN  aliases     AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie')
-        WHERE  FIND_IN_SET('active', e1.flags)
-     ORDER BY  a1.alias",
+check("SELECT  s1.email, s2.email, w.email
+         FROM  email_watch            AS w
+   INNER JOIN  email_redirect_account AS r1 ON (w.email = r1.redirect)
+    LEFT JOIN  email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid)
+   INNER JOIN  email_source_account   AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife')
+    LEFT JOIN  email_source_account   AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife')
+        WHERE  w.state = 'pending'
+     GROUP BY  w.email
+     ORDER BY  w.email",
       "Donne la liste des emails douteux actuellement non traites par les administrateurs.");
 
 /* Lists dangerous and unsound emails. */
-info("SELECT  a1.alias, a2.alias, e1.email, e2.flags, w.state
-        FROM  emails      AS e1
-  INNER JOIN  emails      AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND
-                                    (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags)))
-  INNER JOIN  email_watch AS w  ON (w.email = e1.email AND w.state != 'safe')
-  INNER JOIN  aliases     AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie')
-  INNER JOIN  aliases     AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie')
-       WHERE  FIND_IN_SET('active', e1.flags)
-    ORDER BY  a1.alias",
+info("SELECT  s1.email, s2.email, w.email, w.state
+        FROM  email_watch            AS w
+  INNER JOIN  email_redirect_account AS r1 ON (w.email = r1.redirect)
+   LEFT JOIN  email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid)
+  INNER JOIN  email_source_account   AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife')
+   LEFT JOIN  email_source_account   AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife')
+       WHERE  w.state != 'safe'
+    GROUP BY  w.email
+    ORDER BY  w.email",
      "Donne la liste des emails dangereux ou douteux.");
 
 /* Lists homonyms who have an alias equals to their loginbis for more than a month. */
-check("SELECT  a.alias AS username, b.alias AS loginbis, b.expire
-         FROM  aliases AS a
-   INNER JOIN  aliases AS b ON (a.uid=b.uid AND b.type != 'homonyme' and b.expire < NOW())
-        WHERE  a.type = 'a_vie'",
+check("SELECT  e.email AS homonym, f.email AS forlife, e.expire
+         FROM  email_source_account  AS e
+   INNER JOIN  homonyms_list         AS l ON (e.uid = l.uid)
+   INNER JOIN  homonyms_list         AS h ON (l.hrmid = h.hrmid)
+   INNER JOIN  email_source_account  AS f ON (h.uid = f.uid AND f.type = 'forlife')
+        WHERE  e.expire < NOW()
+     ORDER BY  homonym, forlife",
       "Donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias.");
 
+// Check foreign keys manually when not possible because of local key beeing a primary key, and thus can not be null.
+check("SELECT  a.*
+         FROM  profile_addresses AS a
+        WHERE  a.type = 'home' AND NOT EXISTS (SELECT  *
+                                                 FROM  profiles AS p
+                                                WHERE  a.pid = p.pid)",
+      "Adresses de type 'home' reliées à un profil inexsitant.");
+check("SELECT  a.*
+         FROM  profile_addresses AS a
+        WHERE  a.type = 'job' AND NOT EXISTS (SELECT  *
+                                                FROM  profile_job AS j
+                                               WHERE  a.pid = j.pid AND a.id = j.id)",
+      "Adresses de type 'job' reliées à un emploi inexsitant.");
+check("SELECT  a.*
+         FROM  profile_addresses AS a
+        WHERE  a.type = 'hq' AND NOT EXISTS (SELECT  *
+                                               FROM  profile_job_enum AS je
+                                              WHERE  a.jobid = je.id)",
+      "Adresses de type 'hq' reliées à une entreprise inexsitante.");
+check("SELECT  a.*
+         FROM  profile_addresses AS a
+        WHERE  a.type = 'group' AND NOT EXISTS (SELECT  *
+                                                  FROM  groups AS g
+                                                 WHERE  a.groupid = g.id)",
+      "Adresses de type 'group' reliées à un groupe inexsitant.");
+
+check("SELECT  m.*
+         FROM  profile_medals AS m
+        WHERE  m.gid != 0 AND NOT EXISTS (SELECT  *
+                                            FROM  profile_medal_grade_enum AS mg
+                                           WHERE  m.mid = mg.mid AND m.gid = mg.gid)",
+      "Médailles avec grade sans correspondance dans la liste des grades.");
+
+check("SELECT  p.*
+         FROM  profile_phones AS p
+        WHERE  p.link_type = 'address' AND NOT EXISTS (SELECT  *
+                                                         FROM  profile_addresses AS a
+                                                        WHERE  p.pid = a.pid AND p.link_id = a.id)",
+      "Téléphones de type 'address' reliés à une adresses inexistante.");
+check("SELECT  p.*
+         FROM  profile_phones AS p
+        WHERE  p.link_type = 'pro' AND NOT EXISTS (SELECT  *
+                                                     FROM  profile_job AS j
+                                                    WHERE  p.pid = j.pid AND p.link_id = j.id)",
+      "Téléphones de type 'pro' reliés à un emploi inexistant.");
+check("SELECT  p.*
+         FROM  profile_phones AS p
+        WHERE  p.link_type = 'user' AND NOT EXISTS (SELECT  *
+                                                      FROM  profiles AS pf
+                                                     WHERE  p.pid = pf.pid)",
+      "Téléphones de type 'user' reliés à un profil inexistant.");
+check("SELECT  p.*
+         FROM  profile_phones AS p
+        WHERE  p.link_type = 'hq' AND NOT EXISTS (SELECT  *
+                                                    FROM  profile_job_enum AS je
+                                                   WHERE  p.link_id = je.id)",
+      "Téléphones de type 'hq' reliés à une entreprise inexistante.");
+check("SELECT  p.*
+         FROM  profile_phones AS p
+        WHERE  p.link_type = 'group' AND NOT EXISTS (SELECT  *
+                                                       FROM  groups AS g
+                                                      WHERE  p.link_id = g.id)",
+      "Téléphones de type 'group' reliés à un groupe inexistant.");
+
+// List domain aliasing with depth higher than 1: they will not be found by postfix.
+check("SELECT  evd.name
+         FROM  email_virtual_domains AS evd
+   INNER JOIN  email_virtual_domains AS evd2 ON (evd.aliasing = evd2.id)
+        WHERE  evd2.id != evd2.aliasing",
+      "Domaines aliasés de niveau 2 ou plus qui ne sont pas vu par postfix.");
+
+// Account viewing statistics
+info("SELECT  nb_profiles, hruid
+        FROM  (
+           SELECT  a.hruid AS hruid, COUNT(DISTINCT le.data) AS nb_profiles
+             FROM  log_events AS le
+        LEFT JOIN  log_sessions AS ls ON (ls.id = le.session)
+        LEFT JOIN  accounts AS a ON (a.uid = ls.uid)
+            WHERE  le.action = 30 AND ls.start >= DATE_SUB(CURRENT_DATE, INTERVAL 7 DAY)
+         GROUP BY  a.hruid
+              ) AS profile_views
+       WHERE  nb_profiles >= 100
+    ORDER BY  nb_profiles DESC",
+     "Camarades ayant consulté plus de 100 fiches au cours des 7 derniers jours.");
+
+// Counts empty profile fields that should never be empty.
+infoCountEmpty('profile_addresses', 'type');
+infoCountEmpty('profile_phones', 'link_type');
+infoCountEmpty('profile_addresses', 'text');
+infoCountEmpty('profile_addresses', 'postalText');
+infoCountEmpty('profile_education', 'eduid');
+infoCountEmpty('profile_education', 'degreeid');
+infoCountEmpty('profile_job', 'jobid');
+infoCountEmpty('profile_mentor', 'expertise');
+infoCountEmpty('profile_networking', 'address');
+infoCountEmpty('profile_phones', 'search_tel');
+infoCountEmpty('profile_phones', 'display_tel');
+
 // XXX: counts the number of remaining issues due to the merge (to be removed once all merge related issues have been fixed)
-info('SELECT  COUNT(*)
-        FROM  profile_merge_issues
-       WHERE  issues IS NULL OR issues = \'\'',
-     'Dénombre les erreurs dues à la fusion restantes.',
-     true);
+infoCountEmpty('profile_merge_issues', 'issues', true);
 
 // vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8:
 ?>