X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=bin%2Fcron%2Fcheckdb.php;h=a2dd73232e44405fd5b82a1a434fd65c900b72c4;hb=3424387cde6c635ff16c3b5459c4caa88bb76e2e;hp=98a22e75a8ba7bd023581d317f0fc5be8032045b;hpb=ee71865181e96e7b0754ef9e7da4b3cb26f4c1d7;p=platal.git diff --git a/bin/cron/checkdb.php b/bin/cron/checkdb.php index 98a22e7..a2dd732 100755 --- a/bin/cron/checkdb.php +++ b/bin/cron/checkdb.php @@ -1,7 +1,7 @@ #!/usr/bin/php5 -q total() > 0) { - echo "Erreur pour la verification : $commentaire\n$sql\n\n"; + echo "Erreur pour la vérification : $comment\n$sql\n\n"; echo "|"; while($col = $it->nextField()) { - echo "\t".$col->name."\t|"; + echo "\t" . $col->name . "\t|"; } echo "\n"; while ($arr = $it->next()) { echo "|"; - foreach ($arr as $val) echo "\t$val\t|"; + foreach ($arr as $val) { + echo "\t$val\t|"; + } echo "\n"; } echo "\n"; } } -function info($sql,$commentaire='') { +function checkCount($sql, $comment = '') +{ + $count = XDB::rawFetchOneCell($sql); + if ($err = XDB::error()) { + echo $err; + } + if ($count > 0) { + echo "Erreur pour la vérification : $comment\n$sql\n\n"; + echo "|\tTotal\t|\n|\t$count\t|\n\n"; + } +} + +function info($sql, $comment = '', $onlyCounts = false) +{ global $opt_verbose; - if ($opt_verbose) - check($sql,$commentaire); + if ($opt_verbose) { + if ($onlyCounts) { + checkCount($sql, $comment); + } else { + check($sql, $comment); + } + } +} + +function infoCountEmpty($table, $field, $nonEmpty = false) +{ + $sql = "SELECT COUNT(*) FROM $table"; + if ($nonEmpty) { + $sql .= " WHERE $field IS NOT NULL OR $field != ''"; + $negation = ' non'; + } else { + $sql .= " WHERE $field IS NULL OR $field = ''"; + $negation = ''; + } + $comment = "Nombre de champs '$field'$negation vides dans la table '$table'."; + info($sql, $comment, true); } -/* on parse les options */ -$opts = Console_GetOpt::getopt($argv, "v"); -$opt_verbose=false; +/* Parses options. */ +$opts = Console_GetOpt::getopt($argv, 'v'); +$opt_verbose = false; -if ( PEAR::isError($opts) ) { +if (PEAR::isError($opts)) { echo $opts->getMessage(); } else { $opts = $opts[0]; - foreach ( $opts as $opt) { + foreach ($opts as $opt) { switch ($opt[0]) { - case "v": - $opt_verbose=true; + case 'v': + $opt_verbose = true; break; } } } -/* Validite des flags de transmission */ -check("SELECT u.user_id, nom, prenom, promo, - emails_alias_pub, profile_freetext_pub, profile_medals_pub - FROM auth_user_md5 AS u - INNER JOIN auth_user_quick AS q USING(user_id) - WHERE (emails_alias_pub != 'private' AND emails_alias_pub != 'public') - OR (profile_freetext_pub != 'private' AND profile_freetext_pub != 'public') - OR (profile_medals_pub != 'private' AND profile_medals_pub != 'public')", - "Utilisateur n'ayant pas de flag de publicite pour leurs donnees de profil"); -check("SELECT pid - FROM profile_addresses - WHERE pub != 'private' AND pub !='ax' AND pub != 'public'", - "Utiliseur n'ayant pas de flag de publicité pour une adresse."); -check("select uid from profile_phones where pub != 'private' and pub != 'ax' and pub != 'public'", "Utiliseur n'ayant pas de flag de publicite pour un numero de téléphone"); -check("select uid from profile_networking where pub != 'private' and pub != 'public'", "Utiliseur n'ayant pas de flag de publicité pour une adresse de networking"); - -/* validite des hruid */ -check("SELECT user_id, nom, prenom, promo FROM auth_user_md5 WHERE hruid IS NULL OR hruid = ''", - "Utilisateur n'ayant pas de hruid."); - -/* validite de aliases */ -check("SELECT a.* - FROM aliases AS a - LEFT JOIN auth_user_md5 AS u ON u.user_id=a.id - WHERE (a.type='alias' OR a.type='a_vie') AND u.prenom is null"); - -/* validite de profile_education */ -check("select a.* from profile_education as a left join auth_user_md5 as u on u.user_id=a.uid where u.prenom is null"); -check("select a.* from profile_education as a left join profile_education_enum as ad on ad.id=a.eduid where ad.name is null"); - -/* validite de binet_users */ -check("select b.* from binets_ins as b left join auth_user_md5 as u on u.user_id=b.user_id where u.prenom is null"); -check("select b.* from binets_ins as b left join binets_def as bd on bd.id=b.binet_id where bd.text is null"); - -/* validite de contacts */ -check("select c.* from contacts as c left join auth_user_md5 as u on u.user_id=c.uid where u.prenom is null"); -check("select c.* from contacts as c left join auth_user_md5 as u on u.user_id=c.contact where u.prenom is null"); - -/* validite de emails */ -check("select e.* from emails as e left join auth_user_md5 as u on u.user_id=e.uid where e.uid and u.prenom is null"); - -/* validite de forums */ -check("select f.* from #forums#.abos as f left join #x4dat#.auth_user_md5 as u on u.user_id=f.uid where u.prenom is null"); -check("select f.* from #forums#.abos as f left join #forums#.list as fd on fd.fid=f.fid where fd.nom is null"); -check("select f.* from #forums#.respofaqs as f left join #forums#.list as fd on fd.fid=f.fid where fd.nom is null"); -check("select f.* from #forums#.respofaqs as f left join #x4dat#.auth_user_md5 as u on u.user_id=f.uid where u.prenom is null"); - -/* validite de groupesx_ins */ -check("select g.* from groupesx_ins as g left join auth_user_md5 as u on u.user_id=g.guid where u.prenom is null"); -check("select g.* from groupesx_ins as g left join groupesx_def as gd on g.gid=g.gid where gd.text is null"); - -/* validite de photo */ -check("select p.* from photo as p left join auth_user_md5 as u on u.user_id=p.uid where u.prenom is null"); - -/* validite des formats téléphoniques */ -check("SELECT DISTINCT g.phonePrefix - FROM geoloc_countries AS g - WHERE EXISTS (SELECT h.phonePrefix - FROM geoloc_countries AS h - WHERE h.phonePrefix = g.phonePrefix - AND h.phoneFormat != (SELECT i.phoneFormat - FROM geoloc_countries AS i - WHERE i.phonePrefix = g.phonePrefix - LIMIT 1))", - "Préfixes téléphoniques qui ont des formats de numéros de téléphones différents selon les pays"); - -/* validite des champ pays */ -check("SELECT a.pid, a.countryId +/* Checks rewriting on deleted aliases. */ +check("SELECT s1.email, r.redirect, r.rewrite AS broken + FROM email_redirect_account AS r + INNER JOIN email_source_account AS s1 ON (r.uid = s1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (r.uid = s2.uid AND r.rewrite LIKE CONCAT(s2.email, '@%')) + WHERE r.rewrite != '' AND s2.uid IS NULL", + "Personnes qui ont des rewrite sur un alias perdu."); + +/* Lists unsound emails that remain unprocessed by the administrators. */ +check("SELECT s1.email, s2.email, w.email + FROM email_watch AS w + INNER JOIN email_redirect_account AS r1 ON (w.email = r1.redirect) + LEFT JOIN email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid) + INNER JOIN email_source_account AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife') + WHERE w.state = 'pending' + GROUP BY w.email + ORDER BY w.email", + "Donne la liste des emails douteux actuellement non traites par les administrateurs."); + +/* Lists dangerous and unsound emails. */ +info("SELECT s1.email, s2.email, w.email, w.state + FROM email_watch AS w + INNER JOIN email_redirect_account AS r1 ON (w.email = r1.redirect) + LEFT JOIN email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid) + INNER JOIN email_source_account AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife') + WHERE w.state != 'safe' + GROUP BY w.email + ORDER BY w.email", + "Donne la liste des emails dangereux ou douteux."); + +/* Lists homonyms who have an alias equals to their loginbis for more than a month. */ +check("SELECT e.email AS homonym, f.email AS forlife, e.expire + FROM email_source_account AS e + INNER JOIN homonyms_list AS l ON (e.uid = l.uid) + INNER JOIN homonyms_list AS h ON (l.hrmid = h.hrmid) + INNER JOIN email_source_account AS f ON (h.uid = f.uid AND f.type = 'forlife') + WHERE e.expire < NOW() + ORDER BY homonym, forlife", + "Donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias."); + +// Check foreign keys manually when not possible because of local key beeing a primary key, and thus can not be null. +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'home' AND NOT EXISTS (SELECT * + FROM profiles AS p + WHERE a.pid = p.pid)", + "Adresses de type 'home' reliées à un profil inexsitant."); +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'job' AND NOT EXISTS (SELECT * + FROM profile_job AS j + WHERE a.pid = j.pid AND a.id = j.id)", + "Adresses de type 'job' reliées à un emploi inexsitant."); +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'hq' AND NOT EXISTS (SELECT * + FROM profile_job_enum AS je + WHERE a.jobid = je.id)", + "Adresses de type 'hq' reliées à une entreprise inexsitante."); +check("SELECT a.* FROM profile_addresses AS a - LEFT JOIN geoloc_countries AS gc ON (a.countryId = gc.iso_3166_1_a2) - WHERE gc.countryFR IS NULL OR gc.countryFR = ''", - "donne la liste des pays dans les profils qui n'ont pas d'entree correspondante dans geoloc_countries"); - -/* donne la liste des emails douteux que les administrateurs n'ont pas encore traité */ -check("SELECT a1.alias, a2.alias, e1.email, e2.flags - FROM emails AS e1 - INNER JOIN emails AS e2 ON(e1.email = e2.email AND e1.uid!=e2.uid AND - (e1.uid 1", "à chaque personne de l'annuaire de l'AX (identification_ax) doit correspondre AU PLUS UNE personne de notre annuaire (auth_user_md5) -> si ce n'est pas le cas il faut regarder en manuel ce qui ne va pas !"); - -/* no alumni is allowed to have empty names */ -check("SELECT s.uid, d.public_name - FROM profile_name AS s - INNER JOIN profile_display AS d ON (d.pid = s.uid) - WHERE name = ''", "liste des personnes qui ont un de leur nom de recherche vide"); - -/* verifie qu'il n'y a pas d'utilisateurs ayant un compte Google Apps désactivé et une redirection encore active vers Google Apps */ -check("SELECT a.alias, g.g_status, u.mail_storage - FROM auth_user_md5 AS u - INNER JOIN aliases AS a ON (a.id = u.user_id AND a.type = 'a_vie') - INNER JOIN gapps_accounts AS g ON (g.l_userid = u.user_id) - WHERE FIND_IN_SET('googleapps', u.mail_storage) > 0 AND g.g_status != 'active'", - "utilisateurs ayant une redirection vers Google Apps alors que leur compte GApps n'est pas actif"); - -// vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8: + WHERE a.type = 'group' AND NOT EXISTS (SELECT * + FROM groups AS g + WHERE a.groupid = g.id)", + "Adresses de type 'group' reliées à un groupe inexsitant."); + +check("SELECT m.* + FROM profile_medals AS m + WHERE m.gid != 0 AND NOT EXISTS (SELECT * + FROM profile_medal_grade_enum AS mg + WHERE m.mid = mg.mid AND m.gid = mg.gid)", + "Médailles avec grade sans correspondance dans la liste des grades."); + +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'address' AND NOT EXISTS (SELECT * + FROM profile_addresses AS a + WHERE p.pid = a.pid AND p.link_id = a.id)", + "Téléphones de type 'address' reliés à une adresses inexistante."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'pro' AND NOT EXISTS (SELECT * + FROM profile_job AS j + WHERE p.pid = j.pid AND p.link_id = j.id)", + "Téléphones de type 'pro' reliés à un emploi inexistant."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'user' AND NOT EXISTS (SELECT * + FROM profiles AS pf + WHERE p.pid = pf.pid)", + "Téléphones de type 'user' reliés à un profil inexistant."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'hq' AND NOT EXISTS (SELECT * + FROM profile_job_enum AS je + WHERE p.link_id = je.id)", + "Téléphones de type 'hq' reliés à une entreprise inexistante."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'group' AND NOT EXISTS (SELECT * + FROM groups AS g + WHERE p.link_id = g.id)", + "Téléphones de type 'group' reliés à un groupe inexistant."); + +// List domain aliasing with depth higher than 1: they will not be found by postfix. +check("SELECT evd.name + FROM email_virtual_domains AS evd + INNER JOIN email_virtual_domains AS evd2 ON (evd.aliasing = evd2.id) + WHERE evd2.id != evd2.aliasing", + "Domaines aliasés de niveau 2 ou plus qui ne sont pas vu par postfix."); + +// Account viewing statistics +info("SELECT nb_profiles, hruid + FROM ( + SELECT a.hruid AS hruid, COUNT(DISTINCT le.data) AS nb_profiles + FROM log_events AS le + LEFT JOIN log_sessions AS ls ON (ls.id = le.session) + LEFT JOIN accounts AS a ON (a.uid = ls.uid) + WHERE le.action = 30 AND ls.start >= DATE_SUB(CURRENT_DATE, INTERVAL 7 DAY) + GROUP BY a.hruid + ) AS profile_views + WHERE nb_profiles >= 100 + ORDER BY nb_profiles DESC", + "Camarades ayant consulté plus de 100 fiches au cours des 7 derniers jours."); + +// Counts empty profile fields that should never be empty. +infoCountEmpty('profile_addresses', 'type'); +infoCountEmpty('profile_phones', 'link_type'); +infoCountEmpty('profile_addresses', 'text'); +infoCountEmpty('profile_addresses', 'postalText'); +infoCountEmpty('profile_education', 'eduid'); +infoCountEmpty('profile_education', 'degreeid'); +infoCountEmpty('profile_job', 'jobid'); +infoCountEmpty('profile_mentor', 'expertise'); +infoCountEmpty('profile_networking', 'address'); +infoCountEmpty('profile_phones', 'search_tel'); +infoCountEmpty('profile_phones', 'display_tel'); + +// XXX: counts the number of remaining issues due to the merge (to be removed once all merge related issues have been fixed) +infoCountEmpty('profile_merge_issues', 'issues', true); + +// vim:set et sw=4 sts=4 sws=4 foldmethod=marker fenc=utf-8: ?>