X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=bin%2Fcron%2Fcheckdb.php;h=a2dd73232e44405fd5b82a1a434fd65c900b72c4;hb=3424387cde6c635ff16c3b5459c4caa88bb76e2e;hp=689fe78c6a5db0c4745f7c540a22c7a60b9cae91;hpb=5ecaa68e834e823f3d2ab9ea2c3613c1ebc19bf6;p=platal.git diff --git a/bin/cron/checkdb.php b/bin/cron/checkdb.php index 689fe78..a2dd732 100755 --- a/bin/cron/checkdb.php +++ b/bin/cron/checkdb.php @@ -1,7 +1,7 @@ #!/usr/bin/php5 -q total() > 0) { - echo "Erreur pour la verification : $comment\n$sql\n\n"; + echo "Erreur pour la vérification : $comment\n$sql\n\n"; echo "|"; while($col = $it->nextField()) { echo "\t" . $col->name . "\t|"; @@ -49,13 +49,44 @@ function check($sql, $comment = '') } } -function info($sql, $comment = '') { +function checkCount($sql, $comment = '') +{ + $count = XDB::rawFetchOneCell($sql); + if ($err = XDB::error()) { + echo $err; + } + if ($count > 0) { + echo "Erreur pour la vérification : $comment\n$sql\n\n"; + echo "|\tTotal\t|\n|\t$count\t|\n\n"; + } +} + +function info($sql, $comment = '', $onlyCounts = false) +{ global $opt_verbose; if ($opt_verbose) { - check($sql, $comment); + if ($onlyCounts) { + checkCount($sql, $comment); + } else { + check($sql, $comment); + } } } +function infoCountEmpty($table, $field, $nonEmpty = false) +{ + $sql = "SELECT COUNT(*) FROM $table"; + if ($nonEmpty) { + $sql .= " WHERE $field IS NOT NULL OR $field != ''"; + $negation = ' non'; + } else { + $sql .= " WHERE $field IS NULL OR $field = ''"; + $negation = ''; + } + $comment = "Nombre de champs '$field'$negation vides dans la table '$table'."; + info($sql, $comment, true); +} + /* Parses options. */ $opts = Console_GetOpt::getopt($argv, 'v'); $opt_verbose = false; @@ -73,179 +104,148 @@ if (PEAR::isError($opts)) { } } -/* hrid correctness */ -check("SELECT uid, full_name - FROM accounts - WHERE hruid IS NULL OR hruid = ''", - "Utilisateur n'ayant pas de hruid."); -check("SELECT p.pid, pd.public_name, pd.promo - FROM profiles AS p - LEFT JOIN profile_display AS pd ON (p.pid = pd.pid) - WHERE p.hrpid IS NULL OR p.hrpid = ''", - "Profil n'ayant pas de hrpid."); - -/* No alumni is allowed to have empty names. */ -check("SELECT p.pid, p.hrpid - FROM profiles AS p - INNER JOIN profile_name AS pn ON (p.pid = pn.pid) - WHERE name = ''", - "Liste des personnes qui ont un de leur nom de recherche vide."); - /* Checks rewriting on deleted aliases. */ -check("SELECT a.alias, e.email, e.rewrite AS broken - FROM aliases AS a - INNER JOIN emails AS e ON (a.uid = e.uid AND rewrite != '') - LEFT JOIN aliases AS b ON (b.uid = a.uid AND rewrite LIKE CONCAT(b.alias, '@%') AND b.type != 'homonyme') - WHERE a.type = 'a_vie' AND b.type IS NULL", +check("SELECT s1.email, r.redirect, r.rewrite AS broken + FROM email_redirect_account AS r + INNER JOIN email_source_account AS s1 ON (r.uid = s1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (r.uid = s2.uid AND r.rewrite LIKE CONCAT(s2.email, '@%')) + WHERE r.rewrite != '' AND s2.uid IS NULL", "Personnes qui ont des rewrite sur un alias perdu."); -/* Publicity flags correctness */ -check("SELECT p.pid, p.hrpid, p.freetext_pub, p.medals_pub, p.alias_pub, - pa.pub, pc.corps_pub, pj.pub, pj.email_pub, pn.pub, pp.pub, ph.pub - FROM profiles AS p - LEFT JOIN profile_addresses AS pa ON (p.pid = pa.pid) - LEFT JOIN profile_corps AS pc ON (p.pid = pc.pid) - LEFT JOIN profile_job AS pj ON (p.pid = pj.pid) - LEFT JOIN profile_networking AS pn ON (p.pid = pn.pid) - LEFT JOIN profile_phones AS pp ON (p.pid = pp.pid) - LEFT JOIN profile_photos AS ph ON (p.pid = ph.pid) - WHERE (p.freetext_pub != 'public' AND p.freetext_pub != 'private') - OR (p.medals_pub != 'public' AND p.medals_pub != 'private') - OR (p.alias_pub != 'public' AND p.alias_pub != 'private') - OR (pa.pub != 'public' AND pa.pub != 'ax' AND pa.pub != 'private') - OR (pc.corps_pub != 'public' AND pc.corps_pub != 'ax' AND pc.corps_pub != 'private') - OR (pj.pub != 'public' AND pj.pub != 'ax' AND pj.pub != 'private') - OR (pj.email_pub != 'public' AND pj.email_pub != 'ax' AND pj.email_pub != 'private') - OR (pn.pub != 'public' AND pn.pub != 'private') - OR (pp.pub != 'public' AND pp.pub != 'ax' AND pp.pub != 'private') - OR (ph.pub != 'public' AND ph.pub != 'private')", - 'Profil ayant des flags de publicité manquant.'); - -/* Checks profile_*_enum all have a name to describe them. */ -check("SELECT * - FROM profile_binet_enum - WHERE text IS NULL OR text = ''"); -check("SELECT * - FROM profile_corps_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_corps_rank_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_education_degree_enum - WHERE degree IS NULL OR degree = ''"); -check("SELECT * - FROM profile_education_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_education_field_enum - WHERE field IS NULL OR field = ''"); -check("SELECT * - FROM profile_job_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_job_sector_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_job_subsector_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_job_subsubsector_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_langskill_enum - WHERE langue_fr IS NULL OR langue_fr = ''"); -check("SELECT * - FROM profile_medal_enum - WHERE text IS NULL OR text = ''"); -check("SELECT * - FROM profile_name_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_networking_enum - WHERE name IS NULL OR name = ''"); -check("SELECT * - FROM profile_section_enum - WHERE text IS NULL OR text = ''"); -check("SELECT * - FROM profile_skill_enum - WHERE text_fr IS NULL OR text_fr = ''"); - -/* Checks some other tables all have a name to describe them. */ -check("SELECT id, nom, diminutif - FROM groups - WHERE nom IS NULL OR nom = ''"); -check("SELECT fid, name - FROM forums - WHERE name IS NULL OR name = ''"); - -/* Checks phone formating. */ -check("SELECT DISTINCT g.phonePrefix - FROM geoloc_countries AS g - WHERE EXISTS (SELECT h.phonePrefix - FROM geoloc_countries AS h - WHERE h.phonePrefix = g.phonePrefix - AND h.phoneFormat != (SELECT i.phoneFormat - FROM geoloc_countries AS i - WHERE i.phonePrefix = g.phonePrefix - LIMIT 1))", - "Préfixes téléphoniques qui ont des formats de numéros de téléphones différents selon les pays."); - -/* Checks correctness of countries in the profiles. */ -check("SELECT pa.pid, pa.countryId - FROM profile_addresses AS pa - LEFT JOIN geoloc_countries AS gc ON (a.countryId = gc.iso_3166_1_a2) - WHERE gc.countryFR IS NULL OR gc.countryFR = ''", - "Donne la liste des pays dans les profils qui n'ont pas d'entrée correspondante dans geoloc_countries."); - /* Lists unsound emails that remain unprocessed by the administrators. */ -check("SELECT a1.alias, a2.alias, e1.email, e2.flags - FROM emails AS e1 - INNER JOIN emails AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND - (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags))) - INNER JOIN email_watch AS w ON (w.email = e1.email AND w.state = 'pending') - INNER JOIN aliases AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie') - INNER JOIN aliases AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie') - WHERE FIND_IN_SET('active', e1.flags) - ORDER BY a1.alias", +check("SELECT s1.email, s2.email, w.email + FROM email_watch AS w + INNER JOIN email_redirect_account AS r1 ON (w.email = r1.redirect) + LEFT JOIN email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid) + INNER JOIN email_source_account AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife') + WHERE w.state = 'pending' + GROUP BY w.email + ORDER BY w.email", "Donne la liste des emails douteux actuellement non traites par les administrateurs."); /* Lists dangerous and unsound emails. */ -info("SELECT a1.alias, a2.alias, e1.email, e2.flags, w.state - FROM emails AS e1 - INNER JOIN emails AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND - (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags))) - INNER JOIN email_watch AS w ON (w.email = e1.email AND w.state != 'safe') - INNER JOIN aliases AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie') - INNER JOIN aliases AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie') - WHERE FIND_IN_SET('active', e1.flags) - ORDER BY a1.alias", +info("SELECT s1.email, s2.email, w.email, w.state + FROM email_watch AS w + INNER JOIN email_redirect_account AS r1 ON (w.email = r1.redirect) + LEFT JOIN email_redirect_account AS r2 ON (w.email = r2.redirect AND r1.uid != r2.uid) + INNER JOIN email_source_account AS s1 ON (s1.uid = r1.uid AND s1.type = 'forlife') + LEFT JOIN email_source_account AS s2 ON (s2.uid = r2.uid AND s2.type = 'forlife') + WHERE w.state != 'safe' + GROUP BY w.email + ORDER BY w.email", "Donne la liste des emails dangereux ou douteux."); /* Lists homonyms who have an alias equals to their loginbis for more than a month. */ -check("SELECT a.alias AS username, b.alias AS loginbis, b.expire - FROM aliases AS a - INNER JOIN aliases AS b ON (a.uid=b.uid AND b.type != 'homonyme' and b.expire < NOW()) - WHERE a.type = 'a_vie'", +check("SELECT e.email AS homonym, f.email AS forlife, e.expire + FROM email_source_account AS e + INNER JOIN homonyms_list AS l ON (e.uid = l.uid) + INNER JOIN homonyms_list AS h ON (l.hrmid = h.hrmid) + INNER JOIN email_source_account AS f ON (h.uid = f.uid AND f.type = 'forlife') + WHERE e.expire < NOW() + ORDER BY homonym, forlife", "Donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias."); -/* Correctness of ax_id in profiles table. */ -check("SELECT pid, hrpid, ax_id, COUNT(ax_id) AS c - FROM profiles - WHERE ax_id != '0' - GROUP BY ax_id - HAVING c > 1", - "À chaque personne de l'annuaire de l'AX doit correspondre AU PLUS UNE personne de notre annuaire -> si ce n'est pas le cas il faut regarder en manuel ce qui ne va pas !"); - -/* Checks there is no user with a disactivated Google Apps account and an active redirection towards Google Apps. */ -check("SELECT a.alias, g.g_status, eo.storage - FROM email_options AS eo - INNER JOIN aliases AS a ON (a.uid = eo.uid AND a.type = 'a_vie') - INNER JOIN gapps_accounts AS g ON (g.l_userid = eo.uid) - WHERE FIND_IN_SET('googleapps', eo.storage) > 0 AND g.g_status != 'active'", - "Utilisateurs ayant une redirection vers Google Apps alors que leur compte GApps n'est pas actif."); - -/* TODO: add check on foreign keys for every table! */ - -// vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8: +// Check foreign keys manually when not possible because of local key beeing a primary key, and thus can not be null. +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'home' AND NOT EXISTS (SELECT * + FROM profiles AS p + WHERE a.pid = p.pid)", + "Adresses de type 'home' reliées à un profil inexsitant."); +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'job' AND NOT EXISTS (SELECT * + FROM profile_job AS j + WHERE a.pid = j.pid AND a.id = j.id)", + "Adresses de type 'job' reliées à un emploi inexsitant."); +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'hq' AND NOT EXISTS (SELECT * + FROM profile_job_enum AS je + WHERE a.jobid = je.id)", + "Adresses de type 'hq' reliées à une entreprise inexsitante."); +check("SELECT a.* + FROM profile_addresses AS a + WHERE a.type = 'group' AND NOT EXISTS (SELECT * + FROM groups AS g + WHERE a.groupid = g.id)", + "Adresses de type 'group' reliées à un groupe inexsitant."); + +check("SELECT m.* + FROM profile_medals AS m + WHERE m.gid != 0 AND NOT EXISTS (SELECT * + FROM profile_medal_grade_enum AS mg + WHERE m.mid = mg.mid AND m.gid = mg.gid)", + "Médailles avec grade sans correspondance dans la liste des grades."); + +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'address' AND NOT EXISTS (SELECT * + FROM profile_addresses AS a + WHERE p.pid = a.pid AND p.link_id = a.id)", + "Téléphones de type 'address' reliés à une adresses inexistante."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'pro' AND NOT EXISTS (SELECT * + FROM profile_job AS j + WHERE p.pid = j.pid AND p.link_id = j.id)", + "Téléphones de type 'pro' reliés à un emploi inexistant."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'user' AND NOT EXISTS (SELECT * + FROM profiles AS pf + WHERE p.pid = pf.pid)", + "Téléphones de type 'user' reliés à un profil inexistant."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'hq' AND NOT EXISTS (SELECT * + FROM profile_job_enum AS je + WHERE p.link_id = je.id)", + "Téléphones de type 'hq' reliés à une entreprise inexistante."); +check("SELECT p.* + FROM profile_phones AS p + WHERE p.link_type = 'group' AND NOT EXISTS (SELECT * + FROM groups AS g + WHERE p.link_id = g.id)", + "Téléphones de type 'group' reliés à un groupe inexistant."); + +// List domain aliasing with depth higher than 1: they will not be found by postfix. +check("SELECT evd.name + FROM email_virtual_domains AS evd + INNER JOIN email_virtual_domains AS evd2 ON (evd.aliasing = evd2.id) + WHERE evd2.id != evd2.aliasing", + "Domaines aliasés de niveau 2 ou plus qui ne sont pas vu par postfix."); + +// Account viewing statistics +info("SELECT nb_profiles, hruid + FROM ( + SELECT a.hruid AS hruid, COUNT(DISTINCT le.data) AS nb_profiles + FROM log_events AS le + LEFT JOIN log_sessions AS ls ON (ls.id = le.session) + LEFT JOIN accounts AS a ON (a.uid = ls.uid) + WHERE le.action = 30 AND ls.start >= DATE_SUB(CURRENT_DATE, INTERVAL 7 DAY) + GROUP BY a.hruid + ) AS profile_views + WHERE nb_profiles >= 100 + ORDER BY nb_profiles DESC", + "Camarades ayant consulté plus de 100 fiches au cours des 7 derniers jours."); + +// Counts empty profile fields that should never be empty. +infoCountEmpty('profile_addresses', 'type'); +infoCountEmpty('profile_phones', 'link_type'); +infoCountEmpty('profile_addresses', 'text'); +infoCountEmpty('profile_addresses', 'postalText'); +infoCountEmpty('profile_education', 'eduid'); +infoCountEmpty('profile_education', 'degreeid'); +infoCountEmpty('profile_job', 'jobid'); +infoCountEmpty('profile_mentor', 'expertise'); +infoCountEmpty('profile_networking', 'address'); +infoCountEmpty('profile_phones', 'search_tel'); +infoCountEmpty('profile_phones', 'display_tel'); + +// XXX: counts the number of remaining issues due to the merge (to be removed once all merge related issues have been fixed) +infoCountEmpty('profile_merge_issues', 'issues', true); + +// vim:set et sw=4 sts=4 sws=4 foldmethod=marker fenc=utf-8: ?>