X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;f=bin%2Fcron%2Fcheckdb.php;h=6f428d5c739568a064e0ab4289ddf6367d09edd8;hb=b86e9a57515f7683112b917e8b235650759e93ec;hp=ea1fdb742492c3437618473189f4cb3407bb9e98;hpb=3f5cf357e7ab02c9cbf616bc8cc3a70278af62cc;p=platal.git

diff --git a/bin/cron/checkdb.php b/bin/cron/checkdb.php
index ea1fdb7..6f428d5 100755
--- a/bin/cron/checkdb.php
+++ b/bin/cron/checkdb.php
@@ -1,7 +1,7 @@
 #!/usr/bin/php5 -q
 <?php
 /***************************************************************************
- *  Copyright (C) 2003-2009 Polytechnique.org                              *
+ *  Copyright (C) 2003-2010 Polytechnique.org                              *
  *  http://opensource.polytechnique.org/                                   *
  *                                                                         *
  *  This program is free software; you can redistribute it and/or modify   *
@@ -19,196 +19,143 @@
  *  Foundation, Inc.,                                                      *
  *  59 Temple Place, Suite 330, Boston, MA  02111-1307  USA                *
  ***************************************************************************/
-/*
- * verifie qu'il n'y a pas d'incoherences dans les tables de jointures
- *
-*/
+/* Checks inconsistances in tables and joins. */
 
-require('./connect.db.inc.php');
-require("Console/Getopt.php");
+require './connect.db.inc.php';
+require 'Console/Getopt.php';
 
-function check($sql, $commentaire='')
+function check($sql, $comment = '')
 {
     $it = XDB::iterRow($sql);
-    if ($err = XDB::error()) echo $err;
+    if ($err = XDB::error()) {
+        echo $err;
+    }
     if ($it->total() > 0) {
-        echo "Erreur pour la verification : $commentaire\n$sql\n\n";
+        echo "Erreur pour la vérification : $comment\n$sql\n\n";
         echo "|";
         while($col = $it->nextField()) {
-            echo "\t".$col->name."\t|";
+            echo "\t" . $col->name . "\t|";
         }
         echo "\n";
 
         while ($arr = $it->next()) {
             echo "|";
-            foreach ($arr as $val) echo "\t$val\t|";
+            foreach ($arr as $val) {
+                echo "\t$val\t|";
+            }
             echo "\n";
         }
         echo "\n";
     }
 }
 
-function info($sql,$commentaire='') {
+function checkCount($sql, $comment = '')
+{
+    $count = XDB::rawFetchOneCell($sql);
+    if ($err = XDB::error()) {
+        echo $err;
+    }
+    if ($count > 0) {
+        echo "Erreur pour la vérification : $comment\n$sql\n\n";
+        echo "|\tTotal\t|\n|\t$count\t|\n\n";
+    }
+}
+
+function info($sql, $comment = '', $onlyCounts = false)
+{
     global $opt_verbose;
-    if ($opt_verbose)
-        check($sql,$commentaire);
+    if ($opt_verbose) {
+        if ($onlyCounts) {
+            checkCount($sql, $comment);
+        } else {
+            check($sql, $comment);
+        }
+    }
+}
+
+function infoCountEmpty($table, $field, $nonEmpty = false)
+{
+    $sql = "SELECT COUNT(*) FROM $table";
+    if ($nonEmpty) {
+        $sql .= " WHERE $field IS NOT NULL OR $field != ''";
+        $negation = ' non';
+    } else {
+        $sql .= " WHERE $field IS NULL OR $field = ''";
+        $negation = '';
+    }
+    $comment = "Nombre de champs '$field'$negation vides dans la table '$table'.";
+    info($sql, $comment, true);
 }
 
-/* on parse les options */
-$opts = Console_GetOpt::getopt($argv, "v");
-$opt_verbose=false;
+/* Parses options. */
+$opts = Console_GetOpt::getopt($argv, 'v');
+$opt_verbose = false;
 
-if ( PEAR::isError($opts) ) {
+if (PEAR::isError($opts)) {
     echo $opts->getMessage();
 } else {
     $opts = $opts[0];
-    foreach ( $opts as $opt) {
+    foreach ($opts as $opt) {
         switch ($opt[0]) {
-          case "v":
-            $opt_verbose=true;
+          case 'v':
+            $opt_verbose = true;
             break;
         }
     }
 }
 
-/* Validite des flags de transmission */
-check("SELECT  u.user_id, nom, prenom, promo,
-               emails_alias_pub, profile_freetext_pub, profile_medals_pub
-         FROM  auth_user_md5 AS u
-   INNER JOIN  auth_user_quick AS q USING(user_id)
-        WHERE  (emails_alias_pub != 'private' AND emails_alias_pub != 'public')
-           OR  (profile_freetext_pub != 'private' AND profile_freetext_pub != 'public')
-           OR  (profile_medals_pub != 'private' AND profile_medals_pub != 'public')",
-    "Utilisateur n'ayant pas de flag de publicite pour leurs donnees de profil");
-check("SELECT  pid
-         FROM  profile_addresses
-        WHERE  pub != 'private' AND pub !='ax' AND pub != 'public'",
-      "Utiliseur n'ayant pas de flag de publicité pour une adresse.");
-check("select uid from profile_phones where pub != 'private' and pub != 'ax' and pub != 'public'", "Utiliseur n'ayant pas de flag de publicite pour un numero de téléphone");
-check("select uid from profile_networking where pub != 'private' and pub != 'public'", "Utiliseur n'ayant pas de flag de publicité pour une adresse de networking");
-
-/* validite des hruid */
-check("SELECT user_id, nom, prenom, promo FROM auth_user_md5 WHERE hruid IS NULL OR hruid = ''",
-      "Utilisateur n'ayant pas de hruid.");
-
-/* validite de aliases */
-check("SELECT a.*
-        FROM aliases       AS a
-        LEFT JOIN auth_user_md5 AS u ON u.user_id=a.id
-        WHERE (a.type='alias' OR a.type='a_vie') AND u.prenom is null");
-
-/* validite de profile_education */
-check("select a.* from profile_education as a left join auth_user_md5 as u on u.user_id=a.uid where u.prenom is null");
-check("select a.* from profile_education as a left join profile_education_enum as ad on ad.id=a.eduid where ad.name is null");
+/* Checks rewriting on deleted aliases. */
+check("SELECT  a.alias, e.email, e.rewrite AS broken
+         FROM  aliases AS a
+   INNER JOIN  emails  AS e ON (a.uid = e.uid AND rewrite != '')
+    LEFT JOIN  aliases AS b ON (b.uid = a.uid AND rewrite LIKE CONCAT(b.alias, '@%') AND b.type != 'homonyme')
+        WHERE  a.type = 'a_vie' AND b.type IS NULL",
+      "Personnes qui ont des rewrite sur un alias perdu.");
 
-/* validite de binet_users */
-check("select b.* from binets_ins as b left join auth_user_md5 as u on u.user_id=b.user_id where u.prenom is null");
-check("select b.* from binets_ins as b left join binets_def as bd on bd.id=b.binet_id where bd.text is null");
-
-/* validite de contacts */
-check("select c.* from contacts as c left join auth_user_md5 as u on u.user_id=c.uid where u.prenom is null");
-check("select c.* from contacts as c left join auth_user_md5 as u on u.user_id=c.contact where u.prenom is null");
-
-/* validite de emails */
-check("select e.* from emails as e left join auth_user_md5 as u on u.user_id=e.uid where e.uid and u.prenom is null");
-
-/* validite de forums */
-check("select f.* from forums.abos as f left join auth_user_md5 as u on u.user_id=f.uid where u.prenom is null");
-check("select f.* from forums.abos as f left join forums.list as fd on fd.fid=f.fid where fd.nom is null");
-check("select f.* from forums.respofaqs as f left join forums.list as fd on fd.fid=f.fid where fd.nom is null");
-check("select f.* from forums.respofaqs as f left join auth_user_md5 as u on u.user_id=f.uid where u.prenom is null");
-
-/* validite de groupesx_ins */
-check("select g.* from groupesx_ins as g left join auth_user_md5 as u on u.user_id=g.guid where u.prenom is null");
-check("select g.* from groupesx_ins as g left join groupesx_def as gd on g.gid=g.gid where gd.text is null");
-
-/* validite de photo */
-check("select p.* from photo as p left join auth_user_md5 as u on u.user_id=p.uid where u.prenom is null");
-
-/* validite des formats téléphoniques */
-check("SELECT DISTINCT  g.phonePrefix
-                  FROM  geoloc_countries AS g
-          WHERE EXISTS  (SELECT  h.phonePrefix
-                           FROM  geoloc_countries AS h
-                          WHERE  h.phonePrefix = g.phonePrefix
-                                 AND h.phoneFormat != (SELECT  i.phoneFormat
-                                                         FROM  geoloc_countries AS i
-                                                        WHERE  i.phonePrefix = g.phonePrefix
-                                                        LIMIT  1))",
-      "Préfixes téléphoniques qui ont des formats de numéros de téléphones différents selon les pays");
-
-/* validite des champ pays */
-check("SELECT  a.pid, a.countryId
-         FROM  profile_addresses AS a
-    LEFT JOIN  geoloc_countries  AS gc ON (a.countryId = gc.iso_3166_1_a2)
-        WHERE  gc.countryFR IS NULL OR gc.countryFR = ''",
-      "donne la liste des pays dans les profils qui n'ont pas d'entree correspondante dans geoloc_countries");
-
-/* donne la liste des emails douteux que les administrateurs n'ont pas encore traité */
+/* Lists unsound emails that remain unprocessed by the administrators. */
 check("SELECT  a1.alias, a2.alias, e1.email, e2.flags
-        FROM  emails        AS e1
-        INNER JOIN  emails        AS e2 ON(e1.email = e2.email AND e1.uid!=e2.uid AND
-            (e1.uid<e2.uid  OR  NOT FIND_IN_SET('active', e2.flags))
-            )
-        INNER JOIN  emails_watch  AS w  ON(w.email = e1.email AND w.state = 'pending')
-        INNER JOIN  aliases       AS a1 ON(a1.id=e1.uid AND a1.type='a_vie')
-        INNER JOIN  aliases       AS a2 ON(a2.id=e2.uid AND a2.type='a_vie')
-        INNER JOIN  auth_user_md5 AS u1 ON(a1.id=u1.user_id)
-        INNER JOIN  auth_user_md5 AS u2 ON(a2.id=u2.user_id)
-        WHERE  FIND_IN_SET('active', e1.flags) AND u1.nom!=u2.nom_usage AND u2.nom!=u1.nom_usage
-        ORDER BY  a1.alias",
-        "donne la liste des emails douteux actuellement non traites par les administrateurs");
-
-/* donne la liste des emails dangereux ou douteux*/
+         FROM  emails      AS e1
+   INNER JOIN  emails      AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND
+                                     (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags)))
+   INNER JOIN  email_watch AS w  ON (w.email = e1.email AND w.state = 'pending')
+   INNER JOIN  aliases     AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie')
+   INNER JOIN  aliases     AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie')
+        WHERE  FIND_IN_SET('active', e1.flags)
+     ORDER BY  a1.alias",
+      "Donne la liste des emails douteux actuellement non traites par les administrateurs.");
+
+/* Lists dangerous and unsound emails. */
 info("SELECT  a1.alias, a2.alias, e1.email, e2.flags, w.state
-        FROM  emails        AS e1
-        INNER JOIN  emails        AS e2 ON(e1.email = e2.email AND e1.uid!=e2.uid AND
-            (e1.uid<e2.uid  OR  NOT FIND_IN_SET('active', e2.flags))
-            )
-        INNER JOIN  emails_watch  AS w  ON(w.email = e1.email AND w.state != 'safe')
-        INNER JOIN  aliases       AS a1 ON(a1.id=e1.uid AND a1.type='a_vie')
-        INNER JOIN  aliases       AS a2 ON(a2.id=e2.uid AND a2.type='a_vie')
-        INNER JOIN  auth_user_md5 AS u1 ON(a1.id=u1.user_id)
-        INNER JOIN  auth_user_md5 AS u2 ON(a2.id=u2.user_id)
-        WHERE  FIND_IN_SET('active', e1.flags) AND u1.nom!=u2.nom_usage AND u2.nom!=u1.nom_usage
-        ORDER BY  a1.alias",
-        "donne la liste des emails dangereux ou douteux");
-
-/* donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois */
+        FROM  emails      AS e1
+  INNER JOIN  emails      AS e2 ON (e1.email = e2.email AND e1.uid != e2.uid AND
+                                    (e1.uid < e2.uid OR NOT FIND_IN_SET('active', e2.flags)))
+  INNER JOIN  email_watch AS w  ON (w.email = e1.email AND w.state != 'safe')
+  INNER JOIN  aliases     AS a1 ON (a1.uid = e1.uid AND a1.type = 'a_vie')
+  INNER JOIN  aliases     AS a2 ON (a2.uid = e2.uid AND a2.type = 'a_vie')
+       WHERE  FIND_IN_SET('active', e1.flags)
+    ORDER BY  a1.alias",
+     "Donne la liste des emails dangereux ou douteux.");
+
+/* Lists homonyms who have an alias equals to their loginbis for more than a month. */
 check("SELECT  a.alias AS username, b.alias AS loginbis, b.expire
-        FROM  aliases AS a
-        INNER JOIN  aliases AS b ON ( a.id=b.id AND b.type != 'homonyme' and b.expire < NOW() )
+         FROM  aliases AS a
+   INNER JOIN  aliases AS b ON (a.uid=b.uid AND b.type != 'homonyme' and b.expire < NOW())
         WHERE  a.type = 'a_vie'",
-        "donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias");
-
-/* verifie qu'il n'y a pas de gens qui recrivent sur un alias qu'ils n'ont plus */
-
-check("SELECT  a.alias AS a_un_pb, email, rewrite AS broken
-        FROM  aliases AS a
-        INNER JOIN  emails  AS e ON (a.id=e.uid AND rewrite!='')
-        LEFT  JOIN  aliases AS b ON (b.id=a.id AND rewrite LIKE CONCAT(b.alias,'@%') AND b.type!='homonyme')
-        WHERE  a.type='a_vie' AND b.type IS NULL","gens qui ont des rewrite sur un alias perdu");
-
-/* validite du champ matricule_ax de la table auth_user_md5 */
-check("SELECT  matricule,nom,prenom,matricule_ax,COUNT(matricule_ax) AS c
-        FROM  auth_user_md5
-        WHERE  matricule_ax != '0'
-        GROUP BY  matricule_ax
-        having  c > 1", "à chaque personne de l'annuaire de l'AX (identification_ax) doit correspondre AU PLUS UNE personne de notre annuaire (auth_user_md5) -> si ce n'est pas le cas il faut regarder en manuel ce qui ne va pas !");
-
-/* no alumni is allowed to have empty names */
-check("SELECT  s.uid, d.public_name
-         FROM  profile_name    AS s
-   INNER JOIN  profile_display AS d ON (d.pid = s.uid)
-        WHERE  name = ''", "liste des personnes qui ont un de leur nom de recherche vide");
-
-/* verifie qu'il n'y a pas d'utilisateurs ayant un compte Google Apps désactivé et une redirection encore active vers Google Apps */
-check("SELECT  a.alias, g.g_status, u.mail_storage
-         FROM  auth_user_md5 AS u
-   INNER JOIN  aliases AS a ON (a.id = u.user_id AND a.type = 'a_vie')
-   INNER JOIN  gapps_accounts AS g ON (g.l_userid = u.user_id)
-        WHERE  FIND_IN_SET('googleapps', u.mail_storage) > 0 AND g.g_status != 'active'",
-      "utilisateurs ayant une redirection vers Google Apps alors que leur compte GApps n'est pas actif");
+      "Donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias.");
+
+// Counts empty profile fields that should never be empty.
+infoCountEmpty('profile_addresses', 'text');
+infoCountEmpty('profile_addresses', 'postalText');
+infoCountEmpty('profile_education', 'eduid');
+infoCountEmpty('profile_education', 'degreeid');
+infoCountEmpty('profile_job', 'jobid');
+infoCountEmpty('profile_mentor', 'expertise');
+infoCountEmpty('profile_networking', 'address');
+infoCountEmpty('profile_phones', 'search_tel');
+infoCountEmpty('profile_phones', 'display_tel');
+
+// XXX: counts the number of remaining issues due to the merge (to be removed once all merge related issues have been fixed)
+infoCountEmpty('profile_merge_issues', 'issues', true);
 
 // vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8:
 ?>