X-Git-Url: http://git.polytechnique.org/?a=blobdiff_plain;ds=sidebyside;f=modules%2Fregister.php;h=990dee89d3970a7a7e05e82a726e5e49b091b20f;hb=c9566e01c2add8f12a858abe0fbb0bc6b8e3c0d4;hp=48d37a848684ffe0ffcf44ec08df3f89e1d4994d;hpb=cb6e7db980fcc5fcdd2dad5aa645cfdf98057cd4;p=platal.git diff --git a/modules/register.php b/modules/register.php index 48d37a8..990dee8 100644 --- a/modules/register.php +++ b/modules/register.php @@ -31,7 +31,10 @@ class RegisterModule extends PLModule function handler_register($page, $hash = null) { - $alert = null; + $page->forceSkin('register'); + + $alert = array(); + $alert_details = ''; $subState = new PlDict(S::v('subState', array())); if (!$subState->has('step')) { $subState->set('step', 0); @@ -44,16 +47,15 @@ class RegisterModule extends PLModule $subState->v('backs')->set($subState->v('backs')->count() + 1, $subState->dict()); $subState->v('backs')->kill('backs'); if ($subState->v('backs')->count() == 3) { - $alert .= "Tentative d'inscription très hésitante - "; + $alert[] = "Tentative d'inscription très hésitante"; + $alert_details .= "\n * Retours en arrières : 3."; } } if ($hash) { - $nameTypes = DirEnum::getOptions(DirEnum::NAMETYPES); - $nameTypes = array_flip($nameTypes); - $res = XDB::query("SELECT a.uid, a.hruid, pnl.name AS lastname, pnf.name AS firstname, p.xorg_id AS xorgid, + $res = XDB::query("SELECT a.uid, a.hruid, ppn.lastname_initial AS lastname, ppn.firstname_initial AS firstname, p.xorg_id AS xorgid, pd.promo, pe.promo_year AS yearpromo, pde.degree AS edu_type, - p.birthdate_ref AS birthdateRef, FIND_IN_SET('watch', a.flags) AS watch, m.hash, a.type + p.birthdate_ref AS birthdateRef, FIND_IN_SET('watch', a.flags) AS watch, m.hash, a.type, a.comment FROM register_marketing AS m INNER JOIN accounts AS a ON (m.uid = a.uid) INNER JOIN account_profiles AS ap ON (a.uid = ap.uid AND FIND_IN_SET('owner', ap.perms)) @@ -61,10 +63,9 @@ class RegisterModule extends PLModule INNER JOIN profile_display AS pd ON (p.pid = pd.pid) INNER JOIN profile_education AS pe ON (pe.pid = p.pid AND FIND_IN_SET('primary', pe.flags)) INNER JOIN profile_education_degree_enum AS pde ON (pde.id = pe.degreeid) - INNER JOIN profile_name AS pnl ON (p.pid = pnl.pid AND pnl.typeid = {?}) - INNER JOIN profile_name AS pnf ON (p.pid = pnf.pid AND pnf.typeid = {?}) + INNER JOIN profile_public_names AS ppn ON (ppn.pid = p.pid) WHERE m.hash = {?} AND a.state = 'pending'", - $nameTypes['name_ini'], $nameTypes['firstname_ini'], $hash); + $hash); if ($res->numRows() == 1) { $subState->merge($res->fetchOneRow()); @@ -156,9 +157,10 @@ class RegisterModule extends PLModule // Validate the email address format and domain. require_once 'emails.inc.php'; + $user = User::get($subState->s('uid')); if (!isvalid_email(Post::v('email'))) { $error[] = "Le champ 'Email' n'est pas valide."; - } elseif (!isvalid_email_redirection(Post::v('email'))) { + } elseif (!isvalid_email_redirection(Post::v('email'), $user)) { $error[] = $subState->s('forlife') . ' doit renvoyer vers un email existant ' . 'valide, en particulier, il ne peut pas être renvoyé vers lui-même.'; } @@ -178,7 +180,13 @@ class RegisterModule extends PLModule $ref_year = substr($subState->v('birthdateRef'), 0, 4); if (abs($ref_year - $year) > 2) { $error[] = "La 'Date de naissance' n'est pas correcte."; - $alert = "Date de naissance incorrecte à l'inscription - "; + $alert[] = "Date de naissance incorrecte à l'inscription"; + $alert_details .= "\n * Date de naissance renseignée : " . Post::t('birthdate'); + if ($subState->v('birthdateRef') == '0000-00-00') { + $alert_details .= ' (date inconnue)'; + } else { + $alert_details .= ' (date connue : ' . $subState->v('birthdateRef') . ')'; + } $subState->set('wrong_birthdate', $birth); } } @@ -205,14 +213,16 @@ class RegisterModule extends PLModule $bannedEmail = false; if ($res->numRows()) { list($state, $description) = $res->fetchOneRow(); - $alert .= "Email surveillé proposé à l'inscription - "; + $alert[] = "Email surveillé proposé à l'inscription"; + $alert_details .= "\n * Email surveillé : " . Post::v('email'); $subState->set('email_desc', $description); if ($state == 'dangerous') { $bannedEmail = true; } } if ($subState->i('watch') != 0) { - $alert .= "Inscription d'un utilisateur surveillé - "; + $alert[] = "Inscription d'un utilisateur surveillé"; + $alert_details .= "\n * Commentaire pour la surveillance : " . $subState->v('comment'); } if (($bannedIp = check_ip('unsafe'))) { @@ -231,10 +241,17 @@ class RegisterModule extends PLModule // or if the IP address of the user has been banned. if ($subState->s('birthdateRef') != '0000-00-00' && $subState->s('birthdateRef') != $subState->s('birthdate')) { - $alert .= "Date de naissance incorrecte à l'inscription - "; + $alert[] = "Date de naissance incorrecte à l'inscription"; + $alert_details .= "\n * Date de naissance renseignée : " . Post::t('birthdate'); + if ($subState->v('birthdateRef') == '0000-00-00') { + $alert_details .= ' (date inconnue)'; + } else { + $alert_details .= ' (date connue : ' . $subState->v('birthdateRef') . ')'; + } } if ($bannedIp) { - $alert .= "Tentative d'inscription depuis une IP surveillée"; + $alert[] = "Tentative d'inscription depuis une IP surveillée"; + $alert_details .= "\n * IP surveillée : " . $_SESSION['check_ip']; } // Prevent banned user from actually registering; save the current state for others. @@ -247,7 +264,8 @@ class RegisterModule extends PLModule } else { $subState->set('step', 4); if ($subState->v('backs')->count() >= 3) { - $alert .= "Fin d'une inscription hésitante."; + $alert[] = "Fin d'une inscription hésitante"; + $alert_details .= "\n * Nombre de retours en arrière : " . $subState->v('backs')->count(); } finishRegistration($subState); } @@ -257,8 +275,11 @@ class RegisterModule extends PLModule } $_SESSION['subState'] = $subState->dict(); - if (!empty($alert)) { - send_warning_mail($alert); + if (count($alert)) { + $alert_details = "Détails des alertes :" . $alert_details . "\n\n"; + $alert_details .= 'Compte concerné : ' . $subState->s('forlife') . ' (redirection vers : ' + . ($subState->s('email') == '' ? Post::t('email') : $subState->s('email')). ")\n\n\n"; + send_warning_mail(implode(' - ', $alert), $alert_details); } $page->changeTpl('register/step' . $subState->i('step') . '.tpl'); @@ -281,25 +302,21 @@ class RegisterModule extends PLModule return PL_FORBIDDEN; } - $nameTypes = DirEnum::getOptions(DirEnum::NAMETYPES); - $nameTypes = array_flip($nameTypes); - // Retrieve the pre-registration information using the url-provided // authentication token. $res = XDB::query("SELECT r.uid, p.pid, r.forlife, r.bestalias, r.mailorg2, r.password, r.email, r.services, r.naissance, - pnl.name AS lastname, pnf.name AS firstname, pe.promo_year, - pd.promo, p.sex, p.birthdate_ref, a.type + ppn.lastname_initial, ppn.firstname_initial, pe.promo_year, + pd.promo, p.sex, p.birthdate_ref, a.type, a.email AS old_account_email FROM register_pending AS r INNER JOIN accounts AS a ON (r.uid = a.uid) INNER JOIN account_profiles AS ap ON (a.uid = ap.uid AND FIND_IN_SET('owner', ap.perms)) INNER JOIN profiles AS p ON (p.pid = ap.pid) - INNER JOIN profile_name AS pnl ON (p.pid = pnl.pid AND pnl.typeid = {?}) - INNER JOIN profile_name AS pnf ON (p.pid = pnf.pid AND pnf.typeid = {?}) + INNER JOIN profile_public_names AS ppn ON (ppn.pid = p.pid) INNER JOIN profile_display AS pd ON (p.pid = pd.pid) INNER JOIN profile_education AS pe ON (pe.pid = p.pid AND FIND_IN_SET('primary', pe.flags)) WHERE hash = {?} AND hash != 'INSCRIT' AND a.state = 'pending'", - $nameTypes['name_ini'], $nameTypes['firstname_ini'], $hash); + $hash); if (!$hash || $res->numRows() == 0) { $page->kill("
Cette adresse n'existe pas, ou plus, sur le serveur.
Causes probables :
@@ -316,7 +333,7 @@ class RegisterModule extends PLModule } list($uid, $pid, $forlife, $bestalias, $emailXorg2, $password, $email, $services, - $birthdate, $lastname, $firstname, $promo, $yearpromo, $sex, $birthdate_ref, $type) = $res->fetchOneRow(); + $birthdate, $lastname, $firstname, $yearpromo, $promo, $sex, $birthdate_ref, $type, $old_account_email) = $res->fetchOneRow(); $isX = ($type == 'x'); $mail_domain = User::$sub_mail_domains[$type] . $globals->mail->domain; @@ -375,9 +392,17 @@ class RegisterModule extends PLModule $redirect->add_email($email); fix_bestalias($user); + // If the user was registered to some aliases and MLs, we must change + // the subscription to her forlife email. + if ($old_account_email) { + $listClient = new MMList($user); + $listClient->change_user_email($old_account_email, $user->forlifeEmail()); + update_alias_user($old_account_email, $user->forlifeEmail()); + } + // Try to start a session (so the user don't have to log in); we will use // the password available in Post:: to authenticate the user. - Platal::session()->start(AUTH_MDP); + Platal::session()->start(AUTH_PASSWD); // Subscribe the user to the services she did request at registration time. require_once 'newsletter.inc.php'; @@ -436,9 +461,9 @@ class RegisterModule extends PLModule // Notify other users which were watching for her arrival. XDB::execute('INSERT INTO contacts (uid, contact) - SELECT uid, ni_id + SELECT uid, {?} FROM watch_nonins - WHERE ni_id = {?}', $uid); + WHERE ni_id = {?}', $pid, $uid); XDB::execute('DELETE FROM watch_nonins WHERE ni_id = {?}', $uid); Platal::session()->updateNbNotifs(); @@ -502,7 +527,7 @@ class RegisterModule extends PLModule $market[] = " - par {$sender->fullName()} sur $maketingEmails (le plus récemment le $lastDate)"; $mymail = new PlMailer('register/marketer.mail.tpl'); $mymail->setSubject("$firstname $lastname s'est inscrit à Polytechnique.org !"); - $mymail->addTo($sender); + $mymail->setTo($sender); $mymail->assign('sender', $sender); $mymail->assign('firstname', $firstname); $mymail->assign('lastname', $lastname);