Updates the hooks in module/carnet.php to use the new PlTokenHook.
[platal.git] / modules / xnetgrp.php
index b3da3d3..844df9d 100644 (file)
@@ -48,7 +48,7 @@ class XnetGrpModule extends PLModule
             '%grp/member/new/ajax' => $this->make_hook('admin_member_new_ajax', AUTH_MDP,    'user', NO_AUTH),
             '%grp/member/del'      => $this->make_hook('admin_member_del',      AUTH_MDP,    'groupadmin'),
 
-            '%grp/rss'             => $this->make_hook('rss',                   AUTH_PUBLIC, 'user', NO_HTTPS),
+            '%grp/rss'             => $this->make_token_hook('rss',             AUTH_PUBLIC),
             '%grp/announce/new'    => $this->make_hook('edit_announce',         AUTH_MDP,    'groupadmin'),
             '%grp/announce/edit'   => $this->make_hook('edit_announce',         AUTH_MDP,    'groupadmin'),
             '%grp/announce/photo'  => $this->make_hook('photo_announce',        AUTH_PUBLIC),
@@ -81,24 +81,34 @@ class XnetGrpModule extends PLModule
                             Env::i('unread'), S::i('uid'));
                 pl_redirect("#art" . Env::i('unread'));
             }
-            // XXX: Fix promo_min; promo_max
-            $arts = XDB::iterator("SELECT  a.*, FIND_IN_SET('photo', a.flags) AS photo
+
+            /* TODO: refines this filter on promotions by using userfilter. */
+            $user = S::user();
+            if ($user->hasProfile()) {
+                $promo = XDB::format('{?}', $user->profile()->entry_year);
+                $minCondition = ' OR promo_min <= ' . $promo;
+                $maxCondition = ' OR promo_max >= ' . $promo;
+            } else {
+                $minCondition = '';
+                $maxCondition = '';
+            }
+            $arts = XDB::iterator('SELECT  a.*, FIND_IN_SET(\'photo\', a.flags) AS photo
                                      FROM  group_announces      AS a
                                 LEFT JOIN  group_announces_read AS r ON (r.uid = {?} AND r.announce_id = a.id)
                                     WHERE  asso_id = {?} AND expiration >= CURRENT_DATE()
-                                           AND (promo_min = 0 OR promo_min <= {?})
-                                           AND (promo_max = 0 OR promo_max >= {?})
+                                           AND (promo_min = 0' . $minCondition . ')
+                                           AND (promo_max = 0' . $maxCondition . ')
                                            AND r.announce_id IS NULL
-                                 ORDER BY  a.expiration",
-                                   S::i('uid'), $globals->asso('id'), S::i('promo'), S::i('promo'));
-            $index = XDB::iterator("SELECT  a.id, a.titre, r.uid IS NULL AS nonlu
+                                 ORDER BY  a.expiration',
+                                   S::i('uid'), $globals->asso('id'));
+            $index = XDB::iterator('SELECT  a.id, a.titre, r.uid IS NULL AS nonlu
                                       FROM  group_announces      AS a
                                  LEFT JOIN  group_announces_read AS r ON (a.id = r.announce_id AND r.uid = {?})
                                      WHERE  asso_id = {?} AND expiration >= CURRENT_DATE()
-                                            AND (promo_min = 0 OR promo_min <= {?})
-                                            AND (promo_max = 0 OR promo_max >= {?})
-                                  ORDER BY  a.expiration",
-                                   S::i('uid'), $globals->asso('id'), S::i('promo'), S::i('promo'));
+                                            AND (promo_min = 0' . $minCondition . ')
+                                            AND (promo_max = 0' . $maxCondition . ')
+                                  ORDER BY  a.expiration',
+                                   S::i('uid'), $globals->asso('id'));
             $page->assign('article_index', $index);
         } else {
             $arts = XDB::iterator("SELECT  *, FIND_IN_SET('photo', flags) AS photo
@@ -120,7 +130,7 @@ class XnetGrpModule extends PLModule
                               $platal->ns . "rss/rss.xml");
         } else {
             $page->setRssLink("Polytechnique.net :: {$globals->asso("nom")} :: News",
-                              $platal->ns . 'rss/'.S::v('hruid') .'/'.S::v('token').'/rss.xml');
+                              $platal->ns . 'rss/' . S::v('hruid') . '/' . S::user()->token . '/rss.xml');
         }
 
         $page->assign('articles', $arts);
@@ -163,25 +173,37 @@ class XnetGrpModule extends PLModule
             } else {
                 $site = "";
             }
-            if (S::has_perms()) {
+            if (S::admin()) {
+                $page->assign('super', true);
+
                 if (Post::v('mail_domain') && (strstr(Post::v('mail_domain'), '.') === false)) {
                     $page->trigError('Le domaine doit être un FQDN (aucune modification effectuée)&nbsp;!!!');
                     return;
                 }
+                if (Post::t('nom') == '' || Post::t('diminutif') == '') {
+                    $page->trigError('Ni le nom ni le diminutif du groupe ne peuvent être vide.');
+                    return;
+                }
+                $axDate = make_datetime(Post::v('axDate'));
+                if (Post::t('axDate') != '') {
+                    $axDate = make_datetime(Post::v('axDate'))->format('Y-m-d');
+                } else {
+                    $axDate = null;
+                }
                 XDB::execute(
                     "UPDATE  groups
                         SET  nom={?}, diminutif={?}, cat={?}, dom={?},
                              descr={?}, site={?}, mail={?}, resp={?},
-                             forum={?}, mail_domain={?}, ax={?}, pub={?},
+                             forum={?}, mail_domain={?}, ax={?}, axDate = {?}, pub={?},
                              sub_url={?}, inscriptible={?}, unsub_url={?},
                              flags={?}
                       WHERE  id={?}",
                       Post::v('nom'), Post::v('diminutif'),
-                      Post::v('cat'), Post::i('dom'),
+                      Post::v('cat'), (Post::i('dom') == 0) ? null : Post::i('dom'),
                       Post::v('descr'), $site,
                       Post::v('mail'), Post::v('resp'),
                       Post::v('forum'), Post::v('mail_domain'),
-                      Post::has('ax'), Post::v('pub'),
+                      Post::has('ax'), $axDate, Post::v('pub'),
                       Post::v('sub_url'), Post::v('inscriptible'),
                       Post::v('unsub_url'), $flags, $globals->asso('id'));
                 if (Post::v('mail_domain')) {
@@ -216,11 +238,13 @@ class XnetGrpModule extends PLModule
                 }
             }
 
-            pl_redirect('../'.Post::v('diminutif', $globals->asso('diminutif')).'/edit');
+            pl_redirect('../' . Post::v('diminutif', $globals->asso('diminutif')) . '/edit');
         }
 
         if (S::admin()) {
-            $dom = XDB::iterator('SELECT * FROM group_dom ORDER BY nom');
+            $dom = XDB::iterator('SELECT  *
+                                    FROM  group_dom
+                                ORDER BY  nom');
             $page->assign('dom', $dom);
             $page->assign('super', true);
         }
@@ -231,11 +255,9 @@ class XnetGrpModule extends PLModule
         global $globals;
 
         $page->changeTpl('xnetgrp/mail.tpl');
-        $mmlist = new MMList(S::v('uid'), S::v('password'),
-                           $globals->asso('mail_domain'));
+        $mmlist = new MMList(S::user(), $globals->asso('mail_domain'));
         $page->assign('listes', $mmlist->get_lists());
         $page->assign('user', S::user());
-        $page->addJsLink('ajax.js');
 
         if (Post::has('send')) {
             S::assert_xsrf_token();
@@ -282,21 +304,25 @@ class XnetGrpModule extends PLModule
     {
         global $globals;
 
-        if ($action == 'search') {
-            http_redirect("https://www.polytechnique.org/search/adv?rechercher=Chercher&groupex={$globals->asso('id')}"
-                        . "&cityid=" . Env::v('cityid') . "&mapid=" . Env::v('mapid'));
-        } else if ($action == 'geoloc' || $action == 'trombi') {
-            $view = new UserSet();
+        if ($action == 'trombi') {
+            __autoload('userset');
+            if ($action == 'trombi') {
+                $view = new ProfileSet(new UFC_Group($globals->asso('id')));
+            } else {
+                $view = new UserSet(new UFC_Group($globals->asso('id')));
+            }
             $view->addMod('trombi', 'Trombinoscope');
-            // TODO: Reactivate when the new map is completed.
-            // $view->addMod('geoloc', 'Planisphère', false, array('with_annu' => 'annuaire/search'));
             $view->apply('annuaire', $page, $action, $subaction);
-            if ($action == 'geoloc' && $subaction) {
-                return;
-            }
+            $page->changeTpl('xnetgrp/annuaire.tpl');
+            $count = XDB::fetchOneCell('SELECT  COUNT(*)
+                                          FROM  group_members
+                                         WHERE  asso_id = {?}',
+                                       $globals->asso('id'));
+            $page->assign('nb_tot', $count);
+            return;
         }
-        $page->changeTpl('xnetgrp/annuaire.tpl');
 
+        $page->changeTpl('xnetgrp/annuaire.tpl');
         $sort = Env::s('order', 'directory_name');
         $ofs  = Env::i('offset');
         if ($ofs < 0) {
@@ -312,13 +338,14 @@ class XnetGrpModule extends PLModule
         }
 
         if (Env::b('admin')) {
-            $uf = $globals->asso()->getAdmins(null, $se);
+            $uf = $globals->asso()->getAdminsFilter(null, $se);
         } else {
-            $uf = $globals->asso()->getMembers(null, $se);
+            $uf = $globals->asso()->getMembersFilter(null, $se);
         }
         $users = $uf->getUsers(new PlLimit(NB_PER_PAGE, $ofs * NB_PER_PAGE));
         $count = $uf->getTotalCount();
 
+        $page->assign('nb_tot', $count);
         $page->assign('pages', floor(($count + NB_PER_PAGE - 1) / NB_PER_PAGE));
         $page->assign('current', $ofs);
         $page->assign('order', $sort);
@@ -340,7 +367,7 @@ class XnetGrpModule extends PLModule
     {
         global $globals;
         $vcard = new VCard($photos == 'photos', 'Membre du groupe ' . $globals->asso('nom'));
-        $vcard->addProfiles($globals->asso()->getMembers()->getProfiles());
+        $vcard->addProfiles($globals->asso()->getMembersFilter()->getProfiles());
         $vcard->show();
     }
 
@@ -350,10 +377,7 @@ class XnetGrpModule extends PLModule
         if (is_null($filename)) {
             $filename = $globals->asso('diminutif') . '.csv';
         }
-        $users = $globals->asso()->getMembers(null, new UFO_Name('directory_name'))->getUsers();
-        header('Content-Type: text/x-csv; charset=utf-8;');
-        header('Pragma: ');
-        header('Cache-Control: ');
+        $users = $globals->asso()->getMembersFilter(null, new UFO_Name('directory_name'))->getUsers();
         pl_content_headers("text/x-csv");
         $page->changeTpl('xnetgrp/annuaire-csv.tpl', NO_SKIN);
         $page->assign('users', $users);
@@ -381,13 +405,13 @@ class XnetGrpModule extends PLModule
             $mailer->setSubject('[' . $globals->asso('nom') . '] Demande d\'inscription');
             $message = ($user->isFemale() ? 'Chère' : 'Cher') . " Camarade,\n"
                      . "\n"
-                     . "  Suite à ta demande d'adhésion à " . $globals->asso('nom') . ",\n"
-                     . "j'ai le plaisir de t'annoncer que ton inscription a été validée !\n"
+                     . "  Suite à ta demande d'adhésion à " . $globals->asso('nom')
+                     . "j'ai le plaisir de t'annoncer que ton inscription a été validée !\n"
                      . "\n"
                      . "Bien cordialement,\n"
                      . "-- \n"
                      . S::user()->fullName() . '.';
-            $mailer->setTxtBody($message);
+            $mailer->setTxtBody(wordwrap($message, 72));
             $mailer->send();
         }
     }
@@ -470,16 +494,13 @@ class XnetGrpModule extends PLModule
             XDB::execute("INSERT INTO  group_member_sub_requests (asso_id, uid, ts, reason)
                                VALUES  ({?}, {?}, NOW(), {?})",
                          $globals->asso('id'), S::i('uid'), Post::v('message'));
-            $res = XDB::query('SELECT  IF(m.email IS NULL,
-                                          CONCAT(al.alias,"@polytechnique.org"),
-                                           m.email)
-                                 FROM  group_members AS m
-                           INNER JOIN  aliases   AS al ON (al.type = "a_vie"
-                                                                 AND al.uid = m.uid)
-                                WHERE  perms="admin" AND m.asso_id = {?}',
-                             $globals->asso('id'));
-            $emails = $res->fetchColumn();
-            $to     = implode(',', $emails);
+            $uf = New UserFilter(New UFC_Group($globals->asso('id'), true));
+            $admins = $uf->iterUsers();
+            $admin = $admins->next();
+            $to = $admin->bestalias;
+            while ($admin = $admins->next()) {
+                $to .= ', ' . $admin->bestalias;
+            }
 
             $append = "\n"
                     . "-- \n"
@@ -611,55 +632,83 @@ class XnetGrpModule extends PLModule
         global $globals;
 
         $page->changeTpl('xnetgrp/membres-add.tpl');
-        $page->addJsLink('ajax.js');
 
         if (is_null($email)) {
             return;
-        } else {
-            S::assert_xsrf_token();
         }
 
+        S::assert_xsrf_token();
+
+        // Finds or creates account: first cases are for users with an account.
         if (!User::isForeignEmailAddress($email)) {
+            // Standard account
             $user = User::get($email);
-            if ($user) {
-                XDB::execute("REPLACE INTO  group_members (uid, asso_id, origine)
-                                    VALUES  ({?}, {?}, 'X')",
-                             $user->id(), $globals->asso('id'));
-                pl_redirect("member/" . $user->login());
+        } else if (!isvalid_email($email)) {
+            // email might not be a regular email but an alias or a hruid
+            $user = User::get($email);
+            if (!$user) {
+                // need a valid email address
+                $page->trigError('«&nbsp;<strong>' . $email . '</strong>&nbsp;» n\'est pas une adresse email valide.');
+                return;
             }
-        } else {
-            if (isvalid_email($email)) {
-                if (Env::v('x') && Env::i('userid')) {
-                    $uid = Env::i('userid');
-                    $user = User::getWithUID($uid);
-                    if ($user && $user->state == 'pending') {
-                        if (Env::v('market')) {
-                            $market = Marketing::get($uid, $email);
-                            if (!$market) {
-                                $market = new Marketing($uid, $email, 'group', $globals->asso('nom'),
-                                                        Env::v('market_from'), S::v('uid'));
-                                $market->add();
-                            }
-                        }
-                        XDB::execute('REPLACE INTO  group_members (uid, asso_id, origine, email)
-                                            VALUES  ({?}, {?}, "X", {?})',
-                                     $uid, $globals->asso('id'), $email);
-                        $this->removeSubscriptionRequest($uid);
-                        pl_redirect("member/$email");
+        } else if (Env::v('x') && Env::i('userid')) {
+            $user = User::getWithUID(Env::i('userid'));
+            if (!$user) {
+                $page->trigError('Utilisateur invalide.');
+                return;
+            }
+
+            // User has an account but is not yet registered.
+            if ($user->state == 'pending') {
+                // Add email in account table.
+                XDB::query('UPDATE  accounts
+                               SET  email = {?}
+                             WHERE  uid = {?} AND email IS NULL',
+                           Post::t('email'), $user->id());
+                // Add email for marketing if required.
+                if (Env::v('market')) {
+                    $market = Marketing::get($user->uid, $email);
+                    if (!$market) {
+                        $market = new Marketing($user->uid, $email, 'group', $globals->asso('nom'),
+                                                Env::v('market_from'), S::v('uid'));
+                        $market->add();
                     }
-                    $page->trigError("Utilisateur invalide");
+                }
+            }
+        } else {
+            // User is of type xnet.
+            list($mbox, $domain) = explode('@', strtolower($email));
+            $hruid = User::makeHrid($mbox, $domain, 'ext');
+            // User might already have an account (in another group for example).
+            $user = User::get($hruid);
+
+            // If the user has no account yet, creates new account: build names from email address.
+            if (empty($user)) {
+                $parts = explode('.', $mbox);
+                if (count($parts) == 1) {
+                    $display_name = $full_name = $directory_name = ucfirst($mbox);
                 } else {
-                    $res = XDB::query('SELECT MAX(uid) + 1 FROM group_members');
-                    $uid = max(intval($res->fetchOneCell()), 50001);
-                    XDB::execute('REPLACE INTO  group_members (uid, asso_id, origine, email)
-                                        VALUES  ({?}, {?}, "ext", {?})',
-                                 $uid, $globals->asso('id'), $email);
-                    pl_redirect("member/$email");
+                    $firstname = ucfirst($parts[0]);
+                    $lastname = ucwords(implode(' ', array_slice($parts, 1)));
+                    $display_name = $firstname;
+                    $full_name = "$firstname $lastname";
+                    $directory_name = strtoupper($lastname) . " " . $firstname;
                 }
-            } else {
-                $page->trigError("«&nbsp;<strong>$email</strong>&nbsp;» n'est pas une adresse email valide.");
+                XDB::execute('INSERT INTO  accounts (hruid, display_name, full_name, directory_name,
+                                           email, type)
+                                   VALUES  ({?}, {?}, {?}, {?}, {?}, \'xnet\')',
+                             $hruid, $display_name, $full_name, $directory_name, $email);
+                $user = User::get($hruid);
             }
         }
+
+        if ($user) {
+            XDB::execute('INSERT IGNORE INTO  group_members (uid, asso_id)
+                                      VALUES  ({?}, {?})',
+                         $user->id(), $globals->asso('id'));
+            $this->removeSubscriptionRequest($user->id());
+            pl_redirect('member/' . $user->login());
+        }
     }
 
     function handler_admin_member_new_ajax(&$page)
@@ -674,16 +723,16 @@ class XnetGrpModule extends PLModule
             }
         }
         if (empty($users)) {
-            list($nom, $prenom) = str_replace(array('-', ' ', "'"), '%', array(Env::t('nom'), Env::t('prenom')));
+            list($lastname, $firstname) = str_replace(array('-', ' ', "'"), '%', array(Env::t('nom'), Env::t('prenom')));
             $cond = new PFC_And(new PFC_Not(new UFC_Registered()));
-            if (!empty($nom)) {
-                $cond->addChild(new UFC_Name(Profile::LASTNAME, $nom, UFC_Name::CONTAINS));
+            if (!empty($lastname)) {
+                $cond->addChild(new UFC_Name(Profile::LASTNAME, $lastname, UFC_Name::CONTAINS));
             }
-            if (!empty($prenom)) {
-                $cond->addChild(new UFC_Name(Profile::FIRSTNAME, $prenom, UFC_Name::CONTAINS));
+            if (!empty($firstname)) {
+                $cond->addChild(new UFC_Name(Profile::FIRSTNAME, $firstname, UFC_Name::CONTAINS));
             }
-            if (Env::i('promo')) {
-                $cond->addChild(new UFC_Promo('=', UserFilter::GRADE_ING, Env::i('promo')));
+            if (Env::t('promo')) {
+                $cond->addChild(new UFC_Promo('=', UserFilter::DISPLAY, Env::t('promo')));
             }
             $uf = new UserFilter($cond);
             $users = $uf->getUsers(new PlLimit(30));
@@ -704,8 +753,9 @@ class XnetGrpModule extends PLModule
 
         if ($globals->asso('notif_unsub')) {
             $mailer = new PlMailer('xnetgrp/unsubscription-notif.mail.tpl');
-            foreach ($globals->asso()->getMembers()->getUsers() as $user) {
-                $mailer->addTo($user);
+            $admins = $globals->asso()->iterAdmins();
+            while ($admin = $admins->next()) {
+                $mailer->addTo($admin);
             }
             $mailer->assign('group', $globals->asso('nom'));
             $mailer->assign('user', $user);
@@ -718,23 +768,25 @@ class XnetGrpModule extends PLModule
             return true;
         }
 
-        $mmlist = new MMList($user, $domain);
+        $mmlist = new MMList(S::user(), $domain);
         $listes = $mmlist->get_lists($user->forlifeEmail());
 
         $may_update = may_update();
         $warning    = false;
-        foreach ($listes as $liste) {
-            if ($liste['sub'] == 2) {
-                if ($may_update) {
-                    $mmlist->mass_unsubscribe($liste['list'], Array($user->forlifeEmail()));
-                } else {
-                    $mmlist->unsubscribe($liste['list']);
+        if (is_array($listes)) {
+            foreach ($listes as $liste) {
+                if ($liste['sub'] == 2) {
+                    if ($may_update) {
+                        $mmlist->mass_unsubscribe($liste['list'], Array($user->forlifeEmail()));
+                    } else {
+                        $mmlist->unsubscribe($liste['list']);
+                    }
+                } elseif ($liste['sub']) {
+                    Platal::page()->trigWarning($user->fullName() . " a une"
+                                               ." demande d'inscription en cours sur la"
+                                               ." liste {$liste['list']}@ !");
+                    $warning = true;
                 }
-            } elseif ($liste['sub']) {
-                Platal::page()->trigWarning($user->fullName() . " a une"
-                                           ." demande d'inscription en cours sur la"
-                                           ." liste {$liste['list']}@ !");
-                $warning = true;
             }
         }
 
@@ -749,12 +801,13 @@ class XnetGrpModule extends PLModule
     function handler_unsubscribe(&$page)
     {
         $page->changeTpl('xnetgrp/membres-del.tpl');
-        $user = S::user()->id();
-        if (empty($user)) {
+        $user = S::user();
+        $uid  = S::user()->id();
+        if (empty($uid)) {
             return PL_NOT_FOUND;
         }
         $page->assign('self', true);
-        $page->assign('user', $user);
+        $page->assign('user', $uid);
 
         if (!Post::has('confirm')) {
             return;
@@ -794,71 +847,28 @@ class XnetGrpModule extends PLModule
 
     private function changeLogin(PlPage &$page, PlUser &$user, MMList &$mmlist, $login)
     {
-        // Search the uid of the user...
-        $res = XDB::query("SELECT  f.uid, f.alias
-                             FROM  aliases AS a
-                       INNER JOIN  aliases AS f ON (f.uid = a.uid AND f.type = 'a_vie')
-                            WHERE  a.alias = {?}",
-                          $login);
-        if ($res->numRows() == 0) {
-            // TODO: replace this call to a removed function.
-            $x = get_not_registered_user($login);
-            if (!$x) {
-                $page->trigError("Le login $login ne correspond à aucun X.");
+        // Search the user's uid.
+        $xuser = User::getSilent($login);
+        if (!$xuser) {
+            $accounts = User::getPendingAccounts($login);
+            if (!$accounts) {
+                $page->trigError("L'identifiant $login ne correspond à aucun X.");
                 return false;
-            } else if (count($x) > 1) {
-                $page->trigError("Le login $login correspond a plusieurs camarades.");
+            } else if (count($accounts) > 1) {
+                $page->trigError("L'identifiant $login correspond à plusieurs camarades.");
                 return false;
             }
-            $uid = $x[0]['uid'];
-            $sub = false;
-        } else {
-            list($uid, $login) = $res->fetchOneRow();
-            $sub = true;
+            $xuser = User::getSilent($accounts[0]['uid']);
         }
 
-        // Check if the user is already in the group
-        global $globals;
-        $res = XDB::query("SELECT  uid, email
-                             FROM  group_members
-                            WHERE  uid = {?} AND asso_id = {?}",
-                          $uid, $globals->asso('id'));
-        if ($res->numRows()) {
-            list($uid, $email) = $res->fetchOneRow();
-            XDB::execute("DELETE FROM group_members
-                                WHERE uid = {?}",
-                         $user['uid']);
-        } else {
-            $email = $user['email'];
-            XDB::execute("UPDATE  group_members
-                             SET  uid = {?}, origine = 'X'
-                           WHERE  uid = {?} AND asso_id = {?}",
-                         $uid, $user['uid'], $globals->asso('id'));
-        }
-        if ($sub) {
-            $email = $login . '@' . $globals->mail->domain;
+        if (!$xuser) {
+            return false;
         }
 
-        // Update subscription to aliases
-        if ($email != $user['email']) {
-            XDB::execute("UPDATE IGNORE  virtual_redirect AS vr
-                             INNER JOIN  virtual AS v ON(vr.vid = v.vid AND SUBSTRING_INDEX(alias, '@', -1) = {?})
-                                    SET  vr.redirect = {?}
-                                  WHERE  vr.redirect = {?}",
-                         $globals->asso('mail_domain'), $email, $user['email']);
-            XDB::execute("DELETE  vr.*
-                            FROM  virtual_redirect AS vr
-                      INNER JOIN  virtual AS v ON(vr.vid = v.vid AND SUBSTRING_INDEX(alias, '@', -1) = {?})
-                           WHERE  vr.redirect = {?}",
-                         $globals->asso('mail_domain'), $user['email']);
-            foreach (Env::v('ml1', array()) as $ml => $state) {
-                $mmlist->replace_email($ml, $user['email'], $email);
-            }
+        if ($user->mergeIn($xuser)) {
+            return $xuser->login();
         }
-        if ($sub) {
-            return $login;
-        }
-        return $user['email'];
+        return $user->login();
     }
 
     function handler_admin_member(&$page, $user)
@@ -872,14 +882,13 @@ class XnetGrpModule extends PLModule
             return PL_NOT_FOUND;
         }
 
-        $mmlist = new MMList($user, $globals->asso('mail_domain'));
+        $mmlist = new MMList(S::user(), $globals->asso('mail_domain'));
 
         if (Post::has('change')) {
             S::assert_xsrf_token();
 
             // Convert user status to X
-            if (Post::blank('login_X')) {
-                // TODO: Rewrite changeLogin!!!
+            if (!Post::blank('login_X')) {
                 $forlife = $this->changeLogin($page, $user, $mmlist, Post::t('login_X'));
                 if ($forlife) {
                     pl_redirect('member/' . $forlife);
@@ -887,102 +896,123 @@ class XnetGrpModule extends PLModule
             }
 
             // Update user info
-            $email_changed = ($user['origine'] != 'X' && strtolower($user['email']) != strtolower(Post::v('email')));
-            $from_email = $user['email'];
-            if ($user['origine'] != 'X') {
-                $user['nom']     = Post::v('nom');
-                $user['prenom']  = (Post::v('origine') == 'ext') ? Post::v('prenom') : '';
-                $user['sexe']    = (Post::v('origine') == 'ext') ? Post::v('sexe') : 0;
-                $user['origine'] = Post::v('origine');
-                XDB::query('UPDATE  group_members
-                               SET  prenom = {?}, nom = {?}, email = {?}, sexe = {?}, origine = {?}
-                             WHERE  uid = {?} AND asso_id = {?}',
-                           $user['prenom'], $user['nom'], Post::v('email'),
-                           $user['sexe'], $user['origine'],
-                           $user['uid'], $globals->asso('id'));
-                $user['email']   = Post::v('email');
-                $user['email2']  = Post::v('email');
+            $email_changed = (!$user->profile() && strtolower($user->forlifeEmail()) != strtolower(Post::v('email')));
+            $from_email = $user->forlifeEmail();
+            if (!$user->profile()) {
+                XDB::query('UPDATE  accounts
+                               SET  full_name = {?}, directory_name = {?}, display_name = {?},
+                                    sex = {?}, email = {?}, type = {?}
+                             WHERE  uid = {?}',
+                           Post::t('full_name'), Post::t('directory_name'), Post::t('display_name'),
+                           (Post::t('sex') == 'male') ? 'male' : 'female', Post::t('email'),
+                           (Post::t('type') == 'xnet') ? 'xnet' : 'virtual', $user->id());
+            } else if (!$user->perms) {
+                XDB::query('UPDATE  accounts
+                               SET  email = {?}
+                             WHERE  uid = {?}',
+                           Post::t('email'), $user->id());
+            }
+            if (XDB::affectedRows()) {
                 $page->trigSuccess('Données de l\'utilisateur mise à jour.');
             }
 
-            $perms = Post::i('is_admin');
+            // Update group params for user
+            $perms = Post::v('group_perms');
             $comm  = Post::t('comm');
-            if ($user['perms'] != $perms || $user['comm'] != $comm) {
+            $position = (Post::t('group_position') == '') ? null : Post::v('group_position');
+            if ($user->group_perms != $perms || $user->group_comm != $comm || $user->group_position != $position) {
                 XDB::query('UPDATE  group_members
-                               SET  perms = {?}, comm = {?}
+                               SET  perms = {?}, comm = {?}, position = {?}
                              WHERE  uid = {?} AND asso_id = {?}',
-                            $perms ? 'admin' : 'membre', $comm,
-                            $user['uid'], $globals->asso('id'));
-                if ($perms != $user['perms']) {
-                    $page->trigSuccess('Permissions modifiées&nbsp;!');
-                }
-                if ($comm != $user['comm']) {
-                    $page->trigSuccess('Commentaire mis à jour.');
+                            ($perms == 'admin') ? 'admin' : 'membre', $comm, $position,
+                            $user->id(), $globals->asso('id'));
+                if (XDB::affectedRows()) {
+                    if ($perms != $user->group_perms) {
+                        $page->trigSuccess('Permissions modifiées&nbsp;!');
+                    }
+                    if ($comm != $user->group_comm) {
+                        $page->trigSuccess('Commentaire mis à jour.');
+                    }
+                    if ($position != $user->group_position) {
+                        $page->trigSuccess('Poste mis à jour.');
+                    }
                 }
-                $user['perms'] = $perms;
-                $user['comm'] = $comm;
             }
 
+            // Gets user info again as they might have change
+            $user = User::getSilent($user->id());
+
             // Update ML subscriptions
             foreach (Env::v('ml1', array()) as $ml => $state) {
                 $ask = empty($_REQUEST['ml2'][$ml]) ? 0 : 2;
                 if ($ask == $state) {
                     if ($state && $email_changed) {
-                        $mmlist->replace_email($ml, $from_email, $user['email2']);
-                        $page->trigSuccess("L'abonnement de {$user['prenom']} {$user['nom']} à $ml@ a été mis à jour.");
+                        $mmlist->replace_email($ml, $from_email, $user->forlifeEmail());
+                        $page->trigSuccess("L'abonnement de {$user->fullName()} à $ml@ a été mis à jour.");
                     }
                     continue;
                 }
                 if ($state == '1') {
-                    $page->trigWarning("{$user['prenom']} {$user['nom']} a "
+                    $page->trigWarning("{$user->fullName()} a "
                                ."actuellement une demande d'inscription en "
                                ."cours sur <strong>$ml@</strong> !!!");
                 } elseif ($ask) {
-                    $mmlist->mass_subscribe($ml, Array($user['email2']));
-                    $page->trigSuccess("{$user['prenom']} {$user['nom']} a été abonné à $ml@.");
+                    $mmlist->mass_subscribe($ml, Array($user->forlifeEmail()));
+                    $page->trigSuccess("{$user->fullName()} a été abonné à $ml@.");
                 } else {
                     if ($email_changed) {
                         $mmlist->mass_unsubscribe($ml, Array($from_email));
                     } else {
-                        $mmlist->mass_unsubscribe($ml, Array($user['email2']));
+                        $mmlist->mass_unsubscribe($ml, Array($user->forlifeEmail()));
                     }
-                    $page->trigSuccess("{$user['prenom']} {$user['nom']} a été désabonné de $ml@.");
+                    $page->trigSuccess("{$user->fullName()} a été désabonné de $ml@.");
                 }
             }
 
             // Change subscriptioin to aliases
             foreach (Env::v('ml3', array()) as $ml => $state) {
                 $ask = !empty($_REQUEST['ml4'][$ml]);
-                if($state == $ask) continue;
-                if($ask) {
+                if($state == $ask) {
+                    if ($state && $email_changed) {
+                        XDB::query("UPDATE  virtual_redirect AS vr, virtual AS v
+                                       SET  vr.redirect = {?}
+                                     WHERE  vr.vid = v.vid AND v.alias = {?} AND vr.redirect = {?}",
+                                     $user->forlifeEmail(), $ml, $from_email);
+                        $page->trigSuccess("L'abonnement de {$user->fullName()} à $ml a été mis à jour.");
+                    }
+                } else if($ask) {
                     XDB::query("INSERT INTO  virtual_redirect (vid,redirect)
                                      SELECT  vid,{?} FROM virtual WHERE alias={?}",
-                               $user['email'], $ml);
-                    $page->trigSuccess("{$user['prenom']} {$user['nom']} a été abonné à $ml.");
+                               $user->forlifeEmail(), $ml);
+                    $page->trigSuccess("{$user->fullName()} a été abonné à $ml.");
                 } else {
                     XDB::query("DELETE FROM  virtual_redirect
                                       USING  virtual_redirect
                                  INNER JOIN  virtual USING(vid)
                                       WHERE  redirect={?} AND alias={?}",
-                               $user['email'], $ml);
-                    $page->trigSuccess("{$user['prenom']} {$user['nom']} a été désabonné de $ml.");
+                               $from_email, $ml);
+                    $page->trigSuccess("{$user->fullName()} a été désabonné de $ml.");
                 }
             }
         }
 
+        $res = XDB::rawFetchAllAssoc('SHOW COLUMNS FROM group_members LIKE \'position\'');
+        $positions = str_replace(array('enum(', ')', '\''), '', $res[0]['Type']);
+
         $page->assign('user', $user);
         $page->assign('listes', $mmlist->get_lists($user->forlifeEmail()));
         $page->assign('alias', $user->emailAliases($globals->asso('mail_domain'), 'user', true));
+        $page->assign('positions', explode(',', $positions));
     }
 
-    function handler_rss(&$page, $user = null, $hash = null)
+    function handler_rss(PlPage& $page, PlUser& $user)
     {
         global $globals;
         $page->assign('asso', $globals->asso());
 
         $this->load('feed.inc.php');
         $feed = new XnetGrpEventFeed();
-        return $feed->run($page, $user, $hash, false);
+        return $feed->run($page, $user, false);
     }
 
     private function upload_image(PlPage &$page, PlUpload &$upload)
@@ -1052,6 +1082,7 @@ class XnetGrpModule extends PLModule
             $art['prenom']     = S::v('prenom');
             $art['promo']      = S::v('promo');
             $art['hruid']      = S::user()->login();
+            $art['uid']        = S::user()->id();
             $art['expiration'] = Post::v('expiration');
             $art['public']     = Post::has('public');
             $art['xorg']       = Post::has('xorg');
@@ -1128,7 +1159,6 @@ class XnetGrpModule extends PLModule
                                  $aid, $imgtype, $imgx, $imgy, $upload->getContents());
                 }
                 if ($art['xorg']) {
-                    require_once('validations.inc.php');
                     $article = new EvtReq("[{$globals->asso('nom')}] " . $art['titre'], $fulltext,
                                     $art['promo_min'], $art['promo_max'], $art['expiration'], "", S::user(),
                                     $upload);
@@ -1138,7 +1168,6 @@ class XnetGrpModule extends PLModule
                     $upload->rm();
                 }
                 if ($art['nl']) {
-                    require_once('validations.inc.php');
                     $article = new NLReq(S::user(), $globals->asso('nom') . " : " .$art['titre'],
                                          $art['texte'], $art['contact_html']);
                     $article->submit();
@@ -1154,9 +1183,10 @@ class XnetGrpModule extends PLModule
                            $art['id'], $globals->asso('id'));
                 if ($art['photo'] && $upload->exists()) {
                     list($imgx, $imgy, $imgtype) = $upload->imageInfo();
-                    XDB::execute("REPLACE INTO  group_announces_photo
-                                           SET  eid = {?}, attachmime = {?}, x = {?}, y = {?}, attach = {?}",
-                                 $aid, $imgtype, $imgx, $imgy, $upload->getContents());
+                    XDB::execute('INSERT INTO  group_announces_photo (eid, attachmime, attach, x, y)
+                                       VALUES  ({?}, {?}, {?}, {?}, {?})
+                      ON DUPLICATE KEY UPDATE  attachmime = VALUES(attachmime), attach = VALUES(attach), x = VALUES(x), y = VALUES(y)',
+                                 $aid, $imgtype, $upload->getContents(), $imgx, $imgy);
                     $upload->rm();
                 }
             }