#!/usr/bin/php5 -q
<?php
/***************************************************************************
- * Copyright (C) 2003-2010 Polytechnique.org *
+ * Copyright (C) 2003-2011 Polytechnique.org *
* http://opensource.polytechnique.org/ *
* *
* This program is free software; you can redistribute it and/or modify *
* Foundation, Inc., *
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA *
***************************************************************************/
-/* Checks inconsistances in tables ans joins. */
+/* Checks inconsistances in tables and joins. */
require './connect.db.inc.php';
require 'Console/Getopt.php';
echo $err;
}
if ($it->total() > 0) {
- echo "Erreur pour la verification : $comment\n$sql\n\n";
+ echo "Erreur pour la vérification : $comment\n$sql\n\n";
echo "|";
while($col = $it->nextField()) {
echo "\t" . $col->name . "\t|";
}
}
-function info($sql, $comment = '') {
+function checkCount($sql, $comment = '')
+{
+ $count = XDB::rawFetchOneCell($sql);
+ if ($err = XDB::error()) {
+ echo $err;
+ }
+ if ($count > 0) {
+ echo "Erreur pour la vérification : $comment\n$sql\n\n";
+ echo "|\tTotal\t|\n|\t$count\t|\n\n";
+ }
+}
+
+function info($sql, $comment = '', $onlyCounts = false)
+{
global $opt_verbose;
if ($opt_verbose) {
- check($sql, $comment);
+ if ($onlyCounts) {
+ checkCount($sql, $comment);
+ } else {
+ check($sql, $comment);
+ }
+ }
+}
+
+function infoCountEmpty($table, $field, $nonEmpty = false)
+{
+ $sql = "SELECT COUNT(*) FROM $table";
+ if ($nonEmpty) {
+ $sql .= " WHERE $field IS NOT NULL OR $field != ''";
+ $negation = ' non';
+ } else {
+ $sql .= " WHERE $field IS NULL OR $field = ''";
+ $negation = '';
}
+ $comment = "Nombre de champs '$field'$negation vides dans la table '$table'.";
+ info($sql, $comment, true);
}
/* Parses options. */
}
}
-/* hrid correctness */
-check("SELECT uid, full_name
- FROM accounts
- WHERE hruid IS NULL OR hruid = ''",
- "Utilisateur n'ayant pas de hruid.");
-check("SELECT p.pid, pd.public_name, pd.promo
- FROM profiles AS p
- LEFT JOIN profile_display AS pd ON (p.pid = pd.pid)
- WHERE p.hrpid IS NULL OR p.hrpid = ''",
- "Profil n'ayant pas de hrpid.");
-
-/* No alumni is allowed to have empty names. */
-check("SELECT p.pid, p.hrpid
- FROM profiles AS p
- INNER JOIN profile_name AS pn ON (p.pid = pn.pid)
- WHERE name = ''",
- "Liste des personnes qui ont un de leur nom de recherche vide.");
-
/* Checks rewriting on deleted aliases. */
check("SELECT a.alias, e.email, e.rewrite AS broken
FROM aliases AS a
WHERE a.type = 'a_vie' AND b.type IS NULL",
"Personnes qui ont des rewrite sur un alias perdu.");
-/* Publicity flags correctness */
-check("SELECT p.pid, p.hrpid, p.freetext_pub, p.medals_pub, p.alias_pub,
- pa.pub, pc.corps_pub, pj.pub, pj.email_pub, pn.pub, pp.pub, ph.pub
- FROM profiles AS p
- LEFT JOIN profile_addresses AS pa ON (p.pid = pa.pid)
- LEFT JOIN profile_corps AS pc ON (p.pid = pc.pid)
- LEFT JOIN profile_job AS pj ON (p.pid = pj.pid)
- LEFT JOIN profile_networking AS pn ON (p.pid = pn.pid)
- LEFT JOIN profile_phones AS pp ON (p.pid = pp.pid)
- LEFT JOIN profile_photos AS ph ON (p.pid = ph.pid)
- WHERE (p.freetext_pub != 'public' AND p.freetext_pub != 'private')
- OR (p.medals_pub != 'public' AND p.medals_pub != 'private')
- OR (p.alias_pub != 'public' AND p.alias_pub != 'private')
- OR (pa.pub != 'public' AND pa.pub != 'ax' AND pa.pub != 'private')
- OR (pc.corps_pub != 'public' AND pc.corps_pub != 'ax' AND pc.corps_pub != 'private')
- OR (pj.pub != 'public' AND pj.pub != 'ax' AND pj.pub != 'private')
- OR (pj.email_pub != 'public' AND pj.email_pub != 'ax' AND pj.email_pub != 'private')
- OR (pn.pub != 'public' AND pn.pub != 'private')
- OR (pp.pub != 'public' AND pp.pub != 'ax' AND pp.pub != 'private')
- OR (ph.pub != 'public' AND ph.pub != 'private')",
- 'Profil ayant des flags de publicité manquant.');
-
-/* Checks profile_*_enum all have a name to describe them. */
-check("SELECT *
- FROM profile_binet_enum
- WHERE text IS NULL OR text = ''");
-check("SELECT *
- FROM profile_corps_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_corps_rank_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_education_degree_enum
- WHERE degree IS NULL OR degree = ''");
-check("SELECT *
- FROM profile_education_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_education_field_enum
- WHERE field IS NULL OR field = ''");
-check("SELECT *
- FROM profile_job_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_job_sector_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_job_subsector_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_job_subsubsector_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_langskill_enum
- WHERE langue_fr IS NULL OR langue_fr = ''");
-check("SELECT *
- FROM profile_medal_enum
- WHERE text IS NULL OR text = ''");
-check("SELECT *
- FROM profile_name_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_networking_enum
- WHERE name IS NULL OR name = ''");
-check("SELECT *
- FROM profile_section_enum
- WHERE text IS NULL OR text = ''");
-check("SELECT *
- FROM profile_skill_enum
- WHERE text_fr IS NULL OR text_fr = ''");
-
-/* Checks some other tables all have a name to describe them. */
-check("SELECT id, nom, diminutif
- FROM groups
- WHERE nom IS NULL OR nom = ''");
-check("SELECT fid, name
- FROM forums
- WHERE name IS NULL OR name = ''");
-
-/* Checks phone formating. */
-check("SELECT DISTINCT g.phonePrefix
- FROM geoloc_countries AS g
- WHERE EXISTS (SELECT h.phonePrefix
- FROM geoloc_countries AS h
- WHERE h.phonePrefix = g.phonePrefix
- AND h.phoneFormat != (SELECT i.phoneFormat
- FROM geoloc_countries AS i
- WHERE i.phonePrefix = g.phonePrefix
- LIMIT 1))",
- "Préfixes téléphoniques qui ont des formats de numéros de téléphones différents selon les pays.");
-
-/* Checks correctness of countries in the profiles. */
-check("SELECT pa.pid, pa.countryId
- FROM profile_addresses AS pa
- LEFT JOIN geoloc_countries AS gc ON (a.countryId = gc.iso_3166_1_a2)
- WHERE gc.countryFR IS NULL OR gc.countryFR = ''",
- "Donne la liste des pays dans les profils qui n'ont pas d'entrée correspondante dans geoloc_countries.");
-
/* Lists unsound emails that remain unprocessed by the administrators. */
check("SELECT a1.alias, a2.alias, e1.email, e2.flags
FROM emails AS e1
WHERE a.type = 'a_vie'",
"Donne la liste des homonymes qui ont un alias égal à leur loginbis depuis plus d'un mois, il est temps de supprimer leur alias.");
-/* Correctness of ax_id in profiles table. */
-check("SELECT pid, hrpid, ax_id, COUNT(ax_id) AS c
- FROM profiles
- WHERE ax_id != '0'
- GROUP BY ax_id
- HAVING c > 1",
- "À chaque personne de l'annuaire de l'AX doit correspondre AU PLUS UNE personne de notre annuaire -> si ce n'est pas le cas il faut regarder en manuel ce qui ne va pas !");
-
-/* Checks there is no user with a disactivated Google Apps account and an active redirection towards Google Apps. */
-check("SELECT a.alias, g.g_status, eo.storage
- FROM email_options AS eo
- INNER JOIN aliases AS a ON (a.uid = eo.uid AND a.type = 'a_vie')
- INNER JOIN gapps_accounts AS g ON (g.l_userid = eo.uid)
- WHERE FIND_IN_SET('googleapps', eo.storage) > 0 AND g.g_status != 'active'",
- "Utilisateurs ayant une redirection vers Google Apps alors que leur compte GApps n'est pas actif.");
-
-/* TODO: add check on foreign keys for every table! */
+// Counts empty profile fields that should never be empty.
+infoCountEmpty('profile_addresses', 'text');
+infoCountEmpty('profile_addresses', 'postalText');
+infoCountEmpty('profile_education', 'eduid');
+infoCountEmpty('profile_education', 'degreeid');
+infoCountEmpty('profile_job', 'jobid');
+infoCountEmpty('profile_mentor', 'expertise');
+infoCountEmpty('profile_networking', 'address');
+infoCountEmpty('profile_phones', 'search_tel');
+infoCountEmpty('profile_phones', 'display_tel');
+
+// XXX: counts the number of remaining issues due to the merge (to be removed once all merge related issues have been fixed)
+infoCountEmpty('profile_merge_issues', 'issues', true);
// vim:set et sw=4 sts=4 sws=4 foldmethod=marker enc=utf-8:
?>
projects / platal.git / blobdiff